| Message ID | 20221110054938.925347-1-michael.wei.hong.sit@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e2a54350dc9642e7dfc07335ca355581caa9dbfe |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2,RESEND,1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices | expand |
On Thu, Nov 10, 2022 at 01:49:38PM +0800, Michael Sit Wei Hong wrote: > Current driver code will read device tree node information, > and set default values if there is no info provided. > > This is not done in non-OF devices leading to SGMII fifo depths being > set to the smallest size. > > This patch sets the value to the default value of the PHY as stated in the > PHY datasheet. > > Fixes: 4dc08dcc9f6f ("net: phy: dp83867: introduce critical chip default init for non-of platform") > Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com> https://www.spinics.net/lists/netdev/msg858366.html When sending a new version, please add any Acked-by, or Reviewed-by tags you have received. It helps get your patch merged if it can easily be seen is has been reviewed. Andrew
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 10 Nov 2022 13:49:38 +0800 you wrote: > Current driver code will read device tree node information, > and set default values if there is no info provided. > > This is not done in non-OF devices leading to SGMII fifo depths being > set to the smallest size. > > This patch sets the value to the default value of the PHY as stated in the > PHY datasheet. > > [...] Here is the summary with links: - [net,v2,RESEND,1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices https://git.kernel.org/netdev/net/c/e2a54350dc96 You are awesome, thank you!
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 6939563d3b7c..fb7df4baaf6f 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -682,6 +682,13 @@ static int dp83867_of_init(struct phy_device *phydev) */ dp83867->io_impedance = DP83867_IO_MUX_CFG_IO_IMPEDANCE_MIN / 2; + /* For non-OF device, the RX and TX FIFO depths are taken from + * default value. So, we init RX & TX FIFO depths here + * so that it is configured correctly later in dp83867_config_init(); + */ + dp83867->tx_fifo_depth = DP83867_PHYCR_FIFO_DEPTH_4_B_NIB; + dp83867->rx_fifo_depth = DP83867_PHYCR_FIFO_DEPTH_4_B_NIB; + return 0; } #endif /* CONFIG_OF_MDIO */
Current driver code will read device tree node information, and set default values if there is no info provided. This is not done in non-OF devices leading to SGMII fifo depths being set to the smallest size. This patch sets the value to the default value of the PHY as stated in the PHY datasheet. Fixes: 4dc08dcc9f6f ("net: phy: dp83867: introduce critical chip default init for non-of platform") Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com> --- v1->v2: - Add Fixes tag to commit message --- drivers/net/phy/dp83867.c | 7 +++++++ 1 file changed, 7 insertions(+)