| Message ID | 20221108082330.2086671-10-lukma@denx.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: Add support for mv88e6020 and mv88e6071 | expand |
On Tue, Nov 08, 2022 at 09:23:30AM +0100, Lukasz Majewski wrote: > The .set_max_frame_size is now set to the > mv88e6185_g1_set_max_frame_size() function. > > The global switch control register (0x4 offset) used > as well as the bit (10) are the same. > > The only difference is the misleading suffix (1632) > as the mv88e6071/mv88e6020 supports 2048 bytes > as a maximal size of the frame. Are you really sure that different members of the 6250 family have different maximum frame sizes? Marvells GPL DSDT SDK has: #define G1_DEV_88ESPANNAK_FAMILY (DEV_88E3020 | DEV_88E6020 | DEV_88E6070 | DEV_88E6071 | DEV_88E6220 | DEV_88E6250 ) The differences within a family tend to be the number of ports, if PTP is provided, if AVB is provided etc. Andrew
Hi Andrew, > On Tue, Nov 08, 2022 at 09:23:30AM +0100, Lukasz Majewski wrote: > > The .set_max_frame_size is now set to the > > mv88e6185_g1_set_max_frame_size() function. > > > > The global switch control register (0x4 offset) used > > as well as the bit (10) are the same. > > > > The only difference is the misleading suffix (1632) > > as the mv88e6071/mv88e6020 supports 2048 bytes > > as a maximal size of the frame. > > Are you really sure that different members of the 6250 family have > different maximum frame sizes? > > Marvells GPL DSDT SDK has: > > #define G1_DEV_88ESPANNAK_FAMILY (DEV_88E3020 | DEV_88E6020 | > DEV_88E6070 | DEV_88E6071 | DEV_88E6220 | DEV_88E6250 ) From the above list - all but 88E3020 are from the same IC "family" (they are listed in the same documentation pdf). They all have the 2048 B max packet size. I've re-used the mv88e6185_g1_set_max_frame_size, as it does the job > > The differences within a family tend to be the number of ports, if PTP > is provided, if AVB is provided etc. > > Andrew Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 1aba9d15a5e0..ce7723d1ffbe 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -4998,6 +4998,7 @@ static const struct mv88e6xxx_ops mv88e6071_ops = { .vtu_loadpurge = mv88e6185_g1_vtu_loadpurge, .avb_ops = &mv88e6352_avb_ops, .ptp_ops = &mv88e6250_ptp_ops, + .set_max_frame_size = mv88e6185_g1_set_max_frame_size, }; static const struct mv88e6xxx_ops mv88e6290_ops = {
The .set_max_frame_size is now set to the mv88e6185_g1_set_max_frame_size() function. The global switch control register (0x4 offset) used as well as the bit (10) are the same. The only difference is the misleading suffix (1632) as the mv88e6071/mv88e6020 supports 2048 bytes as a maximal size of the frame. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- drivers/net/dsa/mv88e6xxx/chip.c | 1 + 1 file changed, 1 insertion(+)