| Message ID | 202211111640089246472@zte.com.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mfd: exynos-lpass: use devm_platform_get_and_ioremap_resource() | expand |
On 11/11/2022 09:40, ye.xingchen@zte.com.cn wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > Convert platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. > > Reported-by: Zeal Robot <zealci@zte.com.cn> 1. I cannot find this report. This is an open source work and public collaboration. The "Reported-by" usually means that the issue was reported to us, in some way, usually in public. Can we see the report? Otherwise adding non-public, non-verifiable reports is useless and clutters our report-credit-system. 2. Where is the bug? Reported-by means there was a bug being fixed. Please describe the visible effects of bug and its impact. Otherwise please stop adding bogus reported-by messages. I have seen to many bogus reported-by tags from ZTE last months. > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> > --- > drivers/mfd/exynos-lpass.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Best regards, Krzysztof
diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c index 166cd21088cd..ac99e742a355 100644 --- a/drivers/mfd/exynos-lpass.c +++ b/drivers/mfd/exynos-lpass.c @@ -109,14 +109,12 @@ static int exynos_lpass_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct exynos_lpass *lpass; void __iomem *base_top; - struct resource *res; lpass = devm_kzalloc(dev, sizeof(*lpass), GFP_KERNEL); if (!lpass) return -ENOMEM; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - base_top = devm_ioremap_resource(dev, res); + base_top = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); if (IS_ERR(base_top)) return PTR_ERR(base_top);