mbox series

[v4,00/13] HID: ft260: fixes and performance improvements

Message ID 20221105211151.7094-1-michael.zaidman@gmail.com (mailing list archive)
Headers show
Series HID: ft260: fixes and performance improvements | expand

Message

Michael Zaidman Nov. 5, 2022, 9:11 p.m. UTC
This patch series is an updated version of this one:
https://lore.kernel.org/all/20221030203403.4637-1-michael.zaidman@gmail.com/

Changes since v3:
  - Fixes for the kernel CI bot warnings
  - We now do not miss NACK on the wakeup from the power saving mode
    on the KVM installation reported by Enrik. For details, see
    https://github.com/MichaelZaidman/hid-ft260/pull/7

Changes since v2:

  - Remove SMBus Quick command support
  - Missed NACK from big i2c read
  - Wake up device from power saving mode
  - Fix a NULL pointer dereference in ft260_i2c_write
  - Missed NACK from busy device

Changes since v1:

  - Do not populate hidraw device
  - Avoid stale read buffer pointer

Michael Zaidman (13):
  HID: ft260: ft260_xfer_status routine cleanup
  HID: ft260: improve i2c write performance
  HID: ft260: support i2c writes larger than HID report size
  HID: ft260: support i2c reads greater than HID report size
  HID: ft260: improve i2c large reads performance
  HID: ft260: do not populate /dev/hidraw device
  HID: ft260: skip unexpected HID input reports
  HID: ft260: remove SMBus Quick command support
  HID: ft260: missed NACK from big i2c read
  HID: ft260: wake up device from power saving mode
  HID: ft260: fix a NULL pointer dereference in ft260_i2c_write
  HID: ft260: missed NACK from busy device
  HID: ft260: fix sparse warnings

 drivers/hid/hid-ft260.c | 325 +++++++++++++++++++++++-----------------
 1 file changed, 191 insertions(+), 134 deletions(-)

Comments

Jiri Kosina Nov. 11, 2022, 10:19 a.m. UTC | #1
On Sat, 5 Nov 2022, Michael Zaidman wrote:

> This patch series is an updated version of this one:
> https://lore.kernel.org/all/20221030203403.4637-1-michael.zaidman@gmail.com/
> 
> Changes since v3:
>   - Fixes for the kernel CI bot warnings
>   - We now do not miss NACK on the wakeup from the power saving mode
>     on the KVM installation reported by Enrik. For details, see
>     https://github.com/MichaelZaidman/hid-ft260/pull/7
> 
> Changes since v2:
> 
>   - Remove SMBus Quick command support
>   - Missed NACK from big i2c read
>   - Wake up device from power saving mode
>   - Fix a NULL pointer dereference in ft260_i2c_write
>   - Missed NACK from busy device
> 
> Changes since v1:
> 
>   - Do not populate hidraw device
>   - Avoid stale read buffer pointer
> 
> Michael Zaidman (13):
>   HID: ft260: ft260_xfer_status routine cleanup
>   HID: ft260: improve i2c write performance
>   HID: ft260: support i2c writes larger than HID report size
>   HID: ft260: support i2c reads greater than HID report size
>   HID: ft260: improve i2c large reads performance
>   HID: ft260: do not populate /dev/hidraw device
>   HID: ft260: skip unexpected HID input reports
>   HID: ft260: remove SMBus Quick command support
>   HID: ft260: missed NACK from big i2c read
>   HID: ft260: wake up device from power saving mode
>   HID: ft260: fix a NULL pointer dereference in ft260_i2c_write
>   HID: ft260: missed NACK from busy device
>   HID: ft260: fix sparse warnings

Hi Michael,

this is now queued in hid.git#for-6.2/ft260.

Thanks,
Michael Zaidman Nov. 11, 2022, 5:13 p.m. UTC | #2
On Fri, Nov 11, 2022 at 11:19:32AM +0100, Jiri Kosina wrote:
> On Sat, 5 Nov 2022, Michael Zaidman wrote:
> 
> > This patch series is an updated version of this one:
> > https://lore.kernel.org/all/20221030203403.4637-1-michael.zaidman@gmail.com/
> > 
> > Changes since v3:
> >   - Fixes for the kernel CI bot warnings
> >   - We now do not miss NACK on the wakeup from the power saving mode
> >     on the KVM installation reported by Enrik. For details, see
> >     https://github.com/MichaelZaidman/hid-ft260/pull/7
> > 
> > Changes since v2:
> > 
> >   - Remove SMBus Quick command support
> >   - Missed NACK from big i2c read
> >   - Wake up device from power saving mode
> >   - Fix a NULL pointer dereference in ft260_i2c_write
> >   - Missed NACK from busy device
> > 
> > Changes since v1:
> > 
> >   - Do not populate hidraw device
> >   - Avoid stale read buffer pointer
> > 
> > Michael Zaidman (13):
> >   HID: ft260: ft260_xfer_status routine cleanup
> >   HID: ft260: improve i2c write performance
> >   HID: ft260: support i2c writes larger than HID report size
> >   HID: ft260: support i2c reads greater than HID report size
> >   HID: ft260: improve i2c large reads performance
> >   HID: ft260: do not populate /dev/hidraw device
> >   HID: ft260: skip unexpected HID input reports
> >   HID: ft260: remove SMBus Quick command support
> >   HID: ft260: missed NACK from big i2c read
> >   HID: ft260: wake up device from power saving mode
> >   HID: ft260: fix a NULL pointer dereference in ft260_i2c_write
> >   HID: ft260: missed NACK from busy device
> >   HID: ft260: fix sparse warnings
> 
> Hi Michael,
> 
> this is now queued in hid.git#for-6.2/ft260.
> 
> Thanks,
> 
> -- 
> Jiri Kosina
> SUSE Labs
> 

Thanks, Jiri! Much appreciated.

Michael