diff mbox series

net/mlx5e: remove unused list in arfs

Message ID 20221031165604.1771965-1-anisse@astier.eu (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net/mlx5e: remove unused list in arfs | expand

Checks

Context Check Description
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 8 of 8 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 14 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Anisse Astier Oct. 31, 2022, 4:56 p.m. UTC
This is never used, and probably something that was intended to be used
before per-protocol hash tables were chosen instead.

Signed-off-by: Anisse Astier <anisse@astier.eu>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Leon Romanovsky Nov. 6, 2022, 6:22 p.m. UTC | #1
On Mon, Oct 31, 2022 at 05:56:04PM +0100, Anisse Astier wrote:
> This is never used, and probably something that was intended to be used
> before per-protocol hash tables were chosen instead.
> 
> Signed-off-by: Anisse Astier <anisse@astier.eu>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 --
>  1 file changed, 2 deletions(-)
> 

The patch subject should be "[PATCH net-next] ..."

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Saeed Mahameed Nov. 11, 2022, 10:26 p.m. UTC | #2
On 31 Oct 17:56, Anisse Astier wrote:
>This is never used, and probably something that was intended to be used
>before per-protocol hash tables were chosen instead.
>
applied to net-next-mlx5, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
index 0ae1865086ff..bed0c2d043e7 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
@@ -57,7 +57,6 @@  struct mlx5e_arfs_tables {
 	struct arfs_table arfs_tables[ARFS_NUM_TYPES];
 	/* Protect aRFS rules list */
 	spinlock_t                     arfs_lock;
-	struct list_head               rules;
 	int                            last_filter_id;
 	struct workqueue_struct        *wq;
 };
@@ -376,7 +375,6 @@  int mlx5e_arfs_create_tables(struct mlx5e_flow_steering *fs,
 		return -ENOMEM;
 
 	spin_lock_init(&arfs->arfs_lock);
-	INIT_LIST_HEAD(&arfs->rules);
 	arfs->wq = create_singlethread_workqueue("mlx5e_arfs");
 	if (!arfs->wq)
 		goto err;