diff mbox series

[v2] Bluetooth: hci_conn: add missing hci_dev_put() in iso_listen_bis()

Message ID 20221109023906.1556201-1-bobo.shaobowang@huawei.com (mailing list archive)
State Accepted
Commit e32c8d8c6f2918b45fa146e6ab63af9b7b56aba6
Headers show
Series [v2] Bluetooth: hci_conn: add missing hci_dev_put() in iso_listen_bis() | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint fail [v2] Bluetooth: hci_conn: add missing hci_dev_put() in iso_listen_bis() 13: B1 Line exceeds max length (89>80): "v1: https://lore.kernel.org/netdev/20221108112308.3910185-1-bobo.shaobowang@huawei.com/T/"
tedd_an/subjectprefix success PASS
tedd_an/buildkernel success Build Kernel PASS
tedd_an/buildkernel32 success Build Kernel32 PASS
tedd_an/incremental_build success Pass
tedd_an/testrunnersetup success Test Runner Setup PASS
tedd_an/testrunnerl2cap-tester success Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunneriso-tester success Total: 55, Passed: 55 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerbnep-tester success Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnermgmt-tester success Total: 494, Passed: 494 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerrfcomm-tester success Total: 11, Passed: 11 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersco-tester success Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerioctl-tester success Total: 28, Passed: 28 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnermesh-tester success Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersmp-tester success Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunneruserchan-tester success Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0

Commit Message

Wangshaobo (bobo) Nov. 9, 2022, 2:39 a.m. UTC 
hci_get_route() takes reference, we should use hci_dev_put() to release
it when not need anymore.

Fixes: f764a6c2c1e4 ("Bluetooth: ISO: Add broadcast support")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---

v2:
  - always release reference as it is not need anymore when
  - iso_listen_bis() finish.

v1: https://lore.kernel.org/netdev/20221108112308.3910185-1-bobo.shaobowang@huawei.com/T/

 net/bluetooth/iso.c | 1 +
 1 file changed, 1 insertion(+)

Comments

bluez.test.bot@gmail.com Nov. 9, 2022, 3:14 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=693455

---Test result---

Test Summary:
CheckPatch                    PASS      1.36 seconds
GitLint                       FAIL      0.76 seconds
SubjectPrefix                 PASS      0.64 seconds
BuildKernel                   PASS      43.57 seconds
BuildKernel32                 PASS      38.12 seconds
Incremental Build with patchesPASS      53.91 seconds
TestRunner: Setup             PASS      637.45 seconds
TestRunner: l2cap-tester      PASS      20.17 seconds
TestRunner: iso-tester        PASS      20.31 seconds
TestRunner: bnep-tester       PASS      7.74 seconds
TestRunner: mgmt-tester       PASS      123.31 seconds
TestRunner: rfcomm-tester     PASS      12.07 seconds
TestRunner: sco-tester        PASS      11.46 seconds
TestRunner: ioctl-tester      PASS      13.28 seconds
TestRunner: mesh-tester       PASS      9.59 seconds
TestRunner: smp-tester        PASS      11.31 seconds
TestRunner: userchan-tester   PASS      8.16 seconds

Details
##############################
Test: GitLint - FAIL - 0.76 seconds
Run gitlint with rule in .gitlint
[v2] Bluetooth: hci_conn: add missing hci_dev_put() in iso_listen_bis()
13: B1 Line exceeds max length (89>80): "v1: https://lore.kernel.org/netdev/20221108112308.3910185-1-bobo.shaobowang@huawei.com/T/"




---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Nov. 14, 2022, 10:10 p.m. UTC | #2 
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 9 Nov 2022 10:39:06 +0800 you wrote:
> hci_get_route() takes reference, we should use hci_dev_put() to release
> it when not need anymore.
> 
> Fixes: f764a6c2c1e4 ("Bluetooth: ISO: Add broadcast support")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
> ---
> 
> [...]

Here is the summary with links:
  - [v2] Bluetooth: hci_conn: add missing hci_dev_put() in iso_listen_bis()
    https://git.kernel.org/bluetooth/bluetooth-next/c/e32c8d8c6f29

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
index f825857db6d0..26db929b97c4 100644
--- a/net/bluetooth/iso.c
+++ b/net/bluetooth/iso.c
@@ -879,6 +879,7 @@  static int iso_listen_bis(struct sock *sk)
 				 iso_pi(sk)->bc_sid);
 
 	hci_dev_unlock(hdev);
+	hci_dev_put(hdev);
 
 	return err;
 }