| Message ID | 20221114162807.1.I0900b97128f9bb03e5f96fcb3068c227a33f143a@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: sc7280: Make herobrine-audio-rt5682 mic dtsi's match more | expand |
On 15/11/2022 01:28, Douglas Anderson wrote: > The 1-mic and 3-mic dtsi still had two minor cosmetic differences > after commit 3d11e7e120ee ("arm64: dts: qcom: sc7280: sort out the > "Status" to last property with > sc7280-herobrine-audio-rt5682.dtsi"). Let's fix them so the two files > diff better. This is expected to have no effect though it will > slightly change the generated dtb by removing an unnecessary 'status = > "okay"' from the sound node. Also known as "no functional change"! Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > index fc7a659dfe4a..af685bc35e10 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > @@ -19,8 +19,6 @@ sound: sound { > #address-cells = <1>; > #size-cells = <0>; > > - status = "okay"; > - > dai-link@0 { > link-name = "MAX98360"; > reg = <0>; > @@ -96,6 +94,8 @@ dai-link@1 { > }; > }; > > +/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */ > + > &mi2s0_data0 { > drive-strength = <6>; > bias-disable;
On Mon, 14 Nov 2022 16:28:28 -0800, Douglas Anderson wrote: > The 1-mic and 3-mic dtsi still had two minor cosmetic differences > after commit 3d11e7e120ee ("arm64: dts: qcom: sc7280: sort out the > "Status" to last property with > sc7280-herobrine-audio-rt5682.dtsi"). Let's fix them so the two files > diff better. This is expected to have no effect though it will > slightly change the generated dtb by removing an unnecessary 'status = > "okay"' from the sound node. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sc7280: Make herobrine-audio-rt5682 mic dtsi's match more commit: f98d1a3c653e7e6f540e680eb8fef046c21cb091 Best regards,
diff better. This is expected to have no effect though it will slightly change the generated dtb by removing an unnecessary 'status = "okay"' from the sound node. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi index fc7a659dfe4a..af685bc35e10 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi @@ -19,8 +19,6 @@ sound: sound { #address-cells = <1>; #size-cells = <0>; - status = "okay"; - dai-link@0 { link-name = "MAX98360"; reg = <0>; @@ -96,6 +94,8 @@ dai-link@1 { }; }; +/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */ + &mi2s0_data0 { drive-strength = <6>; bias-disable;
The 1-mic and 3-mic dtsi still had two minor cosmetic differences after commit 3d11e7e120ee ("arm64: dts: qcom: sc7280: sort out the "Status" to last property with sc7280-herobrine-audio-rt5682.dtsi"). Let's fix them so the two files