| Message ID | 20221114194734.3287854-3-robimarko@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e50c50367d98297703f8a02e3c9241e8b4c37b8f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,1/5] dt-bindings: net: ipq4019-mdio: document IPQ6018 compatible | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 14/11/2022 20:47, Robert Marko wrote: > Now that we can match the platforms requiring clocks by compatible start > using those to allow clocks per compatible and make them required. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > Changes in v2: > * Keep clocks under properties and disallow per compatible > --- > .../bindings/net/qcom,ipq4019-mdio.yaml | 27 ++++++++++++++----- > 1 file changed, 20 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml > index f4918c9e6fd2..72561e3aeee3 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml > @@ -9,9 +9,6 @@ title: Qualcomm IPQ40xx MDIO Controller > maintainers: > - Robert Marko <robert.marko@sartura.hr> > > -allOf: > - - $ref: "mdio.yaml#" > - > properties: > compatible: > oneOf: > @@ -40,10 +37,8 @@ properties: > address range is only required by the platform IPQ50xx. > > clocks: > - maxItems: 1 > - description: | > - MDIO clock source frequency fixed to 100MHZ, this clock should be specified > - by the platform IPQ807x, IPQ60xx and IPQ50xx. > + items: > + - description: MDIO clock source frequency fixed to 100MHZ > > required: > - compatible > @@ -51,6 +46,24 @@ required: > - "#address-cells" > - "#size-cells" > > +allOf: > + - $ref: "mdio.yaml#" If there is going to be resend, drop the quotes from above during the move. Anyway: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml index f4918c9e6fd2..72561e3aeee3 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml @@ -9,9 +9,6 @@ title: Qualcomm IPQ40xx MDIO Controller maintainers: - Robert Marko <robert.marko@sartura.hr> -allOf: - - $ref: "mdio.yaml#" - properties: compatible: oneOf: @@ -40,10 +37,8 @@ properties: address range is only required by the platform IPQ50xx. clocks: - maxItems: 1 - description: | - MDIO clock source frequency fixed to 100MHZ, this clock should be specified - by the platform IPQ807x, IPQ60xx and IPQ50xx. + items: + - description: MDIO clock source frequency fixed to 100MHZ required: - compatible @@ -51,6 +46,24 @@ required: - "#address-cells" - "#size-cells" +allOf: + - $ref: "mdio.yaml#" + + - if: + properties: + compatible: + contains: + enum: + - qcom,ipq5018-mdio + - qcom,ipq6018-mdio + - qcom,ipq8074-mdio + then: + required: + - clocks + else: + properties: + clocks: false + unevaluatedProperties: false examples:
Now that we can match the platforms requiring clocks by compatible start using those to allow clocks per compatible and make them required. Signed-off-by: Robert Marko <robimarko@gmail.com> --- Changes in v2: * Keep clocks under properties and disallow per compatible --- .../bindings/net/qcom,ipq4019-mdio.yaml | 27 ++++++++++++++----- 1 file changed, 20 insertions(+), 7 deletions(-)