| Message ID | 1341375846-27882-7-git-send-email-nab@linux-iscsi.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Il 04/07/2012 06:24, Nicholas A. Bellinger ha scritto: > From: Nicholas Bellinger <nab@linux-iscsi.org> > > This is currently required for connecting to tcm_vhost in order to prevent > the client LUN scan from detecting the same tcm_vhost WWPN on multiple target > IDs. But that's what the config field is for... why can't tcm_vhost (or QEMU) set max_id to 0? Paolo > Cc: Paolo Bonzini <pbonzini@redhat.com> > Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> > Cc: Zhi Yong Wu <wuzhy@cn.ibm.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Hannes Reinecke <hare@suse.de> > Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> > --- > drivers/scsi/virtio_scsi.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c > index 391b30d..8711951 100644 > --- a/drivers/scsi/virtio_scsi.c > +++ b/drivers/scsi/virtio_scsi.c > @@ -475,7 +475,10 @@ static int __devinit virtscsi_probe(struct virtio_device *vdev) > shost->cmd_per_lun = min_t(u32, cmd_per_lun, shost->can_queue); > shost->max_sectors = virtscsi_config_get(vdev, max_sectors) ?: 0xFFFF; > shost->max_lun = virtscsi_config_get(vdev, max_lun) + 1; > - shost->max_id = virtscsi_config_get(vdev, max_target) + 1; > + /* > + * Currently required for tcm_vhost to function.. > + */ > + shost->max_id = 1; > shost->max_channel = 0; > shost->max_cmd_len = VIRTIO_SCSI_CDB_SIZE; > err = scsi_add_host(shost, &vdev->dev); > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2012-07-04 at 16:50 +0200, Paolo Bonzini wrote: > Il 04/07/2012 06:24, Nicholas A. Bellinger ha scritto: > > From: Nicholas Bellinger <nab@linux-iscsi.org> > > > > This is currently required for connecting to tcm_vhost in order to prevent > > the client LUN scan from detecting the same tcm_vhost WWPN on multiple target > > IDs. > > But that's what the config field is for... why can't tcm_vhost (or QEMU) > set max_id to 0? > So this patch was carried forward from Stefan's original code that I thought was required due to other limitations.. If that's not the case anymore I'm happy to drop it for now and look into a proper fix outside of virtio-scsi. > Paolo > > > Cc: Paolo Bonzini <pbonzini@redhat.com> > > Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> > > Cc: Zhi Yong Wu <wuzhy@cn.ibm.com> > > Cc: Christoph Hellwig <hch@lst.de> > > Cc: Hannes Reinecke <hare@suse.de> > > Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> > > --- > > drivers/scsi/virtio_scsi.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c > > index 391b30d..8711951 100644 > > --- a/drivers/scsi/virtio_scsi.c > > +++ b/drivers/scsi/virtio_scsi.c > > @@ -475,7 +475,10 @@ static int __devinit virtscsi_probe(struct virtio_device *vdev) > > shost->cmd_per_lun = min_t(u32, cmd_per_lun, shost->can_queue); > > shost->max_sectors = virtscsi_config_get(vdev, max_sectors) ?: 0xFFFF; > > shost->max_lun = virtscsi_config_get(vdev, max_lun) + 1; > > - shost->max_id = virtscsi_config_get(vdev, max_target) + 1; > > + /* > > + * Currently required for tcm_vhost to function.. > > + */ > > + shost->max_id = 1; > > shost->max_channel = 0; > > shost->max_cmd_len = VIRTIO_SCSI_CDB_SIZE; > > err = scsi_add_host(shost, &vdev->dev); > > > > > -- > To unsubscribe from this list: send the line "unsubscribe target-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Il 05/07/2012 04:05, Nicholas A. Bellinger ha scritto: >> > But that's what the config field is for... why can't tcm_vhost (or QEMU) >> > set max_id to 0? >> > > So this patch was carried forward from Stefan's original code that I > thought was required due to other limitations.. > > If that's not the case anymore I'm happy to drop it for now and look > into a proper fix outside of virtio-scsi. > I think max_id did not exist in the virtio-scsi configuration at the time Stefan was working on it. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 391b30d..8711951 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -475,7 +475,10 @@ static int __devinit virtscsi_probe(struct virtio_device *vdev) shost->cmd_per_lun = min_t(u32, cmd_per_lun, shost->can_queue); shost->max_sectors = virtscsi_config_get(vdev, max_sectors) ?: 0xFFFF; shost->max_lun = virtscsi_config_get(vdev, max_lun) + 1; - shost->max_id = virtscsi_config_get(vdev, max_target) + 1; + /* + * Currently required for tcm_vhost to function.. + */ + shost->max_id = 1; shost->max_channel = 0; shost->max_cmd_len = VIRTIO_SCSI_CDB_SIZE; err = scsi_add_host(shost, &vdev->dev);