| Message ID | 20221111120156.48040-6-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | MSM8956/76 and Sony Xperia X / X Compact support | expand |
On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote: > MSM8976 supports SMSM, which needs this node to also be a syscon: > move the compatible to allow that. > > Fixes: bcc8d70f912d ("dt-bindings: mailbox: Add compatible for the MSM8976") I am not sure if this is still a bug. Maybe just a missing feature? Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- Best regards, Krzysztof
Il 15/11/22 17:44, Krzysztof Kozlowski ha scritto: > On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote: >> MSM8976 supports SMSM, which needs this node to also be a syscon: >> move the compatible to allow that. >> >> Fixes: bcc8d70f912d ("dt-bindings: mailbox: Add compatible for the MSM8976") > > I am not sure if this is still a bug. Maybe just a missing feature? > This changes how you use this mailbox across the entire devicetree (as other nodes will not use mboxes = xxxx, but qcom,ipc = xxxx as syscon), so I think that this is not a missing feature? Cheers, Angelo > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- > Best regards, > Krzysztof >
On 16/11/2022 09:52, AngeloGioacchino Del Regno wrote: > Il 15/11/22 17:44, Krzysztof Kozlowski ha scritto: >> On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote: >>> MSM8976 supports SMSM, which needs this node to also be a syscon: >>> move the compatible to allow that. >>> >>> Fixes: bcc8d70f912d ("dt-bindings: mailbox: Add compatible for the MSM8976") >> >> I am not sure if this is still a bug. Maybe just a missing feature? >> > > This changes how you use this mailbox across the entire devicetree (as other > nodes will not use mboxes = xxxx, but qcom,ipc = xxxx as syscon), so I think > that this is not a missing feature? Whether it is a bug depends on existing usage. If none of msm8976 DTSes use it the other way, then it is just incomplete or missing support. Not a bug. If existing DTSes use it as syscon, thus you need to add syscon to compatible, then it would be a bugfix. Best regards, Krzysztof
Il 16/11/22 09:57, Krzysztof Kozlowski ha scritto: > On 16/11/2022 09:52, AngeloGioacchino Del Regno wrote: >> Il 15/11/22 17:44, Krzysztof Kozlowski ha scritto: >>> On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote: >>>> MSM8976 supports SMSM, which needs this node to also be a syscon: >>>> move the compatible to allow that. >>>> >>>> Fixes: bcc8d70f912d ("dt-bindings: mailbox: Add compatible for the MSM8976") >>> >>> I am not sure if this is still a bug. Maybe just a missing feature? >>> >> >> This changes how you use this mailbox across the entire devicetree (as other >> nodes will not use mboxes = xxxx, but qcom,ipc = xxxx as syscon), so I think >> that this is not a missing feature? > > Whether it is a bug depends on existing usage. If none of msm8976 DTSes > use it the other way, then it is just incomplete or missing support. Not > a bug. If existing DTSes use it as syscon, thus you need to add syscon > to compatible, then it would be a bugfix. > It's not a bugfix then. The Fixes tag shall be dropped. Same question like the other commit, should I send a v3 or can it be dropped while applying?
On 16/11/2022 10:00, AngeloGioacchino Del Regno wrote: > Il 16/11/22 09:57, Krzysztof Kozlowski ha scritto: >> On 16/11/2022 09:52, AngeloGioacchino Del Regno wrote: >>> Il 15/11/22 17:44, Krzysztof Kozlowski ha scritto: >>>> On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote: >>>>> MSM8976 supports SMSM, which needs this node to also be a syscon: >>>>> move the compatible to allow that. >>>>> >>>>> Fixes: bcc8d70f912d ("dt-bindings: mailbox: Add compatible for the MSM8976") >>>> >>>> I am not sure if this is still a bug. Maybe just a missing feature? >>>> >>> >>> This changes how you use this mailbox across the entire devicetree (as other >>> nodes will not use mboxes = xxxx, but qcom,ipc = xxxx as syscon), so I think >>> that this is not a missing feature? >> >> Whether it is a bug depends on existing usage. If none of msm8976 DTSes >> use it the other way, then it is just incomplete or missing support. Not >> a bug. If existing DTSes use it as syscon, thus you need to add syscon >> to compatible, then it would be a bugfix. >> > > It's not a bugfix then. The Fixes tag shall be dropped. > > Same question like the other commit, should I send a v3 or can it be dropped while > applying? Maybe better send a v3. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index f24fd84b4b05..e99788879485 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -20,7 +20,6 @@ properties: - enum: - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global - - qcom,msm8976-apcs-kpss-global - qcom,msm8996-apcs-hmss-global - qcom,msm8998-apcs-hmss-global - qcom,qcm2290-apcs-hmss-global @@ -36,6 +35,7 @@ properties: - qcom,msm8916-apcs-kpss-global - qcom,msm8939-apcs-kpss-global - qcom,msm8953-apcs-kpss-global + - qcom,msm8976-apcs-kpss-global - qcom,msm8994-apcs-kpss-global - qcom,qcs404-apcs-apps-global - const: syscon
MSM8976 supports SMSM, which needs this node to also be a syscon: move the compatible to allow that. Fixes: bcc8d70f912d ("dt-bindings: mailbox: Add compatible for the MSM8976") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)