mbox series

[v5,0/3] net: fec: add xdp and page pool statistics

Message ID 20221115204951.370217-1-shenwei.wang@nxp.com (mailing list archive)
Headers show
Series net: fec: add xdp and page pool statistics | expand

Message

Shenwei Wang Nov. 15, 2022, 8:49 p.m. UTC 
Changes in V5:
 - split the patch into two: one for xdp statistics and one for page
   pool
 - fix the bug to zero xdp_stats array
 - use empty 'page_pool_stats' when CONFIG_PAGE_POOL_STATS is disabled.

Changes in V4:
 - Using u64 to record the XDP statistics
 - Changing strncpy to strscpy
 - Remove the "PAGE_POOL_STATS" select per Alexander's feedback
 - Export the page_pool_stats definition in the page_pool.h

 Changes in v3:
 - change memcpy to strncpy to fix the warning reported by Paolo Abeni
 - fix the compile errors on powerpc

 Changes in v2:
 - clean up and restructure the codes per Andrew Lunn's review comments
 - clear the statistics when the adaptor is down

Shenwei Wang (3):
  net: page_pool: export page_pool_stats definition
  net: fec: add xdp statistics
  net: fec: add page pool statistics

 drivers/net/ethernet/freescale/fec.h      | 15 ++++
 drivers/net/ethernet/freescale/fec_main.c | 96 +++++++++++++++++++++--
 include/net/page_pool.h                   |  2 +
 3 files changed, 107 insertions(+), 6 deletions(-)

--
2.34.1

Comments

Jakub Kicinski Nov. 16, 2022, 4:47 p.m. UTC | #1 
On Tue, 15 Nov 2022 14:49:48 -0600 Shenwei Wang wrote:
> Changes in V5:
>  - split the patch into two: one for xdp statistics and one for page
>    pool
>  - fix the bug to zero xdp_stats array
>  - use empty 'page_pool_stats' when CONFIG_PAGE_POOL_STATS is disabled.

Hi, IIUC there was a previous revision of this set which got applied
too hastily. Unfortunately that means you need to rebase on top of
what's already applied, or add a revert to your series. Otherwise
the patches won't apply cleanly.
Shenwei Wang Nov. 16, 2022, 4:49 p.m. UTC | #2 
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Wednesday, November 16, 2022 10:47 AM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Paolo Abeni <pabeni@redhat.com>; Jesper
> Dangaard Brouer <hawk@kernel.org>; Ilias Apalodimas
> <ilias.apalodimas@linaro.org>; Alexei Starovoitov <ast@kernel.org>; Daniel
> Borkmann <daniel@iogearbox.net>; John Fastabend
> <john.fastabend@gmail.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: [EXT] Re: [PATCH v5 0/3] net: fec: add xdp and page pool statistics
> 
> Caution: EXT Email
> 
> On Tue, 15 Nov 2022 14:49:48 -0600 Shenwei Wang wrote:
> > Changes in V5:
> >  - split the patch into two: one for xdp statistics and one for page
> >    pool
> >  - fix the bug to zero xdp_stats array
> >  - use empty 'page_pool_stats' when CONFIG_PAGE_POOL_STATS is disabled.
> 
> Hi, IIUC there was a previous revision of this set which got applied too hastily.
> Unfortunately that means you need to rebase on top of what's already applied,
> or add a revert to your series. Otherwise the patches won't apply cleanly.

I will do a rebase.

Thanks,
Shenwei