| Message ID | 20221111173348.6537-2-fnkl.kernel@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PWM and keyboard backlight driver for ARM Macs | expand |
On Fri, Nov 11, 2022 at 08:33:45PM +0300, Sasha Finkelstein wrote: > Apple SoCs such as the M1 contain a PWM controller used > among other things to control the keyboard backlight. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > Reviewed-by: Krzyszstof Kozlowski <krzyszstof.kozlowski@linaro.org> I assume you got a bounce on this as you got Krzysztof's name wrong (krzysztof.kozlowski@linaro.org). You should have either resent this or replied pointing out the typo. > Acked-by: Sven Peter <sven@svenpeter.dev> > --- > .../bindings/pwm/apple,s5l-fpwm.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml b/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml > new file mode 100644 > index 000000000000..142157bff0cd > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/apple,s5l-fpwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple FPWM controller > + > +maintainers: > + - asahi@lists.linux.dev > + - Sasha Finkelstein <fnkl.kernel@gmail.com> > + > +description: PWM controller used for keyboard backlight on ARM Macs > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t8103-fpwm > + - apple,t6000-fpwm > + - apple,t8112-fpwm > + - const: apple,s5l-fpwm > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + "#pwm-cells": > + const: 2 > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + pwm@235044000 { > + compatible = "apple,t8103-fpwm", "apple,s5l-fpwm"; > + reg = <0x35044000 0x4000>; > + power-domains = <&ps_fpwm1>; > + clocks = <&clkref>; > + #pwm-cells = <2>; > + }; > -- > 2.38.1 > >
On 16/11/2022 21:20, Rob Herring wrote: > On Fri, Nov 11, 2022 at 08:33:45PM +0300, Sasha Finkelstein wrote: >> Apple SoCs such as the M1 contain a PWM controller used >> among other things to control the keyboard backlight. >> >> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> >> Reviewed-by: Krzyszstof Kozlowski <krzyszstof.kozlowski@linaro.org> > > I assume you got a bounce on this as you got Krzysztof's name wrong > (krzysztof.kozlowski@linaro.org). You should have either resent this or > replied pointing out the typo. Nice... Please do not type my name. It's pretty impossible to get it right, so instead copy-paste the tag entirely without changes and addons. This actually applies to all other tags as well, even with easy-to-type names. Please resend. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml b/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml new file mode 100644 index 000000000000..142157bff0cd --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/apple,s5l-fpwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple FPWM controller + +maintainers: + - asahi@lists.linux.dev + - Sasha Finkelstein <fnkl.kernel@gmail.com> + +description: PWM controller used for keyboard backlight on ARM Macs + +properties: + compatible: + items: + - enum: + - apple,t8103-fpwm + - apple,t6000-fpwm + - apple,t8112-fpwm + - const: apple,s5l-fpwm + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + power-domains: + maxItems: 1 + + "#pwm-cells": + const: 2 + +required: + - compatible + - reg + - clocks + +additionalProperties: false + +examples: + - | + pwm@235044000 { + compatible = "apple,t8103-fpwm", "apple,s5l-fpwm"; + reg = <0x35044000 0x4000>; + power-domains = <&ps_fpwm1>; + clocks = <&clkref>; + #pwm-cells = <2>; + };