| Message ID | 20221111170824.558250-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: libfc: remove redundant variable ev_qual | expand |
Colin, > Variable ev_qual is being assigned and modified but the end result is > never used. The variable is redundant and can be removed. Applied to 6.2/scsi-staging, thanks!
On Fri, 11 Nov 2022 17:08:24 +0000, Colin Ian King wrote: > Variable ev_qual is being assigned and modified but the end result > is never used. The variable is redundant and can be removed. > > Applied to 6.2/scsi-queue, thanks! [1/1] scsi: libfc: remove redundant variable ev_qual https://git.kernel.org/mkp/scsi/c/0824050682ae
diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c index 942fc60f7c21..0f32ded246d0 100644 --- a/drivers/scsi/libfc/fc_disc.c +++ b/drivers/scsi/libfc/fc_disc.c @@ -75,7 +75,6 @@ static void fc_disc_recv_rscn_req(struct fc_disc *disc, struct fc_frame *fp) struct fc_seq_els_data rjt_data; unsigned int len; int redisc = 0; - enum fc_els_rscn_ev_qual ev_qual; enum fc_els_rscn_addr_fmt fmt; LIST_HEAD(disc_ports); struct fc_disc_port *dp, *next; @@ -107,8 +106,6 @@ static void fc_disc_recv_rscn_req(struct fc_disc *disc, struct fc_frame *fp) goto reject; for (pp = (void *)(rp + 1); len > 0; len -= sizeof(*pp), pp++) { - ev_qual = pp->rscn_page_flags >> ELS_RSCN_EV_QUAL_BIT; - ev_qual &= ELS_RSCN_EV_QUAL_MASK; fmt = pp->rscn_page_flags >> ELS_RSCN_ADDR_FMT_BIT; fmt &= ELS_RSCN_ADDR_FMT_MASK; /*
Variable ev_qual is being assigned and modified but the end result is never used. The variable is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/scsi/libfc/fc_disc.c | 3 --- 1 file changed, 3 deletions(-)