| Message ID | 20221117114818.v7.2.I9e018ecb8bdf341648cb64417085978ff0d22a46@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v7,1/3] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer | expand |
On Thu, Nov 17, 2022 at 11:48:47AM -0700, Mark Hasemeyer wrote: > Add DT compatible string in > Documentation/devicetree/bindings/mfd/cros_ec.txt The patch doesn't apply. Please rebase it.
On Fri, 18 Nov 2022, Tzung-Bi Shih wrote: > On Thu, Nov 17, 2022 at 11:48:47AM -0700, Mark Hasemeyer wrote: > > Add DT compatible string in > > Documentation/devicetree/bindings/mfd/cros_ec.txt > > The patch doesn't apply. Please rebase it. Were you actually trying to apply the patch, or just testing?
On Fri, Nov 18, 2022 at 08:59:13AM +0000, Lee Jones wrote: > On Fri, 18 Nov 2022, Tzung-Bi Shih wrote: > > > On Thu, Nov 17, 2022 at 11:48:47AM -0700, Mark Hasemeyer wrote: > > > Add DT compatible string in > > > Documentation/devicetree/bindings/mfd/cros_ec.txt > > > > The patch doesn't apply. Please rebase it. > > Were you actually trying to apply the patch, or just testing? Was trying to apply the patch to my local Linux tree (for-next) for reading the series.
On Thu, Nov 17, 2022 at 10:49 AM Mark Hasemeyer <markhas@chromium.org> wrote: > > Add DT compatible string in > Documentation/devicetree/bindings/mfd/cros_ec.txt > This is now google,cros-ec.yaml Guenter > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org> > Signed-off-by: Mark Hasemeyer <markhas@chromium.org> > --- > > Changes in v7: > - No change > > Changes in v6: > - No change > > Changes in v5: > - No change > > Changes in v4: > - Changes in commit message. > > Changes in v3: > - Rebased changes on google,cros-ec.yaml > > Changes in v2: > - No change > > --- > .../devicetree/bindings/mfd/google,cros-ec.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > index 04962bb29576e..26787e4574b8d 100644 > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -28,6 +28,9 @@ properties: > - description: > For implementations of the EC is connected through RPMSG. > const: google,cros-ec-rpmsg > + - description: > + For implementations of the EC is connected through UART. > + const: google,cros-ec-uart > > controller-data: > description: > @@ -222,4 +225,12 @@ examples: > compatible = "google,cros-ec-rpmsg"; > }; > }; > + > + # Example for UART > + - | > + uart0 { > + cros-ec { > + compatible = "google,cros-ec-uart"; > + }; > + }; > ... > -- > 2.38.1.584.g0f3c55d4c2-goog >
On 18/11/2022 10:19, Tzung-Bi Shih wrote: > On Fri, Nov 18, 2022 at 08:59:13AM +0000, Lee Jones wrote: >> On Fri, 18 Nov 2022, Tzung-Bi Shih wrote: >> >>> On Thu, Nov 17, 2022 at 11:48:47AM -0700, Mark Hasemeyer wrote: >>>> Add DT compatible string in >>>> Documentation/devicetree/bindings/mfd/cros_ec.txt >>> >>> The patch doesn't apply. Please rebase it. >> >> Were you actually trying to apply the patch, or just testing? > > Was trying to apply the patch to my local Linux tree (for-next) for > reading the series. Are you sure then you choose correct base? Because with instructions "please rebase" you actually could encourage to rebase it on incorrect base... Best regards, Krzysztof
On 17/11/2022 19:48, Mark Hasemeyer wrote: > Add DT compatible string in > Documentation/devicetree/bindings/mfd/cros_ec.txt As pointed this is not valid path anymore. Subject: Drop second, redundant "DT" word. With both fixed: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, 18 Nov 2022, Guenter Roeck wrote: > On Thu, Nov 17, 2022 at 10:49 AM Mark Hasemeyer <markhas@chromium.org> wrote: > > > > Add DT compatible string in > > Documentation/devicetree/bindings/mfd/cros_ec.txt > > > > This is now google,cros-ec.yaml Also there is no need to repeat the filename in the commit message. We can see that in the diff-stat below. Please come up with a more imaginative commit message. Exactly what are you doing, why you're doing it will do. > > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org> > > Signed-off-by: Mark Hasemeyer <markhas@chromium.org> > > --- > > > > Changes in v7: > > - No change > > > > Changes in v6: > > - No change > > > > Changes in v5: > > - No change > > > > Changes in v4: > > - Changes in commit message. > > > > Changes in v3: > > - Rebased changes on google,cros-ec.yaml > > > > Changes in v2: > > - No change > > > > --- > > .../devicetree/bindings/mfd/google,cros-ec.yaml | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > index 04962bb29576e..26787e4574b8d 100644 > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > @@ -28,6 +28,9 @@ properties: > > - description: > > For implementations of the EC is connected through RPMSG. > > const: google,cros-ec-rpmsg > > + - description: > > + For implementations of the EC is connected through UART. > > + const: google,cros-ec-uart > > > > controller-data: > > description: > > @@ -222,4 +225,12 @@ examples: > > compatible = "google,cros-ec-rpmsg"; > > }; > > }; > > + > > + # Example for UART > > + - | > > + uart0 { > > + cros-ec { > > + compatible = "google,cros-ec-uart"; > > + }; > > + }; > > ... > >
diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml index 04962bb29576e..26787e4574b8d 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -28,6 +28,9 @@ properties: - description: For implementations of the EC is connected through RPMSG. const: google,cros-ec-rpmsg + - description: + For implementations of the EC is connected through UART. + const: google,cros-ec-uart controller-data: description: @@ -222,4 +225,12 @@ examples: compatible = "google,cros-ec-rpmsg"; }; }; + + # Example for UART + - | + uart0 { + cros-ec { + compatible = "google,cros-ec-uart"; + }; + }; ...