| Message ID | 20221118063240.52164-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b4b221bd79a1c698d9653e3ae2c3cb61cdc9aee7 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [net-next] net: ethernet: renesas: rswitch: Fix signedness bug in rswitch_etha_wait_link_verification() | expand |
Hi Yue, On Fri, Nov 18, 2022 at 7:36 AM YueHaibing <yuehaibing@huawei.com> wrote: > rswitch_reg_wait() may return negative value, which converts to true later. > However rswitch_etha_hw_init() only check it less than zero. > > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Thanks for your patch! A similar patch was already applied as https://git.kernel.org/netdev/net-next/c/b4b221bd79a1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c index f3d27aef1286..c098b27093ea 100644 --- a/drivers/net/ethernet/renesas/rswitch.c +++ b/drivers/net/ethernet/renesas/rswitch.c @@ -920,7 +920,7 @@ static void rswitch_etha_write_mac_address(struct rswitch_etha *etha, const u8 * etha->addr + MRMAC1); } -static bool rswitch_etha_wait_link_verification(struct rswitch_etha *etha) +static int rswitch_etha_wait_link_verification(struct rswitch_etha *etha) { iowrite32(MLVC_PLV, etha->addr + MLVC);
rswitch_reg_wait() may return negative value, which converts to true later. However rswitch_etha_hw_init() only check it less than zero. Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/ethernet/renesas/rswitch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)