| Message ID | 20221116203952.34168-1-bwicaksono@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | perf: arm_cspmu: Fix module cyclic dependency | expand |
On 16/11/2022 20:39, Besar Wicaksono wrote: > Build on arm64 allmodconfig failed with: > | depmod: ERROR: Cycle detected: arm_cspmu -> nvidia_cspmu -> arm_cspmu > | depmod: ERROR: Found 2 modules in dependency cycles! > > The arm_cspmu.c provides standard functions to operate the PMU and the > vendor code provides vendor specific attributes. Both need to be built as > single kernel module. > > Update the makefile to compile sources under arm_cspmu into one module. > > Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com> > --- > drivers/perf/arm_cspmu/Makefile | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/perf/arm_cspmu/Makefile b/drivers/perf/arm_cspmu/Makefile > index 641db85c018b..fedb17df982d 100644 > --- a/drivers/perf/arm_cspmu/Makefile > +++ b/drivers/perf/arm_cspmu/Makefile > @@ -2,6 +2,5 @@ > # > # SPDX-License-Identifier: GPL-2.0 > > -obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += \ > - arm_cspmu.o \ > - nvidia_cspmu.o > +obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += arm_cspmu_module.o > +arm_cspmu_module-y := arm_cspmu.o nvidia_cspmu.o > Reviewed-and-Tested-by: Suzuki K Poulose <suzuki.poulose@arm.com> > base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c
On Wed, 16 Nov 2022 14:39:52 -0600, Besar Wicaksono wrote: > Build on arm64 allmodconfig failed with: > | depmod: ERROR: Cycle detected: arm_cspmu -> nvidia_cspmu -> arm_cspmu > | depmod: ERROR: Found 2 modules in dependency cycles! > > The arm_cspmu.c provides standard functions to operate the PMU and the > vendor code provides vendor specific attributes. Both need to be built as > single kernel module. > > [...] Applied to will (for-next/perf), thanks! [1/1] perf: arm_cspmu: Fix module cyclic dependency https://git.kernel.org/will/c/a91bbd5c9984 Cheers,
diff --git a/drivers/perf/arm_cspmu/Makefile b/drivers/perf/arm_cspmu/Makefile index 641db85c018b..fedb17df982d 100644 --- a/drivers/perf/arm_cspmu/Makefile +++ b/drivers/perf/arm_cspmu/Makefile @@ -2,6 +2,5 @@ # # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += \ - arm_cspmu.o \ - nvidia_cspmu.o +obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += arm_cspmu_module.o +arm_cspmu_module-y := arm_cspmu.o nvidia_cspmu.o
Build on arm64 allmodconfig failed with: | depmod: ERROR: Cycle detected: arm_cspmu -> nvidia_cspmu -> arm_cspmu | depmod: ERROR: Found 2 modules in dependency cycles! The arm_cspmu.c provides standard functions to operate the PMU and the vendor code provides vendor specific attributes. Both need to be built as single kernel module. Update the makefile to compile sources under arm_cspmu into one module. Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com> --- drivers/perf/arm_cspmu/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c