| Message ID | 20221121075358.76582-1-luca.weiss@fairphone.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] dt-bindings: phy: qcom,qmp-usb3-dp: Add sm6350 compatible | expand |
On Mon, Nov 21, 2022 at 08:53:55AM +0100, Luca Weiss wrote: > Add the compatible describing the combo phy found on SM6350. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > index 97a7ecafbf85..68aecb638870 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > @@ -18,6 +18,7 @@ properties: > - qcom,sc8180x-qmp-usb3-dp-phy > - qcom,sc8280xp-qmp-usb43dp-phy > - qcom,sdm845-qmp-usb3-dp-phy > + - qcom,sm6350-qmp-usb3-dp-phy > - qcom,sm8250-qmp-usb3-dp-phy > reg: > items: The current USB3-DP bindings are broken and we should no be adding further compatibles here. Please consider rebasing on: https://lore.kernel.org/all/20221115144005.2478-1-johan+linaro@kernel.org/ Johan
Hi Johan, On Mon Nov 21, 2022 at 9:07 AM CET, Johan Hovold wrote: > On Mon, Nov 21, 2022 at 08:53:55AM +0100, Luca Weiss wrote: > > Add the compatible describing the combo phy found on SM6350. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > index 97a7ecafbf85..68aecb638870 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > @@ -18,6 +18,7 @@ properties: > > - qcom,sc8180x-qmp-usb3-dp-phy > > - qcom,sc8280xp-qmp-usb43dp-phy > > - qcom,sdm845-qmp-usb3-dp-phy > > + - qcom,sm6350-qmp-usb3-dp-phy > > - qcom,sm8250-qmp-usb3-dp-phy > > reg: > > items: > > The current USB3-DP bindings are broken and we should no be adding > further compatibles here. Please consider rebasing on: > > https://lore.kernel.org/all/20221115144005.2478-1-johan+linaro@kernel.org/ I'm not quite clear what you want me to do. Just rebase this change on top of your patchset and resend or something else? Regards Luca > > Johan
On Tue, Nov 22, 2022 at 08:55:31AM +0100, Luca Weiss wrote: > Hi Johan, > > On Mon Nov 21, 2022 at 9:07 AM CET, Johan Hovold wrote: > > On Mon, Nov 21, 2022 at 08:53:55AM +0100, Luca Weiss wrote: > > > Add the compatible describing the combo phy found on SM6350. > > > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > > --- > > > Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > > index 97a7ecafbf85..68aecb638870 100644 > > > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > > @@ -18,6 +18,7 @@ properties: > > > - qcom,sc8180x-qmp-usb3-dp-phy > > > - qcom,sc8280xp-qmp-usb43dp-phy > > > - qcom,sdm845-qmp-usb3-dp-phy > > > + - qcom,sm6350-qmp-usb3-dp-phy > > > - qcom,sm8250-qmp-usb3-dp-phy > > > reg: > > > items: > > > > The current USB3-DP bindings are broken and we should no be adding > > further compatibles here. Please consider rebasing on: > > > > https://lore.kernel.org/all/20221115144005.2478-1-johan+linaro@kernel.org/ > > I'm not quite clear what you want me to do. Just rebase this change on > top of your patchset and resend or something else? Yes, you should rebase this series on top of the above, add qcom,sm6350-qmp-usb3-dp-phy to the new (sc8280xp) schema, add a register offset table for QMP v3 to the PHY driver, and update the dts. Note that the USB/DP configuration structures have been merged (and some config fields have already been removed in linux-next). Johan
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml index 97a7ecafbf85..68aecb638870 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml @@ -18,6 +18,7 @@ properties: - qcom,sc8180x-qmp-usb3-dp-phy - qcom,sc8280xp-qmp-usb43dp-phy - qcom,sdm845-qmp-usb3-dp-phy + - qcom,sm6350-qmp-usb3-dp-phy - qcom,sm8250-qmp-usb3-dp-phy reg: items:
Add the compatible describing the combo phy found on SM6350. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 1 + 1 file changed, 1 insertion(+)