| Message ID | 20221121094138.21028-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1cb50726329070a6e3235b6bac38dfb8d5fd18c2 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ethernet: renesas: Add missing slash in rswitch_init | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 8 of 8 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
Hi, > From: YueHaibing, Sent: Monday, November 21, 2022 6:42 PM > > Fix smatch warning: > > drivers/net/ethernet/renesas/rswitch.c:1717 > rswitch_init() warn: '%pM' cannot be followed by 'n' Thank you for the patch! However, I have submitted such a patch as following: https://lore.kernel.org/all/20221118002724.996108-1-yoshihiro.shimoda.uh@renesas.com/ Best regards, Yoshihiro Shimoda
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Mon, 21 Nov 2022 17:41:38 +0800 you wrote: > Fix smatch warning: > > drivers/net/ethernet/renesas/rswitch.c:1717 > rswitch_init() warn: '%pM' cannot be followed by 'n' > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > [...] Here is the summary with links: - [net-next] net: ethernet: renesas: Add missing slash in rswitch_init https://git.kernel.org/netdev/net-next/c/1cb507263290 You are awesome, thank you!
diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c index c098b27093ea..e42ceaa0099f 100644 --- a/drivers/net/ethernet/renesas/rswitch.c +++ b/drivers/net/ethernet/renesas/rswitch.c @@ -1714,7 +1714,7 @@ static int rswitch_init(struct rswitch_private *priv) } for (i = 0; i < RSWITCH_NUM_PORTS; i++) - netdev_info(priv->rdev[i]->ndev, "MAC address %pMn", + netdev_info(priv->rdev[i]->ndev, "MAC address %pM\n", priv->rdev[i]->ndev->dev_addr); return 0;
Fix smatch warning: drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn: '%pM' cannot be followed by 'n' Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/ethernet/renesas/rswitch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)