| Message ID | 20221119204435.97113-1-ogabbay@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | new subsystem for compute accelerator devices | expand |
On Sat, Nov 19, 2022 at 10:44:31PM +0200, Oded Gabbay wrote: > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one additional patch that adds > documentation regarding the accel subsystem. I hope it's good enough for > this stage. In addition, there were few very minor fixes according to > comments received on v3. > > The patches are in the following repo: > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > registers an accel device using the new framework. This can be served > as a simple reference. Looks good, thanks for doing this: Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On 11/19/2022 1:44 PM, Oded Gabbay wrote: > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one additional patch that adds > documentation regarding the accel subsystem. I hope it's good enough for > this stage. In addition, there were few very minor fixes according to > comments received on v3. > > The patches are in the following repo: > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > registers an accel device using the new framework. This can be served > as a simple reference. > > v1 cover letter: > https://lkml.org/lkml/2022/10/22/544 > > v2 cover letter: > https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/ > > v3 cover letter: > https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/ > > Thanks, > Oded. Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com> I have some nits. Nothing that I think should be a blocker for this series.
On Sun, 20 Nov 2022 at 06:44, Oded Gabbay <ogabbay@kernel.org> wrote: > > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one additional patch that adds > documentation regarding the accel subsystem. I hope it's good enough for > this stage. In addition, there were few very minor fixes according to > comments received on v3. > > The patches are in the following repo: > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > registers an accel device using the new framework. This can be served > as a simple reference. > FIx the nits Jeffery raised and the one I brought up and I think we should be good for this to be in a PR. Reviewed-by: Dave Airlie <airlied@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Am 19.11.22 um 21:44 schrieb Oded Gabbay: > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one additional patch that adds > documentation regarding the accel subsystem. I hope it's good enough for > this stage. In addition, there were few very minor fixes according to > comments received on v3. > > The patches are in the following repo: > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > registers an accel device using the new framework. This can be served > as a simple reference. > > v1 cover letter: > https://lkml.org/lkml/2022/10/22/544 > > v2 cover letter: > https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/ > > v3 cover letter: > https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/ > > Thanks, > Oded. > > Oded Gabbay (4): > drivers/accel: define kconfig and register a new major > accel: add dedicated minor for accelerator devices > drm: initialize accel framework > doc: add documentation for accel subsystem > > Documentation/accel/index.rst | 17 ++ > Documentation/accel/introduction.rst | 109 +++++++++ > Documentation/admin-guide/devices.txt | 5 + > Documentation/subsystem-apis.rst | 1 + > MAINTAINERS | 9 + > drivers/Kconfig | 2 + > drivers/accel/Kconfig | 24 ++ > drivers/accel/drm_accel.c | 323 ++++++++++++++++++++++++++ > drivers/gpu/drm/Makefile | 1 + > drivers/gpu/drm/drm_drv.c | 102 +++++--- > drivers/gpu/drm/drm_file.c | 2 +- > drivers/gpu/drm/drm_sysfs.c | 24 +- > include/drm/drm_accel.h | 97 ++++++++ > include/drm/drm_device.h | 3 + > include/drm/drm_drv.h | 8 + > include/drm/drm_file.h | 21 +- > 16 files changed, 711 insertions(+), 37 deletions(-) > create mode 100644 Documentation/accel/index.rst > create mode 100644 Documentation/accel/introduction.rst > create mode 100644 drivers/accel/Kconfig > create mode 100644 drivers/accel/drm_accel.c > create mode 100644 include/drm/drm_accel.h > > -- > 2.25.1 >
On Mon, Nov 21, 2022 at 8:26 AM Dave Airlie <airlied@gmail.com> wrote: > > On Sun, 20 Nov 2022 at 06:44, Oded Gabbay <ogabbay@kernel.org> wrote: > > > > This is the fourth (and hopefully last) version of the patch-set to add the > > new subsystem for compute accelerators. I removed the RFC headline as > > I believe it is now ready for merging. > > > > Compare to v3, this patch-set contains one additional patch that adds > > documentation regarding the accel subsystem. I hope it's good enough for > > this stage. In addition, there were few very minor fixes according to > > comments received on v3. > > > > The patches are in the following repo: > > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > > registers an accel device using the new framework. This can be served > > as a simple reference. > > > > FIx the nits Jeffery raised and the one I brought up and I think we > should be good for this to be in a PR. > > Reviewed-by: Dave Airlie <airlied@redhat.com> Sure, np. Oded
On Sat, Nov 19, 2022 at 3:44 PM Oded Gabbay <ogabbay@kernel.org> wrote: > > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one additional patch that adds > documentation regarding the accel subsystem. I hope it's good enough for > this stage. In addition, there were few very minor fixes according to > comments received on v3. > > The patches are in the following repo: > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > registers an accel device using the new framework. This can be served > as a simple reference. > > v1 cover letter: > https://lkml.org/lkml/2022/10/22/544 > > v2 cover letter: > https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/ > > v3 cover letter: > https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/ > With the understanding that individual drivers can choose to use either classic drm or accel, whichever makes the most sense to them, this series is: Acked-by: Alex Deucher <alexander.deucer@amd.com> > Thanks, > Oded. > > Oded Gabbay (4): > drivers/accel: define kconfig and register a new major > accel: add dedicated minor for accelerator devices > drm: initialize accel framework > doc: add documentation for accel subsystem > > Documentation/accel/index.rst | 17 ++ > Documentation/accel/introduction.rst | 109 +++++++++ > Documentation/admin-guide/devices.txt | 5 + > Documentation/subsystem-apis.rst | 1 + > MAINTAINERS | 9 + > drivers/Kconfig | 2 + > drivers/accel/Kconfig | 24 ++ > drivers/accel/drm_accel.c | 323 ++++++++++++++++++++++++++ > drivers/gpu/drm/Makefile | 1 + > drivers/gpu/drm/drm_drv.c | 102 +++++--- > drivers/gpu/drm/drm_file.c | 2 +- > drivers/gpu/drm/drm_sysfs.c | 24 +- > include/drm/drm_accel.h | 97 ++++++++ > include/drm/drm_device.h | 3 + > include/drm/drm_drv.h | 8 + > include/drm/drm_file.h | 21 +- > 16 files changed, 711 insertions(+), 37 deletions(-) > create mode 100644 Documentation/accel/index.rst > create mode 100644 Documentation/accel/introduction.rst > create mode 100644 drivers/accel/Kconfig > create mode 100644 drivers/accel/drm_accel.c > create mode 100644 include/drm/drm_accel.h > > -- > 2.25.1 >
On Mon, Nov 21, 2022 at 10:57 AM Alex Deucher <alexdeucher@gmail.com> wrote: > > On Sat, Nov 19, 2022 at 3:44 PM Oded Gabbay <ogabbay@kernel.org> wrote: > > > > This is the fourth (and hopefully last) version of the patch-set to add the > > new subsystem for compute accelerators. I removed the RFC headline as > > I believe it is now ready for merging. > > > > Compare to v3, this patch-set contains one additional patch that adds > > documentation regarding the accel subsystem. I hope it's good enough for > > this stage. In addition, there were few very minor fixes according to > > comments received on v3. > > > > The patches are in the following repo: > > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > > registers an accel device using the new framework. This can be served > > as a simple reference. > > > > v1 cover letter: > > https://lkml.org/lkml/2022/10/22/544 > > > > v2 cover letter: > > https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/ > > > > v3 cover letter: > > https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/ > > > > With the understanding that individual drivers can choose to use > either classic drm or accel, whichever makes the most sense to them, > this series is: > Acked-by: Alex Deucher <alexander.deucer@amd.com> and not typo my email: Acked-by: Alex Deucher <alexander.deucher@amd.com> > > > Thanks, > > Oded. > > > > Oded Gabbay (4): > > drivers/accel: define kconfig and register a new major > > accel: add dedicated minor for accelerator devices > > drm: initialize accel framework > > doc: add documentation for accel subsystem > > > > Documentation/accel/index.rst | 17 ++ > > Documentation/accel/introduction.rst | 109 +++++++++ > > Documentation/admin-guide/devices.txt | 5 + > > Documentation/subsystem-apis.rst | 1 + > > MAINTAINERS | 9 + > > drivers/Kconfig | 2 + > > drivers/accel/Kconfig | 24 ++ > > drivers/accel/drm_accel.c | 323 ++++++++++++++++++++++++++ > > drivers/gpu/drm/Makefile | 1 + > > drivers/gpu/drm/drm_drv.c | 102 +++++--- > > drivers/gpu/drm/drm_file.c | 2 +- > > drivers/gpu/drm/drm_sysfs.c | 24 +- > > include/drm/drm_accel.h | 97 ++++++++ > > include/drm/drm_device.h | 3 + > > include/drm/drm_drv.h | 8 + > > include/drm/drm_file.h | 21 +- > > 16 files changed, 711 insertions(+), 37 deletions(-) > > create mode 100644 Documentation/accel/index.rst > > create mode 100644 Documentation/accel/introduction.rst > > create mode 100644 drivers/accel/Kconfig > > create mode 100644 drivers/accel/drm_accel.c > > create mode 100644 include/drm/drm_accel.h > > > > -- > > 2.25.1 > >
On 11/19/22 12:44, Oded Gabbay wrote: > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one additional patch that adds > documentation regarding the accel subsystem. I hope it's good enough for > this stage. In addition, there were few very minor fixes according to > comments received on v3. > > The patches are in the following repo: > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > registers an accel device using the new framework. This can be served > as a simple reference. > > v1 cover letter: > https://lkml.org/lkml/2022/10/22/544 > > v2 cover letter: > https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/ > > v3 cover letter: > https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/ Thanks for defining the new accel subsystem. We are currently working on DRM based drivers for unannounced acceleration devices. I am fine with these changes with the assumption that the choice of using classic DRM or accel is left up to the individual driver. -Sonal > > Thanks, > Oded. > > Oded Gabbay (4): > drivers/accel: define kconfig and register a new major > accel: add dedicated minor for accelerator devices > drm: initialize accel framework > doc: add documentation for accel subsystem > > Documentation/accel/index.rst | 17 ++ > Documentation/accel/introduction.rst | 109 +++++++++ > Documentation/admin-guide/devices.txt | 5 + > Documentation/subsystem-apis.rst | 1 + > MAINTAINERS | 9 + > drivers/Kconfig | 2 + > drivers/accel/Kconfig | 24 ++ > drivers/accel/drm_accel.c | 323 ++++++++++++++++++++++++++ > drivers/gpu/drm/Makefile | 1 + > drivers/gpu/drm/drm_drv.c | 102 +++++--- > drivers/gpu/drm/drm_file.c | 2 +- > drivers/gpu/drm/drm_sysfs.c | 24 +- > include/drm/drm_accel.h | 97 ++++++++ > include/drm/drm_device.h | 3 + > include/drm/drm_drv.h | 8 + > include/drm/drm_file.h | 21 +- > 16 files changed, 711 insertions(+), 37 deletions(-) > create mode 100644 Documentation/accel/index.rst > create mode 100644 Documentation/accel/introduction.rst > create mode 100644 drivers/accel/Kconfig > create mode 100644 drivers/accel/drm_accel.c > create mode 100644 include/drm/drm_accel.h > > -- > 2.25.1 >
On Tue, 22 Nov 2022 at 09:06, Sonal Santan <sonal.santan@amd.com> wrote: > > On 11/19/22 12:44, Oded Gabbay wrote: > > This is the fourth (and hopefully last) version of the patch-set to add the > > new subsystem for compute accelerators. I removed the RFC headline as > > I believe it is now ready for merging. > > > > Compare to v3, this patch-set contains one additional patch that adds > > documentation regarding the accel subsystem. I hope it's good enough for > > this stage. In addition, there were few very minor fixes according to > > comments received on v3. > > > > The patches are in the following repo: > > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > > registers an accel device using the new framework. This can be served > > as a simple reference. > > > > v1 cover letter: > > https://lkml.org/lkml/2022/10/22/544 > > > > v2 cover letter: > > https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/ > > > > v3 cover letter: > > https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/ > > Thanks for defining the new accel subsystem. We are currently working on > DRM based drivers for unannounced acceleration devices. I am fine with > these changes with the assumption that the choice of using classic DRM > or accel is left up to the individual driver. I don't think that decision should be up to any individual driver author. It will have to be consensus with me/Daniel/Oded and the driver authors. Dave.
Hi, On 11/19/2022 9:44 PM, Oded Gabbay wrote: > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. Looks good and works without issues. I will rebase next version of Intel VPU patchest on top of this. Acked-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> Tested-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> Regards, Jacek
On Tue, Nov 22, 2022 at 03:46:25PM +1000, Dave Airlie wrote: > On Tue, 22 Nov 2022 at 09:06, Sonal Santan <sonal.santan@amd.com> wrote: > > > > On 11/19/22 12:44, Oded Gabbay wrote: > > > This is the fourth (and hopefully last) version of the patch-set to add the > > > new subsystem for compute accelerators. I removed the RFC headline as > > > I believe it is now ready for merging. > > > > > > Compare to v3, this patch-set contains one additional patch that adds > > > documentation regarding the accel subsystem. I hope it's good enough for > > > this stage. In addition, there were few very minor fixes according to > > > comments received on v3. > > > > > > The patches are in the following repo: > > > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > > > > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > > > registers an accel device using the new framework. This can be served > > > as a simple reference. > > > > > > v1 cover letter: > > > https://lkml.org/lkml/2022/10/22/544 > > > > > > v2 cover letter: > > > https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/ > > > > > > v3 cover letter: > > > https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/ > > > > Thanks for defining the new accel subsystem. We are currently working on > > DRM based drivers for unannounced acceleration devices. I am fine with > > these changes with the assumption that the choice of using classic DRM > > or accel is left up to the individual driver. > > I don't think that decision should be up to any individual driver > author. It will have to be consensus with me/Daniel/Oded and the > driver authors. Plus the entire point of this is that it's _still_ a drm based driver. So aside from changing a flag in the kernel driver and adjusting userspace to find the right chardev, there should be zero changes need for an existing drm based driver stack that gets ported to drivers/accel. And of course if we realize there's issues as we add drivers, we can fix things up. This is just to kick things off, not something that's going to be cast in stone for all eternity. Sonal, with that clarification/explanation, is this entire thing reasonable in principal and you can drop an Ack onto the series? Thanks, Daniel
On 11/20/2022 3:04 PM, Jeffrey Hugo wrote: > On 11/19/2022 1:44 PM, Oded Gabbay wrote: >> This is the fourth (and hopefully last) version of the patch-set to >> add the >> new subsystem for compute accelerators. I removed the RFC headline as >> I believe it is now ready for merging. >> >> Compare to v3, this patch-set contains one additional patch that adds >> documentation regarding the accel subsystem. I hope it's good enough for >> this stage. In addition, there were few very minor fixes according to >> comments received on v3. >> >> The patches are in the following repo: >> https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 >> >> >> As in v3, The HEAD of that branch is a commit adding a dummy driver that >> registers an accel device using the new framework. This can be served >> as a simple reference. >> >> v1 cover letter: >> https://lkml.org/lkml/2022/10/22/544 >> >> v2 cover letter: >> https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/ >> >> >> v3 cover letter: >> https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/ >> >> >> Thanks, >> Oded. > > Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com> > > I have some nits. Nothing that I think should be a blocker for this > series. I don't recall if I previously mentioned this. I'm planning on updating the QAIC series to be an accel driver. Therefore there should be at-least 1 user (probably several) for this subsystem in short order.
Hi, On Sat, Nov 19, 2022 at 10:44:31PM +0200, Oded Gabbay wrote: > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one additional patch that adds > documentation regarding the accel subsystem. I hope it's good enough for > this stage. In addition, there were few very minor fixes according to > comments received on v3. > > The patches are in the following repo: > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 Acked-by: Maxime Ripard <maxime@cerno.tech> Maxime
On 11/22/22 06:54, Daniel Vetter wrote: > On Tue, Nov 22, 2022 at 03:46:25PM +1000, Dave Airlie wrote: >> On Tue, 22 Nov 2022 at 09:06, Sonal Santan <sonal.santan@amd.com> wrote: >>> >>> On 11/19/22 12:44, Oded Gabbay wrote: >>>> This is the fourth (and hopefully last) version of the patch-set to add the >>>> new subsystem for compute accelerators. I removed the RFC headline as >>>> I believe it is now ready for merging. >>>> >>>> Compare to v3, this patch-set contains one additional patch that adds >>>> documentation regarding the accel subsystem. I hope it's good enough for >>>> this stage. In addition, there were few very minor fixes according to >>>> comments received on v3. >>>> >>>> The patches are in the following repo: >>>> https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 >>>> >>>> As in v3, The HEAD of that branch is a commit adding a dummy driver that >>>> registers an accel device using the new framework. This can be served >>>> as a simple reference. >>>> >>>> v1 cover letter: >>>> https://lkml.org/lkml/2022/10/22/544 >>>> >>>> v2 cover letter: >>>> https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/ >>>> >>>> v3 cover letter: >>>> https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/ >>> >>> Thanks for defining the new accel subsystem. We are currently working on >>> DRM based drivers for unannounced acceleration devices. I am fine with >>> these changes with the assumption that the choice of using classic DRM >>> or accel is left up to the individual driver. >> >> I don't think that decision should be up to any individual driver >> author. It will have to be consensus with me/Daniel/Oded and the >> driver authors. > > Plus the entire point of this is that it's _still_ a drm based driver. So > aside from changing a flag in the kernel driver and adjusting userspace to > find the right chardev, there should be zero changes need for an existing > drm based driver stack that gets ported to drivers/accel. > > And of course if we realize there's issues as we add drivers, we can fix > things up. This is just to kick things off, not something that's going to > be cast in stone for all eternity. > > Sonal, with that clarification/explanation, is this entire thing > reasonable in principal and you can drop an Ack onto the series? > > Thanks, Daniel Sounds good. The accel patch series is: Acked-by: Sonal Santan <sonal.santan@amd.com> -Sonal
Hi Oded, On Sat, 19 Nov 2022 at 20:44, Oded Gabbay <ogabbay@kernel.org> wrote: > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one additional patch that adds > documentation regarding the accel subsystem. I hope it's good enough for > this stage. In addition, there were few very minor fixes according to > comments received on v3. > > The patches are in the following repo: > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 Series is: Acked-by: Daniel Stone <daniels@collabora.com> Cheers, Daniel