| Message ID | 1664549663-20364-1-git-send-email-jun.li@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4,1/3] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock | expand |
On 22-09-30 22:54:21, Li Jun wrote: > usb suspend clock has a gate shared with usb_root_clk. > > Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver") > Cc: stable@vger.kernel.org # v5.19+ > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> > Signed-off-by: Li Jun <jun.li@nxp.com> Applied all. Thanks. > --- > include/dt-bindings/clock/imx8mp-clock.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h > index 9d5cc2ddde89..1417b7b1b7df 100644 > --- a/include/dt-bindings/clock/imx8mp-clock.h > +++ b/include/dt-bindings/clock/imx8mp-clock.h > @@ -324,8 +324,9 @@ > #define IMX8MP_CLK_CLKOUT2_SEL 317 > #define IMX8MP_CLK_CLKOUT2_DIV 318 > #define IMX8MP_CLK_CLKOUT2 319 > +#define IMX8MP_CLK_USB_SUSP 320 > > -#define IMX8MP_CLK_END 320 > +#define IMX8MP_CLK_END 321 > > #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0 > #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1 > -- > 2.34.1 >
> -----Original Message----- > From: Abel Vesa <abel.vesa@linaro.org> > Sent: Monday, November 21, 2022 11:57 PM > To: Jun Li <jun.li@nxp.com> > Cc: sboyd@kernel.org; abelvesa@kernel.org; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > dl-linux-imx <linux-imx@nxp.com>; mturquette@baylibre.com; > l.stach@pengutronix.de; Peng Fan <peng.fan@nxp.com>; > alexander.stein@ew.tq-group.com; gregkh@linuxfoundation.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-clk@vger.kernel.org > Subject: Re: [PATCH v4 1/3] dt-bindings: clocks: imx8mp: Add ID for usb > suspend clock > > On 22-09-30 22:54:21, Li Jun wrote: > > usb suspend clock has a gate shared with usb_root_clk. > > > > Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver") > > Cc: stable@vger.kernel.org # v5.19+ > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > Signed-off-by: Li Jun <jun.li@nxp.com> > > Applied all. Thanks. Hi Abel, Could you please also take the dts patch[1] in this series? As the dts patch has a build dependency on the clk patches, So Shawn suggested you take the dts patch too [2]. [1] https://www.spinics.net/lists/linux-clk/msg75904.html [2] https://www.spinics.net/lists/arm-kernel/msg1013220.html Thanks Li Jun > > > --- > > include/dt-bindings/clock/imx8mp-clock.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/dt-bindings/clock/imx8mp-clock.h > b/include/dt-bindings/clock/imx8mp-clock.h > > index 9d5cc2ddde89..1417b7b1b7df 100644 > > --- a/include/dt-bindings/clock/imx8mp-clock.h > > +++ b/include/dt-bindings/clock/imx8mp-clock.h > > @@ -324,8 +324,9 @@ > > #define IMX8MP_CLK_CLKOUT2_SEL 317 > > #define IMX8MP_CLK_CLKOUT2_DIV 318 > > #define IMX8MP_CLK_CLKOUT2 319 > > +#define IMX8MP_CLK_USB_SUSP 320 > > > > -#define IMX8MP_CLK_END 320 > > +#define IMX8MP_CLK_END 321 > > > > #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0 > > #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1 > > -- > > 2.34.1 > >
On 25/11/2022 11:55, Jun Li wrote: > > >> -----Original Message----- >> From: Abel Vesa <abel.vesa@linaro.org> >> Sent: Monday, November 21, 2022 11:57 PM >> To: Jun Li <jun.li@nxp.com> >> Cc: sboyd@kernel.org; abelvesa@kernel.org; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; >> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; >> dl-linux-imx <linux-imx@nxp.com>; mturquette@baylibre.com; >> l.stach@pengutronix.de; Peng Fan <peng.fan@nxp.com>; >> alexander.stein@ew.tq-group.com; gregkh@linuxfoundation.org; >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> linux-clk@vger.kernel.org >> Subject: Re: [PATCH v4 1/3] dt-bindings: clocks: imx8mp: Add ID for usb >> suspend clock >> >> On 22-09-30 22:54:21, Li Jun wrote: >>> usb suspend clock has a gate shared with usb_root_clk. >>> >>> Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver") >>> Cc: stable@vger.kernel.org # v5.19+ >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> >>> Signed-off-by: Li Jun <jun.li@nxp.com> >> >> Applied all. Thanks. > > Hi Abel, > > Could you please also take the dts patch[1] in this series? > As the dts patch has a build dependency on the clk patches, > So Shawn suggested you take the dts patch too [2]. > > [1] https://www.spinics.net/lists/linux-clk/msg75904.html > [2] https://www.spinics.net/lists/arm-kernel/msg1013220.html DTS cannot go via driver tree. Share the header from DTS tree to driver to solve it... or add defines to your DTS. Best regards, Krzysztof
On 22-09-30 22:54:21, Li Jun wrote: > usb suspend clock has a gate shared with usb_root_clk. > > Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver") > Cc: stable@vger.kernel.org # v5.19+ > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> > Signed-off-by: Li Jun <jun.li@nxp.com> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > --- > include/dt-bindings/clock/imx8mp-clock.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h > index 9d5cc2ddde89..1417b7b1b7df 100644 > --- a/include/dt-bindings/clock/imx8mp-clock.h > +++ b/include/dt-bindings/clock/imx8mp-clock.h > @@ -324,8 +324,9 @@ > #define IMX8MP_CLK_CLKOUT2_SEL 317 > #define IMX8MP_CLK_CLKOUT2_DIV 318 > #define IMX8MP_CLK_CLKOUT2 319 > +#define IMX8MP_CLK_USB_SUSP 320 > > -#define IMX8MP_CLK_END 320 > +#define IMX8MP_CLK_END 321 > > #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0 > #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1 > -- > 2.34.1 >
diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h index 9d5cc2ddde89..1417b7b1b7df 100644 --- a/include/dt-bindings/clock/imx8mp-clock.h +++ b/include/dt-bindings/clock/imx8mp-clock.h @@ -324,8 +324,9 @@ #define IMX8MP_CLK_CLKOUT2_SEL 317 #define IMX8MP_CLK_CLKOUT2_DIV 318 #define IMX8MP_CLK_CLKOUT2 319 +#define IMX8MP_CLK_USB_SUSP 320 -#define IMX8MP_CLK_END 320 +#define IMX8MP_CLK_END 321 #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0 #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1
usb suspend clock has a gate shared with usb_root_clk. Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver") Cc: stable@vger.kernel.org # v5.19+ Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> Signed-off-by: Li Jun <jun.li@nxp.com> --- include/dt-bindings/clock/imx8mp-clock.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)