| Message ID | 20221121201337.2772216-2-pmalani@chromium.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | platform/chrome: cros_ec_typec: Link PD object to partner | expand |
Hi Prashant, On Mon, Nov 21, 2022 at 08:13:35PM +0000, Prashant Malani wrote: > +/** > + * typec_partner_to_dev - Get the device struct of a USB Type-C partner. > + * @partner: USB Type-C Partner > + * > + * Returns a pointer to the device struct or NULL. > + */ > +struct device *typec_partner_to_dev(struct typec_partner *partner) > +{ > + return partner ? &partner->dev : NULL; > +} > +EXPORT_SYMBOL_GPL(typec_partner_to_dev); Let's not loose the protection around these devices unless there is no other way, and in this case there is. Please just create a wrapper for usb_power_delivery_register() instead: struct usb_power_delivery * typec_partner_usb_power_delivery_register(struct typec_partner *partner, struct usb_power_delivery_desc *desc) { return usb_power_delivery_register(&partner->dev, desc); } EXPORT_SYMBOL_GPL(typec_partner_usb_power_delivery_register); thanks,
Hi Heikki, Thanks for reviewing the patch. On Tue, Nov 22, 2022 at 1:58 AM Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote: > > Let's not loose the protection around these devices unless there is no > other way, and in this case there is. > > Please just create a wrapper for usb_power_delivery_register() instead: > > struct usb_power_delivery * > typec_partner_usb_power_delivery_register(struct typec_partner *partner, > struct usb_power_delivery_desc *desc) > { > return usb_power_delivery_register(&partner->dev, desc); > } > EXPORT_SYMBOL_GPL(typec_partner_usb_power_delivery_register); Sounds good. I'll send a v2 with the above change as patch 1 (instead of the current patch 1). I will list you as the "Suggested-by" tag (but please let me know if you'd like attribution stated differently). Thanks again! -Prashant
On Tue, Nov 22, 2022 at 11:05:04AM -0800, Prashant Malani wrote: > Hi Heikki, > > Thanks for reviewing the patch. > > On Tue, Nov 22, 2022 at 1:58 AM Heikki Krogerus > <heikki.krogerus@linux.intel.com> wrote: > > > > Let's not loose the protection around these devices unless there is no > > other way, and in this case there is. > > > > Please just create a wrapper for usb_power_delivery_register() instead: > > > > struct usb_power_delivery * > > typec_partner_usb_power_delivery_register(struct typec_partner *partner, > > struct usb_power_delivery_desc *desc) > > { > > return usb_power_delivery_register(&partner->dev, desc); > > } > > EXPORT_SYMBOL_GPL(typec_partner_usb_power_delivery_register); > > Sounds good. I'll send a v2 with the above change as patch 1 (instead > of the current patch 1). > > I will list you as the "Suggested-by" tag (but please let me know if > you'd like attribution stated differently). Thanks. Suggested-by is the correct tag IMO. cheers,
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index bd5e5dd70431..154c70630432 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -821,6 +821,19 @@ void typec_partner_set_svdm_version(struct typec_partner *partner, } EXPORT_SYMBOL_GPL(typec_partner_set_svdm_version); + +/** + * typec_partner_to_dev - Get the device struct of a USB Type-C partner. + * @partner: USB Type-C Partner + * + * Returns a pointer to the device struct or NULL. + */ +struct device *typec_partner_to_dev(struct typec_partner *partner) +{ + return partner ? &partner->dev : NULL; +} +EXPORT_SYMBOL_GPL(typec_partner_to_dev); + /** * typec_register_partner - Register a USB Type-C Partner * @port: The USB Type-C Port the partner is connected to diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h index 7751bedcae5d..085be3e94ff8 100644 --- a/include/linux/usb/typec.h +++ b/include/linux/usb/typec.h @@ -327,6 +327,8 @@ void typec_partner_set_svdm_version(struct typec_partner *partner, enum usb_pd_svdm_ver svdm_version); int typec_get_negotiated_svdm_version(struct typec_port *port); +struct device *typec_partner_to_dev(struct typec_partner *partner); + int typec_port_set_usb_power_delivery(struct typec_port *port, struct usb_power_delivery *pd); int typec_partner_set_usb_power_delivery(struct typec_partner *partner, struct usb_power_delivery *pd);
Some port drivers may want to set a Type-C partner as a parent for a USB Power Delivery object, but the Type-C partner struct isn't exposed outside of the Type-C class driver. Add a helper which returns a pointer to the Type-C partner's device struct, so that it can be supplied as the parent to the PD object. Cc: Benson Leung <bleung@chromium.org> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by: Prashant Malani <pmalani@chromium.org> --- drivers/usb/typec/class.c | 13 +++++++++++++ include/linux/usb/typec.h | 2 ++ 2 files changed, 15 insertions(+)