| Message ID | 20221115150335.501502-2-mranostay@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PCI: add 4x lane support for pci-j721e controllers | expand |
On 15/11/2022 16:03, Matt Ranostay wrote: > Add num-lanes schema checks based on compatible string on available > lanes for that platform. > > Signed-off-by: Matt Ranostay <mranostay@ti.com> > --- > .../bindings/pci/ti,j721e-pci-ep.yaml | 28 +++++++++++++++++-- > .../bindings/pci/ti,j721e-pci-host.yaml | 28 +++++++++++++++++-- > 2 files changed, 50 insertions(+), 6 deletions(-) Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You miss not only people but also lists, meaning this will not be automatically tested. So: NAK Best regards, Krzysztof
On Wed, Nov 23, 2022 at 05:04:15PM +0100, Krzysztof Kozlowski wrote: > On 15/11/2022 16:03, Matt Ranostay wrote: > > Add num-lanes schema checks based on compatible string on available > > lanes for that platform. > > > > Signed-off-by: Matt Ranostay <mranostay@ti.com> > > --- > > .../bindings/pci/ti,j721e-pci-ep.yaml | 28 +++++++++++++++++-- > > .../bindings/pci/ti,j721e-pci-host.yaml | 28 +++++++++++++++++-- > > 2 files changed, 50 insertions(+), 6 deletions(-) > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You miss not only people but also lists, meaning this will not be > automatically tested. > Noted. Reran script with --git as well and it picked up a few additional people to Cc. Will resend with commit message wordwrapping fixes - Matt > So: NAK > > Best regards, > Krzysztof >
On 24/11/2022 08:58, Matt Ranostay wrote: > On Wed, Nov 23, 2022 at 05:04:15PM +0100, Krzysztof Kozlowski wrote: >> On 15/11/2022 16:03, Matt Ranostay wrote: >>> Add num-lanes schema checks based on compatible string on available >>> lanes for that platform. >>> >>> Signed-off-by: Matt Ranostay <mranostay@ti.com> >>> --- >>> .../bindings/pci/ti,j721e-pci-ep.yaml | 28 +++++++++++++++++-- >>> .../bindings/pci/ti,j721e-pci-host.yaml | 28 +++++++++++++++++-- >>> 2 files changed, 50 insertions(+), 6 deletions(-) >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >> You miss not only people but also lists, meaning this will not be >> automatically tested. >> > > Noted. Reran script with --git as well and it picked up a few additional people > to Cc. No need for --git. Just run it normally and Cc all folks listed as reviewer, maintainer/supporter and all the lists. That's one simple command: scripts/get_maintainer.pl ./*.patch (which can be easily automated and combined with git send-email / bash aliases or scripts). So don't add some unusual or random addresses, just add the *required* addresses. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml index 10e6eabdff53..1aeea168d3d0 100644 --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml @@ -10,9 +10,6 @@ title: TI J721E PCI EP (PCIe Wrapper) maintainers: - Kishon Vijay Abraham I <kishon@ti.com> -allOf: - - $ref: "cdns-pcie-ep.yaml#" - properties: compatible: oneOf: @@ -65,6 +62,31 @@ properties: items: - const: link_state +allOf: + - $ref: "cdns-pcie-ep.yaml#" + - if: + properties: + compatible: + enum: + - ti,am64-pcie-ep + then: + properties: + num-lanes: + minimum: 1 + maximum: 1 + + - if: + properties: + compatible: + enum: + - ti,j7200-pcie-ep + - ti,j721e-pcie-ep + then: + properties: + num-lanes: + minimum: 1 + maximum: 2 + required: - compatible - reg diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml index b0513b197d08..8eca0d08303f 100644 --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml @@ -10,9 +10,6 @@ title: TI J721E PCI Host (PCIe Wrapper) maintainers: - Kishon Vijay Abraham I <kishon@ti.com> -allOf: - - $ref: "cdns-pcie-host.yaml#" - properties: compatible: oneOf: @@ -98,6 +95,31 @@ properties: interrupts: maxItems: 1 +allOf: + - $ref: "cdns-pcie-host.yaml#" + - if: + properties: + compatible: + enum: + - ti,am64-pcie-host + then: + properties: + num-lanes: + minimum: 1 + maximum: 1 + + - if: + properties: + compatible: + enum: + - ti,j7200-pcie-host + - ti,j721e-pcie-host + then: + properties: + num-lanes: + minimum: 1 + maximum: 2 + required: - compatible - reg
Add num-lanes schema checks based on compatible string on available lanes for that platform. Signed-off-by: Matt Ranostay <mranostay@ti.com> --- .../bindings/pci/ti,j721e-pci-ep.yaml | 28 +++++++++++++++++-- .../bindings/pci/ti,j721e-pci-host.yaml | 28 +++++++++++++++++-- 2 files changed, 50 insertions(+), 6 deletions(-)