| Message ID | 20221123082237.1220521-1-liaoyu15@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 661e5ebbafd26d9d2e3c749f5cf591e55c7364f5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: thunderx: Fix the ACPI memory leak | expand |
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni <pabeni@redhat.com>: On Wed, 23 Nov 2022 16:22:36 +0800 you wrote: > The ACPI buffer memory (string.pointer) should be freed as the buffer is > not used after returning from bgx_acpi_match_id(), free it to prevent > memory leak. > > Fixes: 46b903a01c05 ("net, thunder, bgx: Add support to get MAC address from ACPI.") > Signed-off-by: Yu Liao <liaoyu15@huawei.com> > > [...] Here is the summary with links: - net: thunderx: Fix the ACPI memory leak https://git.kernel.org/netdev/net/c/661e5ebbafd2 You are awesome, thank you!
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index 2f6484dc186a..7eb2ddbe9bad 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -1436,8 +1436,10 @@ static acpi_status bgx_acpi_match_id(acpi_handle handle, u32 lvl, return AE_OK; } - if (strncmp(string.pointer, bgx_sel, 4)) + if (strncmp(string.pointer, bgx_sel, 4)) { + kfree(string.pointer); return AE_OK; + } acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, 1, bgx_acpi_register_phy, NULL, bgx, NULL);
The ACPI buffer memory (string.pointer) should be freed as the buffer is not used after returning from bgx_acpi_match_id(), free it to prevent memory leak. Fixes: 46b903a01c05 ("net, thunder, bgx: Add support to get MAC address from ACPI.") Signed-off-by: Yu Liao <liaoyu15@huawei.com> --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)