Message ID | 20221125100255.1786741-1-jiri@resnulli.us (mailing list archive) |
---|---|
State | Accepted |
Commit | 7666dbec7268458505d44ef3ae22fd9181c09b01 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net-next] net: devlink: add WARN_ON_ONCE to check return value of unregister_netdevice_notifier_net() call | expand |
On Fri, Nov 25, 2022 at 11:02:55AM +0100, Jiri Pirko wrote: > From: Jiri Pirko <jiri@nvidia.com> > > As the return value is not 0 only in case there is no such notifier > block registered, add a WARN_ON_ONCE() to yell about it. > > Suggested-by: Ido Schimmel <idosch@idosch.org> > Signed-off-by: Jiri Pirko <jiri@nvidia.com> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Hello: This patch was applied to netdev/net-next.git (master) by Paolo Abeni <pabeni@redhat.com>: On Fri, 25 Nov 2022 11:02:55 +0100 you wrote: > From: Jiri Pirko <jiri@nvidia.com> > > As the return value is not 0 only in case there is no such notifier > block registered, add a WARN_ON_ONCE() to yell about it. > > Suggested-by: Ido Schimmel <idosch@idosch.org> > Signed-off-by: Jiri Pirko <jiri@nvidia.com> > > [...] Here is the summary with links: - [net-next] net: devlink: add WARN_ON_ONCE to check return value of unregister_netdevice_notifier_net() call https://git.kernel.org/netdev/net-next/c/7666dbec7268 You are awesome, thank you!
diff --git a/net/core/devlink.c b/net/core/devlink.c index cea154ddce7a..0e10a8a68c5e 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -9907,8 +9907,8 @@ void devlink_free(struct devlink *devlink) xa_destroy(&devlink->snapshot_ids); - unregister_netdevice_notifier_net(devlink_net(devlink), - &devlink->netdevice_nb); + WARN_ON_ONCE(unregister_netdevice_notifier_net(devlink_net(devlink), + &devlink->netdevice_nb)); xa_erase(&devlinks, devlink->index);