diff mbox series

[v2,1/2] ARM: configs: sama5/7: switch to new MICROCHIP_ISC driver

Message ID 20221125130646.454084-1-eugen.hristev@microchip.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] ARM: configs: sama5/7: switch to new MICROCHIP_ISC driver | expand

Commit Message

Eugen Hristev Nov. 25, 2022, 1:06 p.m. UTC
The ATMEL_ISC and ATMEL_XISC have been deprecated and moved to staging.
Use the new MICROCHIP_ISC/MICROCHIP_XISC symbols which are the
replacement drivers.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
changes in v2:
- split the multi v7 into separate patch

 arch/arm/configs/sama5_defconfig | 2 +-
 arch/arm/configs/sama7_defconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Claudiu Beznea Nov. 25, 2022, 1:47 p.m. UTC | #1
On 25.11.2022 15:06, Eugen Hristev wrote:
> The ATMEL_ISC and ATMEL_XISC have been deprecated and moved to staging.
> Use the new MICROCHIP_ISC/MICROCHIP_XISC symbols which are the
> replacement drivers.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>

Applied to at91-defconfig (after re-worked a bit to keep entries
alphabetically sorted), thanks!

> ---
> changes in v2:
> - split the multi v7 into separate patch
> 
>  arch/arm/configs/sama5_defconfig | 2 +-
>  arch/arm/configs/sama7_defconfig | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
> index 877bbe7b777e..f89fd4e0d10a 100644
> --- a/arch/arm/configs/sama5_defconfig
> +++ b/arch/arm/configs/sama5_defconfig
> @@ -150,8 +150,8 @@ CONFIG_MEDIA_PLATFORM_SUPPORT=y
>  CONFIG_MEDIA_USB_SUPPORT=y
>  CONFIG_USB_VIDEO_CLASS=m
>  CONFIG_V4L_PLATFORM_DRIVERS=y
> -CONFIG_VIDEO_ATMEL_ISC=y
>  CONFIG_VIDEO_ATMEL_ISI=y
> +CONFIG_VIDEO_MICROCHIP_ISC=y
>  CONFIG_VIDEO_MT9V032=m
>  CONFIG_VIDEO_OV2640=m
>  CONFIG_VIDEO_OV5640=m
> diff --git a/arch/arm/configs/sama7_defconfig b/arch/arm/configs/sama7_defconfig
> index 8f28c9d443f0..cc42cea77f38 100644
> --- a/arch/arm/configs/sama7_defconfig
> +++ b/arch/arm/configs/sama7_defconfig
> @@ -140,7 +140,7 @@ CONFIG_MEDIA_SUPPORT_FILTER=y
>  CONFIG_MEDIA_CAMERA_SUPPORT=y
>  CONFIG_MEDIA_PLATFORM_SUPPORT=y
>  CONFIG_V4L_PLATFORM_DRIVERS=y
> -CONFIG_VIDEO_ATMEL_XISC=y
> +CONFIG_VIDEO_MICROCHIP_XISC=y
>  CONFIG_VIDEO_MICROCHIP_CSI2DC=y
>  CONFIG_VIDEO_IMX219=m
>  CONFIG_VIDEO_IMX274=m
Eugen Hristev Nov. 25, 2022, 1:52 p.m. UTC | #2
On 11/25/22 15:47, Claudiu Beznea - M18063 wrote:
> On 25.11.2022 15:06, Eugen Hristev wrote:
>> The ATMEL_ISC and ATMEL_XISC have been deprecated and moved to staging.
>> Use the new MICROCHIP_ISC/MICROCHIP_XISC symbols which are the
>> replacement drivers.
>>
>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> 
> Applied to at91-defconfig (after re-worked a bit to keep entries
> alphabetically sorted), thanks!

I added them in the order given by make savedefconfig. It's not 
alphabetical rather given by the order in the menuconfig it appears.
When moving from media/platform/atmel to media/platform/microchip the 
order in the defconfig changed.
If you reordered them, now there will be differences vs make savedefconfig.

Eugen
> 
>> ---
>> changes in v2:
>> - split the multi v7 into separate patch
>>
>>   arch/arm/configs/sama5_defconfig | 2 +-
>>   arch/arm/configs/sama7_defconfig | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
>> index 877bbe7b777e..f89fd4e0d10a 100644
>> --- a/arch/arm/configs/sama5_defconfig
>> +++ b/arch/arm/configs/sama5_defconfig
>> @@ -150,8 +150,8 @@ CONFIG_MEDIA_PLATFORM_SUPPORT=y
>>   CONFIG_MEDIA_USB_SUPPORT=y
>>   CONFIG_USB_VIDEO_CLASS=m
>>   CONFIG_V4L_PLATFORM_DRIVERS=y
>> -CONFIG_VIDEO_ATMEL_ISC=y
>>   CONFIG_VIDEO_ATMEL_ISI=y
>> +CONFIG_VIDEO_MICROCHIP_ISC=y
>>   CONFIG_VIDEO_MT9V032=m
>>   CONFIG_VIDEO_OV2640=m
>>   CONFIG_VIDEO_OV5640=m
>> diff --git a/arch/arm/configs/sama7_defconfig b/arch/arm/configs/sama7_defconfig
>> index 8f28c9d443f0..cc42cea77f38 100644
>> --- a/arch/arm/configs/sama7_defconfig
>> +++ b/arch/arm/configs/sama7_defconfig
>> @@ -140,7 +140,7 @@ CONFIG_MEDIA_SUPPORT_FILTER=y
>>   CONFIG_MEDIA_CAMERA_SUPPORT=y
>>   CONFIG_MEDIA_PLATFORM_SUPPORT=y
>>   CONFIG_V4L_PLATFORM_DRIVERS=y
>> -CONFIG_VIDEO_ATMEL_XISC=y
>> +CONFIG_VIDEO_MICROCHIP_XISC=y
>>   CONFIG_VIDEO_MICROCHIP_CSI2DC=y
>>   CONFIG_VIDEO_IMX219=m
>>   CONFIG_VIDEO_IMX274=m
>
Claudiu Beznea Nov. 25, 2022, 2:03 p.m. UTC | #3
On 25.11.2022 15:52, Eugen Hristev - M18282 wrote:
> On 11/25/22 15:47, Claudiu Beznea - M18063 wrote:
>> On 25.11.2022 15:06, Eugen Hristev wrote:
>>> The ATMEL_ISC and ATMEL_XISC have been deprecated and moved to staging.
>>> Use the new MICROCHIP_ISC/MICROCHIP_XISC symbols which are the
>>> replacement drivers.
>>>
>>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>>
>> Applied to at91-defconfig (after re-worked a bit to keep entries
>> alphabetically sorted), thanks!
> 
> I added them in the order given by make savedefconfig. It's not 
> alphabetical rather given by the order in the menuconfig it appears.
> When moving from media/platform/atmel to media/platform/microchip the 
> order in the defconfig changed.
> If you reordered them, now there will be differences vs make savedefconfig.

Hm, OK, good to know, I though you added them w/o the drivers in tree.
Thanks for letting me know. I'll revert my changes.

> 
> Eugen
>>
>>> ---
>>> changes in v2:
>>> - split the multi v7 into separate patch
>>>
>>>   arch/arm/configs/sama5_defconfig | 2 +-
>>>   arch/arm/configs/sama7_defconfig | 2 +-
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
>>> index 877bbe7b777e..f89fd4e0d10a 100644
>>> --- a/arch/arm/configs/sama5_defconfig
>>> +++ b/arch/arm/configs/sama5_defconfig
>>> @@ -150,8 +150,8 @@ CONFIG_MEDIA_PLATFORM_SUPPORT=y
>>>   CONFIG_MEDIA_USB_SUPPORT=y
>>>   CONFIG_USB_VIDEO_CLASS=m
>>>   CONFIG_V4L_PLATFORM_DRIVERS=y
>>> -CONFIG_VIDEO_ATMEL_ISC=y
>>>   CONFIG_VIDEO_ATMEL_ISI=y
>>> +CONFIG_VIDEO_MICROCHIP_ISC=y
>>>   CONFIG_VIDEO_MT9V032=m
>>>   CONFIG_VIDEO_OV2640=m
>>>   CONFIG_VIDEO_OV5640=m
>>> diff --git a/arch/arm/configs/sama7_defconfig b/arch/arm/configs/sama7_defconfig
>>> index 8f28c9d443f0..cc42cea77f38 100644
>>> --- a/arch/arm/configs/sama7_defconfig
>>> +++ b/arch/arm/configs/sama7_defconfig
>>> @@ -140,7 +140,7 @@ CONFIG_MEDIA_SUPPORT_FILTER=y
>>>   CONFIG_MEDIA_CAMERA_SUPPORT=y
>>>   CONFIG_MEDIA_PLATFORM_SUPPORT=y
>>>   CONFIG_V4L_PLATFORM_DRIVERS=y
>>> -CONFIG_VIDEO_ATMEL_XISC=y
>>> +CONFIG_VIDEO_MICROCHIP_XISC=y
>>>   CONFIG_VIDEO_MICROCHIP_CSI2DC=y
>>>   CONFIG_VIDEO_IMX219=m
>>>   CONFIG_VIDEO_IMX274=m
>>
>
Eugen Hristev Nov. 25, 2022, 2:07 p.m. UTC | #4
On 11/25/22 16:03, Claudiu Beznea - M18063 wrote:
> On 25.11.2022 15:52, Eugen Hristev - M18282 wrote:
>> On 11/25/22 15:47, Claudiu Beznea - M18063 wrote:
>>> On 25.11.2022 15:06, Eugen Hristev wrote:
>>>> The ATMEL_ISC and ATMEL_XISC have been deprecated and moved to staging.
>>>> Use the new MICROCHIP_ISC/MICROCHIP_XISC symbols which are the
>>>> replacement drivers.
>>>>
>>>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>>>
>>> Applied to at91-defconfig (after re-worked a bit to keep entries
>>> alphabetically sorted), thanks!
>>
>> I added them in the order given by make savedefconfig. It's not
>> alphabetical rather given by the order in the menuconfig it appears.
>> When moving from media/platform/atmel to media/platform/microchip the
>> order in the defconfig changed.
>> If you reordered them, now there will be differences vs make savedefconfig.
> 
> Hm, OK, good to know, I though you added them w/o the drivers in tree.
> Thanks for letting me know. I'll revert my changes.

You can double check the make savedefconfig, to make sure it's fine.
I based the patches on top of latest media staging tree, to make sure 
the right symbol is selected and I don't embarrass myself with a typo

> 
>>
>> Eugen
>>>
>>>> ---
>>>> changes in v2:
>>>> - split the multi v7 into separate patch
>>>>
>>>>    arch/arm/configs/sama5_defconfig | 2 +-
>>>>    arch/arm/configs/sama7_defconfig | 2 +-
>>>>    2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
>>>> index 877bbe7b777e..f89fd4e0d10a 100644
>>>> --- a/arch/arm/configs/sama5_defconfig
>>>> +++ b/arch/arm/configs/sama5_defconfig
>>>> @@ -150,8 +150,8 @@ CONFIG_MEDIA_PLATFORM_SUPPORT=y
>>>>    CONFIG_MEDIA_USB_SUPPORT=y
>>>>    CONFIG_USB_VIDEO_CLASS=m
>>>>    CONFIG_V4L_PLATFORM_DRIVERS=y
>>>> -CONFIG_VIDEO_ATMEL_ISC=y
>>>>    CONFIG_VIDEO_ATMEL_ISI=y
>>>> +CONFIG_VIDEO_MICROCHIP_ISC=y
>>>>    CONFIG_VIDEO_MT9V032=m
>>>>    CONFIG_VIDEO_OV2640=m
>>>>    CONFIG_VIDEO_OV5640=m
>>>> diff --git a/arch/arm/configs/sama7_defconfig b/arch/arm/configs/sama7_defconfig
>>>> index 8f28c9d443f0..cc42cea77f38 100644
>>>> --- a/arch/arm/configs/sama7_defconfig
>>>> +++ b/arch/arm/configs/sama7_defconfig
>>>> @@ -140,7 +140,7 @@ CONFIG_MEDIA_SUPPORT_FILTER=y
>>>>    CONFIG_MEDIA_CAMERA_SUPPORT=y
>>>>    CONFIG_MEDIA_PLATFORM_SUPPORT=y
>>>>    CONFIG_V4L_PLATFORM_DRIVERS=y
>>>> -CONFIG_VIDEO_ATMEL_XISC=y
>>>> +CONFIG_VIDEO_MICROCHIP_XISC=y
>>>>    CONFIG_VIDEO_MICROCHIP_CSI2DC=y
>>>>    CONFIG_VIDEO_IMX219=m
>>>>    CONFIG_VIDEO_IMX274=m
>>>
>>
>
diff mbox series

Patch

diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
index 877bbe7b777e..f89fd4e0d10a 100644
--- a/arch/arm/configs/sama5_defconfig
+++ b/arch/arm/configs/sama5_defconfig
@@ -150,8 +150,8 @@  CONFIG_MEDIA_PLATFORM_SUPPORT=y
 CONFIG_MEDIA_USB_SUPPORT=y
 CONFIG_USB_VIDEO_CLASS=m
 CONFIG_V4L_PLATFORM_DRIVERS=y
-CONFIG_VIDEO_ATMEL_ISC=y
 CONFIG_VIDEO_ATMEL_ISI=y
+CONFIG_VIDEO_MICROCHIP_ISC=y
 CONFIG_VIDEO_MT9V032=m
 CONFIG_VIDEO_OV2640=m
 CONFIG_VIDEO_OV5640=m
diff --git a/arch/arm/configs/sama7_defconfig b/arch/arm/configs/sama7_defconfig
index 8f28c9d443f0..cc42cea77f38 100644
--- a/arch/arm/configs/sama7_defconfig
+++ b/arch/arm/configs/sama7_defconfig
@@ -140,7 +140,7 @@  CONFIG_MEDIA_SUPPORT_FILTER=y
 CONFIG_MEDIA_CAMERA_SUPPORT=y
 CONFIG_MEDIA_PLATFORM_SUPPORT=y
 CONFIG_V4L_PLATFORM_DRIVERS=y
-CONFIG_VIDEO_ATMEL_XISC=y
+CONFIG_VIDEO_MICROCHIP_XISC=y
 CONFIG_VIDEO_MICROCHIP_CSI2DC=y
 CONFIG_VIDEO_IMX219=m
 CONFIG_VIDEO_IMX274=m