| Message ID | 20221128065604.1864391-1-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d66233a312ec9013af3e37e4030b479a20811ec3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed | expand |
On Mon, Nov 28, 2022 at 12:27 PM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > > After system resumed on some environment board, the promiscuous mode > is disabled because the SoC turned off. So, call ravb_set_rx_mode() in > the ravb_resume() to fix the issue. > > Reported-by: Tho Vu <tho.vu.wh@renesas.com> > Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/net/ethernet/renesas/ravb_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 36324126db6d..6bc923326268 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -3020,6 +3020,7 @@ static int __maybe_unused ravb_resume(struct device *dev) > ret = ravb_open(ndev); > if (ret < 0) > return ret; > + ravb_set_rx_mode(ndev); > netif_device_attach(ndev); > } > > -- > 2.25.1 > Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Hello! On 11/28/22 9:56 AM, Yoshihiro Shimoda wrote: > After system resumed on some environment board, the promiscuous mode > is disabled because the SoC turned off. So, call ravb_set_rx_mode() in > the ravb_resume() to fix the issue. Hm, it seems sh_eth.c has the same issue... > Reported-by: Tho Vu <tho.vu.wh@renesas.com> > Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Mon, 28 Nov 2022 15:56:04 +0900 you wrote: > After system resumed on some environment board, the promiscuous mode > is disabled because the SoC turned off. So, call ravb_set_rx_mode() in > the ravb_resume() to fix the issue. > > Reported-by: Tho Vu <tho.vu.wh@renesas.com> > Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > [...] Here is the summary with links: - [net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed https://git.kernel.org/netdev/net/c/d66233a312ec You are awesome, thank you!
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 36324126db6d..6bc923326268 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -3020,6 +3020,7 @@ static int __maybe_unused ravb_resume(struct device *dev) ret = ravb_open(ndev); if (ret < 0) return ret; + ravb_set_rx_mode(ndev); netif_device_attach(ndev); }
After system resumed on some environment board, the promiscuous mode is disabled because the SoC turned off. So, call ravb_set_rx_mode() in the ravb_resume() to fix the issue. Reported-by: Tho Vu <tho.vu.wh@renesas.com> Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/net/ethernet/renesas/ravb_main.c | 1 + 1 file changed, 1 insertion(+)