mbox series

[v5,0/4] mfd: add tps6594 support for Jacinto platforms

Message ID 20221123053512.1195309-1-mranostay@ti.com (mailing list archive)
Headers show
Series mfd: add tps6594 support for Jacinto platforms | expand

Message

Matt Ranostay Nov. 23, 2022, 5:35 a.m. UTC
This patchset series adds support for the TPS6594 PMIC along with
initial support for its RTC + GPIO interface, and poweroff sequence.

Changes from v1:
* Corrected devicetree documentation issues found with dt-schema
* Changed MFD references to PMIC reflecting the more valid use of driver
* Cleaning up variable naming and ordering within functions
* Adding gpio + regulator cells for upcoming driver support
* Switching from .probe to .probe_new API
* Revising comments within drivers to be more concise
* Adding device tree nodes for j721s2 and j721e platforms

Changes from v2:
* Adding gpio-tps6594x driver support
* Enabling gpio cell in MFD driver

Changes from v3:
* Refactoring gpio driver to use regmap gpio helpers
* Changing rtc driver to use more of device resource management
* Minor code changes related to error messages that aren't useful
  being dropped
* Dropped wildcard in device-tree compatible, and i2c device id
* Dropped device tree changes from the series; since these should
  be in their own series later

Changes from v4:
* Corrected commit messages for device tree documentation
* Added TPS6954 datasheet PDF to devicetree documentation
* Renamed all references, including filenames + configuration options,
  from tps6594x to tps6594 dropping the unneeded wildcard

Keerthy (2):
  mfd: tps6594: Add support for TPS6594 PMIC devices
  rtc: rtc-tps6594: Add support for TPS6594 PMIC RTC

Matt Ranostay (2):
  dt-bindings: mfd: ti,tps6594: add TPS6594 PMIC support
  gpio: gpio-tps6594: add GPIO support for TPS6594 PMIC

 .../devicetree/bindings/mfd/ti,tps6594.yaml   |  69 ++++++++
 drivers/gpio/Kconfig                          |   9 +
 drivers/gpio/Makefile                         |   1 +
 drivers/gpio/gpio-tps6594.c                   |  78 +++++++++
 drivers/mfd/Kconfig                           |  14 ++
 drivers/mfd/Makefile                          |   1 +
 drivers/mfd/tps6594.c                         | 113 +++++++++++++
 drivers/rtc/Kconfig                           |  10 ++
 drivers/rtc/Makefile                          |   1 +
 drivers/rtc/rtc-tps6594.c                     | 155 ++++++++++++++++++
 include/linux/mfd/tps6594.h                   |  88 ++++++++++
 11 files changed, 539 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
 create mode 100644 drivers/gpio/gpio-tps6594.c
 create mode 100644 drivers/mfd/tps6594.c
 create mode 100644 drivers/rtc/rtc-tps6594.c
 create mode 100644 include/linux/mfd/tps6594.h

Comments

J, KEERTHY Nov. 28, 2022, 7:25 p.m. UTC | #1
On 11/23/2022 11:05 AM, Matt Ranostay wrote:
> This patchset series adds support for the TPS6594 PMIC along with
> initial support for its RTC + GPIO interface, and poweroff sequence.

For the series:

Reviewed-by: Keerthy <j-keerthy@ti.com>

- Keerthy
> 
> Changes from v1:
> * Corrected devicetree documentation issues found with dt-schema
> * Changed MFD references to PMIC reflecting the more valid use of driver
> * Cleaning up variable naming and ordering within functions
> * Adding gpio + regulator cells for upcoming driver support
> * Switching from .probe to .probe_new API
> * Revising comments within drivers to be more concise
> * Adding device tree nodes for j721s2 and j721e platforms
> 
> Changes from v2:
> * Adding gpio-tps6594x driver support
> * Enabling gpio cell in MFD driver
> 
> Changes from v3:
> * Refactoring gpio driver to use regmap gpio helpers
> * Changing rtc driver to use more of device resource management
> * Minor code changes related to error messages that aren't useful
>    being dropped
> * Dropped wildcard in device-tree compatible, and i2c device id
> * Dropped device tree changes from the series; since these should
>    be in their own series later
> 
> Changes from v4:
> * Corrected commit messages for device tree documentation
> * Added TPS6954 datasheet PDF to devicetree documentation
> * Renamed all references, including filenames + configuration options,
>    from tps6594x to tps6594 dropping the unneeded wildcard
> 
> Keerthy (2):
>    mfd: tps6594: Add support for TPS6594 PMIC devices
>    rtc: rtc-tps6594: Add support for TPS6594 PMIC RTC
> 
> Matt Ranostay (2):
>    dt-bindings: mfd: ti,tps6594: add TPS6594 PMIC support
>    gpio: gpio-tps6594: add GPIO support for TPS6594 PMIC
> 
>   .../devicetree/bindings/mfd/ti,tps6594.yaml   |  69 ++++++++
>   drivers/gpio/Kconfig                          |   9 +
>   drivers/gpio/Makefile                         |   1 +
>   drivers/gpio/gpio-tps6594.c                   |  78 +++++++++
>   drivers/mfd/Kconfig                           |  14 ++
>   drivers/mfd/Makefile                          |   1 +
>   drivers/mfd/tps6594.c                         | 113 +++++++++++++
>   drivers/rtc/Kconfig                           |  10 ++
>   drivers/rtc/Makefile                          |   1 +
>   drivers/rtc/rtc-tps6594.c                     | 155 ++++++++++++++++++
>   include/linux/mfd/tps6594.h                   |  88 ++++++++++
>   11 files changed, 539 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
>   create mode 100644 drivers/gpio/gpio-tps6594.c
>   create mode 100644 drivers/mfd/tps6594.c
>   create mode 100644 drivers/rtc/rtc-tps6594.c
>   create mode 100644 include/linux/mfd/tps6594.h
>