mbox series

[v4,net-next,0/8] : hsr: HSR send/recv fixes

Message ID 20221125165610.3802446-1-bigeasy@linutronix.de (mailing list archive)
Headers show
Series : hsr: HSR send/recv fixes | expand

Message

Sebastian Andrzej Siewior Nov. 25, 2022, 4:56 p.m. UTC 
I started playing with HSR and run into a problem. Tested latest
upstream -rc and noticed more problems. Now it appears to work.
For testing I have a small three node setup with iperf and ping. While
iperf doesn't complain ping reports missing packets and duplicates.

v3…v4:
- Targeting net-next now.
- Added patch #7 back to basket. Kurt's review comments are addressed.
- Added a basic test for HSRv0.

v2…v3:
- dropped patch #7 was an optimisation.

v1…v2:
- Replaced cmpxchg() from patch #6 with lock because RiscV does not provide
  cmpxchg() for 16bit.
- Added patch #3 which fixes the random crashes I observed on latest rc5 while
  testing.

Sebastian

Comments

Jakub Kicinski Nov. 29, 2022, 3:24 a.m. UTC | #1 
On Fri, 25 Nov 2022 17:56:02 +0100 Sebastian Andrzej Siewior wrote:
> I started playing with HSR and run into a problem. Tested latest
> upstream -rc and noticed more problems. Now it appears to work.
> For testing I have a small three node setup with iperf and ping. While
> iperf doesn't complain ping reports missing packets and duplicates.

Any reason Arvid is not CCed? please always when there's a Fixes tag,
the authors should be CCed.

Please run v5 thru checkpatch there are spelling errors it points out
(and maybe something more).
Sebastian Andrzej Siewior Nov. 29, 2022, 7:21 a.m. UTC | #2 
On 2022-11-28 19:24:01 [-0800], Jakub Kicinski wrote:
> On Fri, 25 Nov 2022 17:56:02 +0100 Sebastian Andrzej Siewior wrote:
> > I started playing with HSR and run into a problem. Tested latest
> > upstream -rc and noticed more problems. Now it appears to work.
> > For testing I have a small three node setup with iperf and ping. While
> > iperf doesn't complain ping reports missing packets and duplicates.
> 
> Any reason Arvid is not CCed? please always when there's a Fixes tag,
> the authors should be CCed.

As per commit
   e8d5bb4dfaa72 ("MAINTAINERS: Orphan HSR network protocol")

that email bounces. So not added because that email
(arvid.brodin@alten.se) won't reach him. Is there another one I missed?

> Please run v5 thru checkpatch there are spelling errors it points out
> (and maybe something more).

I remember doing that. Will do again ;)

Sebastian
Jakub Kicinski Nov. 29, 2022, 4:09 p.m. UTC | #3 
On Tue, 29 Nov 2022 08:21:22 +0100 Sebastian Andrzej Siewior wrote:
> As per commit
>    e8d5bb4dfaa72 ("MAINTAINERS: Orphan HSR network protocol")
> 
> that email bounces. So not added because that email
> (arvid.brodin@alten.se) won't reach him. Is there another one I missed?

I see, thanks, let me add the addr to my local email graveyard.