Message ID | 20221125123638.823261-4-bryan.odonoghue@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | mdss-dsi-ctrl binding and dts fixes | expand |
On 25/11/2022 14:36, Bryan O'Donoghue wrote: > We will add in a number of compat strings to dsi-controller-main.yaml in > the format "qcom,socname-dsi-ctrl" convert the currently unused > qcom,dsi-ctrl-6g-qcm2290 to qcom,qcm2290-dsi-ctrl. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> I'd say, as you are going to introduce new bindings using two compat strings, just leave this binding as is, marking it as deprecated. > --- > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index cf782c5f5bdb0..67d08dc338925 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -16,7 +16,7 @@ properties: > compatible: > enum: > - qcom,mdss-dsi-ctrl > - - qcom,dsi-ctrl-6g-qcm2290 > + - qcom,qcm2290-dsi-ctrl > > reg: > maxItems: 1
On Sat, Nov 26, 2022 at 08:54:11PM +0200, Dmitry Baryshkov wrote: > On 25/11/2022 14:36, Bryan O'Donoghue wrote: > > We will add in a number of compat strings to dsi-controller-main.yaml in > > the format "qcom,socname-dsi-ctrl" convert the currently unused > > qcom,dsi-ctrl-6g-qcm2290 to qcom,qcm2290-dsi-ctrl. > > > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > > I'd say, as you are going to introduce new bindings using two compat > strings, just leave this binding as is, marking it as deprecated. But if it was unused, then it's okay to just change it. Rob
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index cf782c5f5bdb0..67d08dc338925 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -16,7 +16,7 @@ properties: compatible: enum: - qcom,mdss-dsi-ctrl - - qcom,dsi-ctrl-6g-qcm2290 + - qcom,qcm2290-dsi-ctrl reg: maxItems: 1
We will add in a number of compat strings to dsi-controller-main.yaml in the format "qcom,socname-dsi-ctrl" convert the currently unused qcom,dsi-ctrl-6g-qcm2290 to qcom,qcm2290-dsi-ctrl. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)