scsi: ufs: core: Separate function name and message

Commit Message

Chanwoo Lee Nov. 11, 2022, 6:21 a.m. UTC

From: ChanWoo Lee <[e-mail]>

Separate the function name and message to make it easier to check the log.
Modify messages to fit the format of others.

Signed-off-by: ChanWoo Lee <[e-mail]>
---
 drivers/ufs/core/ufshcd.c | 6 +++---
 drivers/ufs/core/ufshpb.c | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

Martin K. Petersen Nov. 26, 2022, 12:19 a.m. UTC | #1

Chanwoo,

> Separate the function name and message to make it easier to check the
> log.  Modify messages to fit the format of others.

Applied to 6.2/scsi-staging, thanks!

Martin K. Petersen Dec. 1, 2022, 3:45 a.m. UTC | #2

On Fri, 11 Nov 2022 15:21:26 +0900, Chanwoo Lee wrote:

> From: ChanWoo Lee <[e-mail]>
> 
> Separate the function name and message to make it easier to check the log.
> Modify messages to fit the format of others.
> 
> 

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: ufs: core: Separate function name and message
      https://git.kernel.org/mkp/scsi/c/859ed37c9c3f

Patch

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index e389d73765fe..fdbcbcf3f9d1 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -4480,7 +4480,7 @@  static int ufshcd_complete_dev_init(struct ufs_hba *hba)
 		QUERY_FLAG_IDN_FDEVICEINIT, 0, NULL);
 	if (err) {
 		dev_err(hba->dev,
-			"%s setting fDeviceInit flag failed with error %d\n",
+			"%s: setting fDeviceInit flag failed with error %d\n",
 			__func__, err);
 		goto out;
 	}
@@ -4497,11 +4497,11 @@  static int ufshcd_complete_dev_init(struct ufs_hba *hba)
 
 	if (err) {
 		dev_err(hba->dev,
-				"%s reading fDeviceInit flag failed with error %d\n",
+				"%s: reading fDeviceInit flag failed with error %d\n",
 				__func__, err);
 	} else if (flag_res) {
 		dev_err(hba->dev,
-				"%s fDeviceInit was not cleared by the device\n",
+				"%s: fDeviceInit was not cleared by the device\n",
 				__func__);
 		err = -EBUSY;
 	}
diff --git a/drivers/ufs/core/ufshpb.c b/drivers/ufs/core/ufshpb.c
index b7f412d0f301..148017b2dfeb 100644
--- a/drivers/ufs/core/ufshpb.c
+++ b/drivers/ufs/core/ufshpb.c
@@ -2289,7 +2289,7 @@  static bool ufshpb_check_hpb_reset_query(struct ufs_hba *hba)
 	/* wait for the device to complete HPB reset query */
 	for (try = 0; try < HPB_RESET_REQ_RETRIES; try++) {
 		dev_dbg(hba->dev,
-			"%s start flag reset polling %d times\n",
+			"%s: start flag reset polling %d times\n",
 			__func__, try);
 
 		/* Poll fHpbReset flag to be cleared */
@@ -2298,7 +2298,7 @@  static bool ufshpb_check_hpb_reset_query(struct ufs_hba *hba)
 
 		if (err) {
 			dev_err(hba->dev,
-				"%s reading fHpbReset flag failed with error %d\n",
+				"%s: reading fHpbReset flag failed with error %d\n",
 				__func__, err);
 			return flag_res;
 		}
@@ -2310,7 +2310,7 @@  static bool ufshpb_check_hpb_reset_query(struct ufs_hba *hba)
 	}
 	if (flag_res) {
 		dev_err(hba->dev,
-			"%s fHpbReset was not cleared by the device\n",
+			"%s: fHpbReset was not cleared by the device\n",
 			__func__);
 	}
 out: