| Message ID | 20221201230810.1019834-2-ahalaney@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: ufs: ufs-qcom: Debug clean ups | expand |
On Thu, Dec 01, 2022 at 05:08:07PM -0600, Andrew Halaney wrote: > This code path is only called through one function, and the hba > struct is already accessed in ufshcd_vops_dbg_register_dump() prior to > calling so there is no way for it to be NULL. > > Likewise, the print_fn callback is always supplied within this driver > and is always provided. > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > drivers/ufs/host/ufs-qcom.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 8ad1415e10b6..70e25f9f8ca8 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -1202,15 +1202,6 @@ static void ufs_qcom_print_hw_debug_reg_all(struct ufs_hba *hba, > u32 reg; > struct ufs_qcom_host *host; > > - if (unlikely(!hba)) { > - pr_err("%s: hba is NULL\n", __func__); > - return; > - } > - if (unlikely(!print_fn)) { > - dev_err(hba->dev, "%s: print_fn is NULL\n", __func__); > - return; > - } > - > host = ufshcd_get_variant(hba); > if (!(host->dbg_print_en & UFS_QCOM_DBG_PRINT_REGS_EN)) > return; > -- > 2.38.1 >
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 8ad1415e10b6..70e25f9f8ca8 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1202,15 +1202,6 @@ static void ufs_qcom_print_hw_debug_reg_all(struct ufs_hba *hba, u32 reg; struct ufs_qcom_host *host; - if (unlikely(!hba)) { - pr_err("%s: hba is NULL\n", __func__); - return; - } - if (unlikely(!print_fn)) { - dev_err(hba->dev, "%s: print_fn is NULL\n", __func__); - return; - } - host = ufshcd_get_variant(hba); if (!(host->dbg_print_en & UFS_QCOM_DBG_PRINT_REGS_EN)) return;
This code path is only called through one function, and the hba struct is already accessed in ufshcd_vops_dbg_register_dump() prior to calling so there is no way for it to be NULL. Likewise, the print_fn callback is always supplied within this driver and is always provided. Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- drivers/ufs/host/ufs-qcom.c | 9 --------- 1 file changed, 9 deletions(-)