| Message ID | 1669962342-2806-1-git-send-email-tee.min.tan@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 43aa9d9ce7f89fe3f14a3589c9b05e513dd3073c |
| Delegated to: | David Ahern |
| Headers | show |
| Series | [iproute2-next,1/1] taprio: fix wrong for loop condition in add_tc_entries() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to iproute2/iproute2-next.git (main) by David Ahern <dsahern@kernel.org>: On Fri, 2 Dec 2022 14:25:42 +0800 you wrote: > The for loop in add_tc_entries() mistakenly included the last entry > index+1. Fix it to correctly loop the max_sdu entry between tc=0 and > num_max_sdu_entries-1. > > Fixes: b10a6509c195 ("taprio: support dumping and setting per-tc max SDU") > Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com> > > [...] Here is the summary with links: - [iproute2-next,1/1] taprio: fix wrong for loop condition in add_tc_entries() https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=43aa9d9ce7f8 You are awesome, thank you!
On Fri, Dec 02, 2022 at 02:25:42PM +0800, Tan Tee Min wrote: > The for loop in add_tc_entries() mistakenly included the last entry > index+1. Fix it to correctly loop the max_sdu entry between tc=0 and > num_max_sdu_entries-1. > > Fixes: b10a6509c195 ("taprio: support dumping and setting per-tc max SDU") > Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com> > --- Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
diff --git a/tc/q_taprio.c b/tc/q_taprio.c index ded385ca..a7c01ae0 100644 --- a/tc/q_taprio.c +++ b/tc/q_taprio.c @@ -157,7 +157,7 @@ static void add_tc_entries(struct nlmsghdr *n, __u32 max_sdu[TC_QOPT_MAX_QUEUE], struct rtattr *l; __u32 tc; - for (tc = 0; tc <= num_max_sdu_entries; tc++) { + for (tc = 0; tc < num_max_sdu_entries; tc++) { l = addattr_nest(n, 1024, TCA_TAPRIO_ATTR_TC_ENTRY | NLA_F_NESTED); addattr_l(n, 1024, TCA_TAPRIO_TC_ENTRY_INDEX, &tc, sizeof(tc));
The for loop in add_tc_entries() mistakenly included the last entry index+1. Fix it to correctly loop the max_sdu entry between tc=0 and num_max_sdu_entries-1. Fixes: b10a6509c195 ("taprio: support dumping and setting per-tc max SDU") Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com> --- tc/q_taprio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)