| Message ID | 20221202221240.225720-1-elder@linaro.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | [v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock | expand |
On 2.12.2022 23:12, Alex Elder wrote: > From: Luca Weiss <luca.weiss@fairphone.com> > > The IPA core clock is required for SM6350. Define it. > > [elder@linaro.org: rebased with Dmitry's changes] > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > v2: This is now based on qualcomm/for-next. > > drivers/clk/qcom/clk-rpmh.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c > index 2c2ef4b6d130e..586a810c682ca 100644 > --- a/drivers/clk/qcom/clk-rpmh.c > +++ b/drivers/clk/qcom/clk-rpmh.c > @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = { > [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw, > [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw, > [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw, > + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, > }; > > static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote: > From: Luca Weiss <luca.weiss@fairphone.com> > > The IPA core clock is required for SM6350. Define it. > > [elder@linaro.org: rebased with Dmitry's changes] > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Thanks for rebasing this Alex. But as you're handling the patch you need to add your S-o-b; which will make sure your [] makes sense as well. Regards, Bjorn > --- > v2: This is now based on qualcomm/for-next. > > drivers/clk/qcom/clk-rpmh.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c > index 2c2ef4b6d130e..586a810c682ca 100644 > --- a/drivers/clk/qcom/clk-rpmh.c > +++ b/drivers/clk/qcom/clk-rpmh.c > @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = { > [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw, > [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw, > [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw, > + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, > }; > > static const struct clk_rpmh_desc clk_rpmh_sm6350 = { > -- > 2.34.1 >
On 12/5/22 4:56 PM, Bjorn Andersson wrote: > On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote: >> From: Luca Weiss <luca.weiss@fairphone.com> >> >> The IPA core clock is required for SM6350. Define it. >> >> [elder@linaro.org: rebased with Dmitry's changes] >> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Sorry about that, I knew I was supposed to sign off and thought I had. You told me separately that this was sufficient: Signed-off-by: Alex Elder <elder@linaro.org> If you want me to send a new version with the signoff just let me know. Thanks. -Alex > > Thanks for rebasing this Alex. But as you're handling the patch you need > to add your S-o-b; which will make sure your [] makes sense as well. > > Regards, > Bjorn > >> --- >> v2: This is now based on qualcomm/for-next. >> >> drivers/clk/qcom/clk-rpmh.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c >> index 2c2ef4b6d130e..586a810c682ca 100644 >> --- a/drivers/clk/qcom/clk-rpmh.c >> +++ b/drivers/clk/qcom/clk-rpmh.c >> @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = { >> [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw, >> [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw, >> [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw, >> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, >> }; >> >> static const struct clk_rpmh_desc clk_rpmh_sm6350 = { >> -- >> 2.34.1 >>
On Mon, Dec 05, 2022 at 09:05:30PM -0600, Alex Elder wrote: > On 12/5/22 4:56 PM, Bjorn Andersson wrote: > > On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote: > > > From: Luca Weiss <luca.weiss@fairphone.com> > > > > > > The IPA core clock is required for SM6350. Define it. > > > > > > [elder@linaro.org: rebased with Dmitry's changes] > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > Sorry about that, I knew I was supposed to sign > off and thought I had. > > You told me separately that this was sufficient: > > Signed-off-by: Alex Elder <elder@linaro.org> > > If you want me to send a new version with the > signoff just let me know. Thanks. > That works fine, thank you. Bjorn > -Alex > > > > Thanks for rebasing this Alex. But as you're handling the patch you need > > to add your S-o-b; which will make sure your [] makes sense as well. > > > > Regards, > > Bjorn > > > > > --- > > > v2: This is now based on qualcomm/for-next. > > > > > > drivers/clk/qcom/clk-rpmh.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c > > > index 2c2ef4b6d130e..586a810c682ca 100644 > > > --- a/drivers/clk/qcom/clk-rpmh.c > > > +++ b/drivers/clk/qcom/clk-rpmh.c > > > @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = { > > > [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw, > > > [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw, > > > [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw, > > > + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, > > > }; > > > static const struct clk_rpmh_desc clk_rpmh_sm6350 = { > > > -- > > > 2.34.1 > > > >
On Fri, 2 Dec 2022 16:12:40 -0600, Alex Elder wrote: > From: Luca Weiss <luca.weiss@fairphone.com> > > The IPA core clock is required for SM6350. Define it. > > [elder@linaro.org: rebased with Dmitry's changes] > > > [...] Applied, thanks! [1/1] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock commit: 2931aa6758da9f871b4bd7ee52a4be2f9d24e6ce Best regards,
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index 2c2ef4b6d130e..586a810c682ca 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = { [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw, [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw, [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw, + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, }; static const struct clk_rpmh_desc clk_rpmh_sm6350 = {