| Message ID | 20221203094240.1240211-2-liujian56@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 433c07a13f59856e4585e89e86b7d4cc59348fab |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: hisilicon: Fix potential use-after-free in hix5hd2_rx() | expand |
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni <pabeni@redhat.com>: On Sat, 3 Dec 2022 17:42:40 +0800 you wrote: > The skb is delivered to napi_gro_receive() which may free it, after > calling this, dereferencing skb may trigger use-after-free. > > Fixes: 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver") > Signed-off-by: Liu Jian <liujian56@huawei.com> > --- > drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net] net: hisilicon: Fix potential use-after-free in hix5hd2_rx() https://git.kernel.org/netdev/net/c/433c07a13f59 You are awesome, thank you!
diff --git a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c index ffcf797dfa90..f867e9531117 100644 --- a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c +++ b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c @@ -550,7 +550,7 @@ static int hix5hd2_rx(struct net_device *dev, int limit) skb->protocol = eth_type_trans(skb, dev); napi_gro_receive(&priv->napi, skb); dev->stats.rx_packets++; - dev->stats.rx_bytes += skb->len; + dev->stats.rx_bytes += len; next: pos = dma_ring_incr(pos, RX_DESC_NUM); }
The skb is delivered to napi_gro_receive() which may free it, after calling this, dereferencing skb may trigger use-after-free. Fixes: 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver") Signed-off-by: Liu Jian <liujian56@huawei.com> --- drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)