diff mbox series

[18/19] timers: Don't migrate timers during suspend

Message ID babd4e0c615c7f61c10b53ad884c68c85641ce7c.1665137247.git.mykyta_poturai@epam.com (mailing list archive)
State New, archived
Headers show
Series [01/19] xen/arm: Implement PSCI system suspend | expand

Commit Message

Mykyta Poturai Oct. 7, 2022, 10:32 a.m. UTC 
Migrating timers during suspend causes Dom0 to freeze after resume.

Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
---
 xen/common/timer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Julien Grall Dec. 6, 2022, 10:19 p.m. UTC | #1 
Hi,

On 07/10/2022 11:32, Mykyta Poturai wrote:
> Migrating timers during suspend causes Dom0 to freeze after resume.

This wants a bit more details such as why dom0 will freeze. But looking 
at upstream, there might be some patches that (e.g. 37f82facd62f 
"xen/sched: migrate timers to correct cpus after suspend") could have 
solved a similar problem.

Cheers,
diff mbox series

Patch

diff --git a/xen/common/timer.c b/xen/common/timer.c
index 1bb265ceea..52d4f72a76 100644
--- a/xen/common/timer.c
+++ b/xen/common/timer.c
@@ -658,7 +658,8 @@  static int cpu_callback(
     case CPU_UP_CANCELED:
     case CPU_DEAD:
     case CPU_RESUME_FAILED:
-        migrate_timers_from_cpu(cpu);
+        if ( system_state != SYS_STATE_suspend )
+            migrate_timers_from_cpu(cpu);
 
         if ( !park_offline_cpus && system_state != SYS_STATE_suspend )
             free_percpu_timers(cpu);