| Message ID | 2262737.ElGaqSPkdT@kreacher (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [Regression] Logitech BT mouse unusable after commit 532223c8ac57 (still in 6.1-rc8) | expand |
On Tue, Dec 6, 2022 at 3:58 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > Bastien, Jiri, > > Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all the Logitech > Bluetooth devices") caused my Logitech Bluetooth mouse to become unusable. > > Appended is the change I need to make it work again (note that adding the > device ID to unhandled_hidpp_devices[] doesn't help, so there must be some > significant enough difference in how the two cases are handled in the stack). > > Here's what I get in the log without the patch below: > > [ 36.710574] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 > [ 36.710592] Bluetooth: HIDP socket layer initialized > [ 36.724644] hid-generic 0005:046D:B016.0001: unknown main item tag 0x0 > [ 36.725860] input: Bluetooth Mouse M336/M337/M535 Mouse as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > [ 36.728036] input: Bluetooth Mouse M336/M337/M535 Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > [ 36.728823] input: Bluetooth Mouse M336/M337/M535 Keyboard as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > [ 36.731550] hid-generic 0005:046D:B016.0001: input,hidraw0: BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on 9c:b6:d0:96:8e:c8 > [ 36.833039] logitech-hidpp-device 0005:046D:B016.0001: unknown main item tag 0x0 > [ 36.999064] logitech-hidpp-device 0005:046D:B016.0001: Device not connected > > and here's what I get with it: > > [ 43.642546] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 > [ 43.642559] Bluetooth: HIDP socket layer initialized > [ 43.652898] hid-generic 0005:046D:B016.0001: unknown main item tag 0x0 > [ 43.653833] input: Bluetooth Mouse M336/M337/M535 Mouse as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > [ 43.655025] input: Bluetooth Mouse M336/M337/M535 Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > [ 43.655400] input: Bluetooth Mouse M336/M337/M535 Keyboard as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > [ 43.657521] hid-generic 0005:046D:B016.0001: input,hidraw0: BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on 9c:b6:d0:96:8e:c8 > > The only difference seems to be that in the former case the logitech-hidpp > driver tries to bind to the device, but I guess that is expected. However, > when the device ID is added to unhandled_hidpp_devices[], the messages look > exactly like in the "good" case, but the mouse still doesn't work. Here's what happens. - The logitech-hidpp driver is modular and is not present initially, so hid-generic probes first (successfully). - logitech-hidpp is loaded which causes the device to be reporobed due to __hid_bus_driver_added(). - Because the ->match() callback in hid-generic returns 0 for the device now, it is unbound from the device. - The probing of logitech-hidpp fails (due to an error in ->probe()). - The probing of hid-generic fails due to the failing ->match(). So in order for unhandled_hidpp_devices[] in logitech-hidpp to work with hid-generic, __check_hid_generic() needs to be amended with a change to run the ->match() callback of the "specific" driver being tried. I have a working patch for this that will be sent shortly. Thanks!
On Tue, 2022-12-06 at 15:58 +0100, Rafael J. Wysocki wrote: > Bastien, Jiri, > > Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all the > Logitech > Bluetooth devices") caused my Logitech Bluetooth mouse to become > unusable. > > Appended is the change I need to make it work again (note that adding > the > device ID to unhandled_hidpp_devices[] doesn't help, so there must be > some > significant enough difference in how the two cases are handled in the > stack). > > Here's what I get in the log without the patch below: > > [ 36.710574] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 > [ 36.710592] Bluetooth: HIDP socket layer initialized > [ 36.724644] hid-generic 0005:046D:B016.0001: unknown main item tag > 0x0 > [ 36.725860] input: Bluetooth Mouse M336/M337/M535 Mouse as > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > [ 36.728036] input: Bluetooth Mouse M336/M337/M535 Consumer Control > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > [ 36.728823] input: Bluetooth Mouse M336/M337/M535 Keyboard as > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > [ 36.731550] hid-generic 0005:046D:B016.0001: input,hidraw0: > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > 9c:b6:d0:96:8e:c8 > [ 36.833039] logitech-hidpp-device 0005:046D:B016.0001: unknown > main item tag 0x0 > [ 36.999064] logitech-hidpp-device 0005:046D:B016.0001: Device not > connected > > and here's what I get with it: > > [ 43.642546] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 > [ 43.642559] Bluetooth: HIDP socket layer initialized > [ 43.652898] hid-generic 0005:046D:B016.0001: unknown main item tag > 0x0 > [ 43.653833] input: Bluetooth Mouse M336/M337/M535 Mouse as > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > [ 43.655025] input: Bluetooth Mouse M336/M337/M535 Consumer Control > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > [ 43.655400] input: Bluetooth Mouse M336/M337/M535 Keyboard as > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > [ 43.657521] hid-generic 0005:046D:B016.0001: input,hidraw0: > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > 9c:b6:d0:96:8e:c8 > > The only difference seems to be that in the former case the logitech- > hidpp > driver tries to bind to the device, but I guess that is expected. There really shouldn't be that much difference between the 2 paths, except that hid-logitech-hidpp.c will check that the device supports HID++ in its report descriptors, and then start talking to it to check whether it's connected. Maybe the device doesn't support HID++? Can you try running src/tools/hidpp-list-features from https://github.com/cvuchener/hidpp on the hidraw device for the mouse? > However, > when the device ID is added to unhandled_hidpp_devices[], the > messages look > exactly like in the "good" case, but the mouse still doesn't work. Given that this should be called without ever talking to the device, that tells me that there might be a logic bug in the hid-core that uses ->probe. Benjamin?
On Wed, 2022-12-07 at 09:58 +0100, Rafael J. Wysocki wrote: > On Tue, Dec 6, 2022 at 3:58 PM Rafael J. Wysocki <rjw@rjwysocki.net> > wrote: > > > > Bastien, Jiri, > > > > Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all the > > Logitech > > Bluetooth devices") caused my Logitech Bluetooth mouse to become > > unusable. > > > > Appended is the change I need to make it work again (note that > > adding the > > device ID to unhandled_hidpp_devices[] doesn't help, so there must > > be some > > significant enough difference in how the two cases are handled in > > the stack). > > > > Here's what I get in the log without the patch below: > > > > [ 36.710574] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 > > [ 36.710592] Bluetooth: HIDP socket layer initialized > > [ 36.724644] hid-generic 0005:046D:B016.0001: unknown main item > > tag 0x0 > > [ 36.725860] input: Bluetooth Mouse M336/M337/M535 Mouse as > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > > [ 36.728036] input: Bluetooth Mouse M336/M337/M535 Consumer > > Control as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > > [ 36.728823] input: Bluetooth Mouse M336/M337/M535 Keyboard as > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > > [ 36.731550] hid-generic 0005:046D:B016.0001: input,hidraw0: > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > > 9c:b6:d0:96:8e:c8 > > [ 36.833039] logitech-hidpp-device 0005:046D:B016.0001: unknown > > main item tag 0x0 > > [ 36.999064] logitech-hidpp-device 0005:046D:B016.0001: Device > > not connected > > > > and here's what I get with it: > > > > [ 43.642546] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 > > [ 43.642559] Bluetooth: HIDP socket layer initialized > > [ 43.652898] hid-generic 0005:046D:B016.0001: unknown main item > > tag 0x0 > > [ 43.653833] input: Bluetooth Mouse M336/M337/M535 Mouse as > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > > [ 43.655025] input: Bluetooth Mouse M336/M337/M535 Consumer > > Control as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > > [ 43.655400] input: Bluetooth Mouse M336/M337/M535 Keyboard as > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > > [ 43.657521] hid-generic 0005:046D:B016.0001: input,hidraw0: > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > > 9c:b6:d0:96:8e:c8 > > > > The only difference seems to be that in the former case the > > logitech-hidpp > > driver tries to bind to the device, but I guess that is expected. > > However, > > when the device ID is added to unhandled_hidpp_devices[], the > > messages look > > exactly like in the "good" case, but the mouse still doesn't work. > > Here's what happens. > > - The logitech-hidpp driver is modular and is not present initially, > so hid-generic probes first (successfully). > > - logitech-hidpp is loaded which causes the device to be reporobed > due > to __hid_bus_driver_added(). > > - Because the ->match() callback in hid-generic returns 0 for the > device now, it is unbound from the device. > > - The probing of logitech-hidpp fails (due to an error in ->probe()). > > - The probing of hid-generic fails due to the failing ->match(). > > So in order for unhandled_hidpp_devices[] in logitech-hidpp to work > with hid-generic, __check_hid_generic() needs to be amended with a > change to run the ->match() callback of the "specific" driver being > tried. > > I have a working patch for this that will be sent shortly. I'm glad my belated questioning of the hid-generic fallback code was correct ;) My question about getting the output from the HID++ tool still stands though.
On Wednesday, December 7, 2022 10:04:43 AM CET Bastien Nocera wrote: > On Tue, 2022-12-06 at 15:58 +0100, Rafael J. Wysocki wrote: > > Bastien, Jiri, > > > > Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all the > > Logitech > > Bluetooth devices") caused my Logitech Bluetooth mouse to become > > unusable. > > > > Appended is the change I need to make it work again (note that adding > > the > > device ID to unhandled_hidpp_devices[] doesn't help, so there must be > > some > > significant enough difference in how the two cases are handled in the > > stack). > > > > Here's what I get in the log without the patch below: > > > > [ 36.710574] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 > > [ 36.710592] Bluetooth: HIDP socket layer initialized > > [ 36.724644] hid-generic 0005:046D:B016.0001: unknown main item tag > > 0x0 > > [ 36.725860] input: Bluetooth Mouse M336/M337/M535 Mouse as > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > > [ 36.728036] input: Bluetooth Mouse M336/M337/M535 Consumer Control > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > > [ 36.728823] input: Bluetooth Mouse M336/M337/M535 Keyboard as > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > > [ 36.731550] hid-generic 0005:046D:B016.0001: input,hidraw0: > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > > 9c:b6:d0:96:8e:c8 > > [ 36.833039] logitech-hidpp-device 0005:046D:B016.0001: unknown > > main item tag 0x0 > > [ 36.999064] logitech-hidpp-device 0005:046D:B016.0001: Device not > > connected > > > > and here's what I get with it: > > > > [ 43.642546] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 > > [ 43.642559] Bluetooth: HIDP socket layer initialized > > [ 43.652898] hid-generic 0005:046D:B016.0001: unknown main item tag > > 0x0 > > [ 43.653833] input: Bluetooth Mouse M336/M337/M535 Mouse as > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > > [ 43.655025] input: Bluetooth Mouse M336/M337/M535 Consumer Control > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > > [ 43.655400] input: Bluetooth Mouse M336/M337/M535 Keyboard as > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > > [ 43.657521] hid-generic 0005:046D:B016.0001: input,hidraw0: > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > > 9c:b6:d0:96:8e:c8 > > > > The only difference seems to be that in the former case the logitech- > > hidpp > > driver tries to bind to the device, but I guess that is expected. > > There really shouldn't be that much difference between the 2 paths, > except that hid-logitech-hidpp.c will check that the device supports > HID++ in its report descriptors, and then start talking to it to check > whether it's connected. > > Maybe the device doesn't support HID++? Quite possibly. > Can you try running src/tools/hidpp-list-features from > https://github.com/cvuchener/hidpp on the hidraw device for the mouse? OK, I'll do that. > > However, > > when the device ID is added to unhandled_hidpp_devices[], the > > messages look > > exactly like in the "good" case, but the mouse still doesn't work. > > Given that this should be called without ever talking to the device, > that tells me that there might be a logic bug in the hid-core that uses > ->probe. Benjamin? I've explained what happens in this message: https://lore.kernel.org/lkml/CAJZ5v0jBo-_XnN2m0jeVdeTi7kjr6C3OSzc1NEJgav0srD0JGQ@mail.gmail.com/ and I've just posted patches that fix the issue for me. Cheers!
On Wed, Dec 7, 2022 at 10:16 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > On Wednesday, December 7, 2022 10:04:43 AM CET Bastien Nocera wrote: > > On Tue, 2022-12-06 at 15:58 +0100, Rafael J. Wysocki wrote: > > > Bastien, Jiri, > > > > > > Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all the > > > Logitech > > > Bluetooth devices") caused my Logitech Bluetooth mouse to become > > > unusable. > > > > > > Appended is the change I need to make it work again (note that adding > > > the > > > device ID to unhandled_hidpp_devices[] doesn't help, so there must be > > > some > > > significant enough difference in how the two cases are handled in the > > > stack). > > > > > > Here's what I get in the log without the patch below: > > > > > > [ 36.710574] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 > > > [ 36.710592] Bluetooth: HIDP socket layer initialized > > > [ 36.724644] hid-generic 0005:046D:B016.0001: unknown main item tag > > > 0x0 > > > [ 36.725860] input: Bluetooth Mouse M336/M337/M535 Mouse as > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > > > [ 36.728036] input: Bluetooth Mouse M336/M337/M535 Consumer Control > > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > > > [ 36.728823] input: Bluetooth Mouse M336/M337/M535 Keyboard as > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > > > [ 36.731550] hid-generic 0005:046D:B016.0001: input,hidraw0: > > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > > > 9c:b6:d0:96:8e:c8 > > > [ 36.833039] logitech-hidpp-device 0005:046D:B016.0001: unknown > > > main item tag 0x0 > > > [ 36.999064] logitech-hidpp-device 0005:046D:B016.0001: Device not > > > connected > > > > > > and here's what I get with it: > > > > > > [ 43.642546] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 > > > [ 43.642559] Bluetooth: HIDP socket layer initialized > > > [ 43.652898] hid-generic 0005:046D:B016.0001: unknown main item tag > > > 0x0 > > > [ 43.653833] input: Bluetooth Mouse M336/M337/M535 Mouse as > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > > > [ 43.655025] input: Bluetooth Mouse M336/M337/M535 Consumer Control > > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > > > [ 43.655400] input: Bluetooth Mouse M336/M337/M535 Keyboard as > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > > > [ 43.657521] hid-generic 0005:046D:B016.0001: input,hidraw0: > > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > > > 9c:b6:d0:96:8e:c8 > > > > > > The only difference seems to be that in the former case the logitech- > > > hidpp > > > driver tries to bind to the device, but I guess that is expected. > > > > There really shouldn't be that much difference between the 2 paths, > > except that hid-logitech-hidpp.c will check that the device supports > > HID++ in its report descriptors, and then start talking to it to check > > whether it's connected. > > > > Maybe the device doesn't support HID++? > > Quite possibly. > > > Can you try running src/tools/hidpp-list-features from > > https://github.com/cvuchener/hidpp on the hidraw device for the mouse? > > OK, I'll do that. Well, I would if I had a binary. Otherwise, I have cmake 3.17 which apparently is too old, sorry.
On Wed, 2022-12-07 at 10:36 +0100, Rafael J. Wysocki wrote: > On Wed, Dec 7, 2022 at 10:16 AM Rafael J. Wysocki <rjw@rjwysocki.net> > wrote: > > > > On Wednesday, December 7, 2022 10:04:43 AM CET Bastien Nocera > > wrote: > > > On Tue, 2022-12-06 at 15:58 +0100, Rafael J. Wysocki wrote: > > > > Bastien, Jiri, > > > > > > > > Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all > > > > the > > > > Logitech > > > > Bluetooth devices") caused my Logitech Bluetooth mouse to > > > > become > > > > unusable. > > > > > > > > Appended is the change I need to make it work again (note that > > > > adding > > > > the > > > > device ID to unhandled_hidpp_devices[] doesn't help, so there > > > > must be > > > > some > > > > significant enough difference in how the two cases are handled > > > > in the > > > > stack). > > > > > > > > Here's what I get in the log without the patch below: > > > > > > > > [ 36.710574] Bluetooth: HIDP (Human Interface Emulation) ver > > > > 1.2 > > > > [ 36.710592] Bluetooth: HIDP socket layer initialized > > > > [ 36.724644] hid-generic 0005:046D:B016.0001: unknown main > > > > item tag > > > > 0x0 > > > > [ 36.725860] input: Bluetooth Mouse M336/M337/M535 Mouse as > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > > > > [ 36.728036] input: Bluetooth Mouse M336/M337/M535 Consumer > > > > Control > > > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > > > > [ 36.728823] input: Bluetooth Mouse M336/M337/M535 Keyboard > > > > as > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > > > > [ 36.731550] hid-generic 0005:046D:B016.0001: input,hidraw0: > > > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > > > > 9c:b6:d0:96:8e:c8 > > > > [ 36.833039] logitech-hidpp-device 0005:046D:B016.0001: > > > > unknown > > > > main item tag 0x0 > > > > [ 36.999064] logitech-hidpp-device 0005:046D:B016.0001: > > > > Device not > > > > connected > > > > > > > > and here's what I get with it: > > > > > > > > [ 43.642546] Bluetooth: HIDP (Human Interface Emulation) ver > > > > 1.2 > > > > [ 43.642559] Bluetooth: HIDP socket layer initialized > > > > [ 43.652898] hid-generic 0005:046D:B016.0001: unknown main > > > > item tag > > > > 0x0 > > > > [ 43.653833] input: Bluetooth Mouse M336/M337/M535 Mouse as > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > > > > [ 43.655025] input: Bluetooth Mouse M336/M337/M535 Consumer > > > > Control > > > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > > > > [ 43.655400] input: Bluetooth Mouse M336/M337/M535 Keyboard > > > > as > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > > > > [ 43.657521] hid-generic 0005:046D:B016.0001: input,hidraw0: > > > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > > > > 9c:b6:d0:96:8e:c8 > > > > > > > > The only difference seems to be that in the former case the > > > > logitech- > > > > hidpp > > > > driver tries to bind to the device, but I guess that is > > > > expected. > > > > > > There really shouldn't be that much difference between the 2 > > > paths, > > > except that hid-logitech-hidpp.c will check that the device > > > supports > > > HID++ in its report descriptors, and then start talking to it to > > > check > > > whether it's connected. > > > > > > Maybe the device doesn't support HID++? > > > > Quite possibly. > > > > > Can you try running src/tools/hidpp-list-features from > > > https://github.com/cvuchener/hidpp on the hidraw device for the > > > mouse? > > > > OK, I'll do that. > > Well, I would if I had a binary. > > Otherwise, I have cmake 3.17 which apparently is too old, sorry. Revert 308f240585380dd0af4d9f5bbec5eb01e103deca and it will just require 3.12. Or use Solaar from your distribution or one of the prebuilt packages (https://github.com/pwr-Solaar/Solaar/#prebuilt-packages): solaar -D /dev/hidrawX show
On Wed, Dec 7, 2022 at 10:59 AM Bastien Nocera <hadess@hadess.net> wrote: > > On Wed, 2022-12-07 at 10:36 +0100, Rafael J. Wysocki wrote: > > On Wed, Dec 7, 2022 at 10:16 AM Rafael J. Wysocki <rjw@rjwysocki.net> > > wrote: > > > > > > On Wednesday, December 7, 2022 10:04:43 AM CET Bastien Nocera > > > wrote: > > > > On Tue, 2022-12-06 at 15:58 +0100, Rafael J. Wysocki wrote: > > > > > Bastien, Jiri, > > > > > > > > > > Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all > > > > > the > > > > > Logitech > > > > > Bluetooth devices") caused my Logitech Bluetooth mouse to > > > > > become > > > > > unusable. > > > > > > > > > > Appended is the change I need to make it work again (note that > > > > > adding > > > > > the > > > > > device ID to unhandled_hidpp_devices[] doesn't help, so there > > > > > must be > > > > > some > > > > > significant enough difference in how the two cases are handled > > > > > in the > > > > > stack). > > > > > > > > > > Here's what I get in the log without the patch below: > > > > > > > > > > [ 36.710574] Bluetooth: HIDP (Human Interface Emulation) ver > > > > > 1.2 > > > > > [ 36.710592] Bluetooth: HIDP socket layer initialized > > > > > [ 36.724644] hid-generic 0005:046D:B016.0001: unknown main > > > > > item tag > > > > > 0x0 > > > > > [ 36.725860] input: Bluetooth Mouse M336/M337/M535 Mouse as > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > > > > > [ 36.728036] input: Bluetooth Mouse M336/M337/M535 Consumer > > > > > Control > > > > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > > > > > [ 36.728823] input: Bluetooth Mouse M336/M337/M535 Keyboard > > > > > as > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > > > > > [ 36.731550] hid-generic 0005:046D:B016.0001: input,hidraw0: > > > > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > > > > > 9c:b6:d0:96:8e:c8 > > > > > [ 36.833039] logitech-hidpp-device 0005:046D:B016.0001: > > > > > unknown > > > > > main item tag 0x0 > > > > > [ 36.999064] logitech-hidpp-device 0005:046D:B016.0001: > > > > > Device not > > > > > connected > > > > > > > > > > and here's what I get with it: > > > > > > > > > > [ 43.642546] Bluetooth: HIDP (Human Interface Emulation) ver > > > > > 1.2 > > > > > [ 43.642559] Bluetooth: HIDP socket layer initialized > > > > > [ 43.652898] hid-generic 0005:046D:B016.0001: unknown main > > > > > item tag > > > > > 0x0 > > > > > [ 43.653833] input: Bluetooth Mouse M336/M337/M535 Mouse as > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 > > > > > [ 43.655025] input: Bluetooth Mouse M336/M337/M535 Consumer > > > > > Control > > > > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 > > > > > [ 43.655400] input: Bluetooth Mouse M336/M337/M535 Keyboard > > > > > as > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 > > > > > [ 43.657521] hid-generic 0005:046D:B016.0001: input,hidraw0: > > > > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on > > > > > 9c:b6:d0:96:8e:c8 > > > > > > > > > > The only difference seems to be that in the former case the > > > > > logitech- > > > > > hidpp > > > > > driver tries to bind to the device, but I guess that is > > > > > expected. > > > > > > > > There really shouldn't be that much difference between the 2 > > > > paths, > > > > except that hid-logitech-hidpp.c will check that the device > > > > supports > > > > HID++ in its report descriptors, and then start talking to it to > > > > check > > > > whether it's connected. > > > > > > > > Maybe the device doesn't support HID++? > > > > > > Quite possibly. > > > > > > > Can you try running src/tools/hidpp-list-features from > > > > https://github.com/cvuchener/hidpp on the hidraw device for the > > > > mouse? > > > > > > OK, I'll do that. > > > > Well, I would if I had a binary. > > > > Otherwise, I have cmake 3.17 which apparently is too old, sorry. > > Revert 308f240585380dd0af4d9f5bbec5eb01e103deca and it will just > require 3.12. OK It says: /dev/hidraw0 (device 0): Bluetooth Mouse M336/M337/M535 (046d:b016) HID++ 4.5 > Or use Solaar from your distribution or one of the prebuilt packages > (https://github.com/pwr-Solaar/Solaar/#prebuilt-packages): > solaar -D /dev/hidrawX show
On Wed, 2022-12-07 at 11:07 +0100, Rafael J. Wysocki wrote: > On Wed, Dec 7, 2022 at 10:59 AM Bastien Nocera <hadess@hadess.net> > wrote: > > > > On Wed, 2022-12-07 at 10:36 +0100, Rafael J. Wysocki wrote: > > > On Wed, Dec 7, 2022 at 10:16 AM Rafael J. Wysocki > > > <rjw@rjwysocki.net> > > > wrote: > > > > > > > > On Wednesday, December 7, 2022 10:04:43 AM CET Bastien Nocera > > > > wrote: > > > > > On Tue, 2022-12-06 at 15:58 +0100, Rafael J. Wysocki wrote: > > > > > > Bastien, Jiri, > > > > > > > > > > > > Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for > > > > > > all > > > > > > the > > > > > > Logitech > > > > > > Bluetooth devices") caused my Logitech Bluetooth mouse to > > > > > > become > > > > > > unusable. > > > > > > > > > > > > Appended is the change I need to make it work again (note > > > > > > that > > > > > > adding > > > > > > the > > > > > > device ID to unhandled_hidpp_devices[] doesn't help, so > > > > > > there > > > > > > must be > > > > > > some > > > > > > significant enough difference in how the two cases are > > > > > > handled > > > > > > in the > > > > > > stack). > > > > > > > > > > > > Here's what I get in the log without the patch below: > > > > > > > > > > > > [ 36.710574] Bluetooth: HIDP (Human Interface Emulation) > > > > > > ver > > > > > > 1.2 > > > > > > [ 36.710592] Bluetooth: HIDP socket layer initialized > > > > > > [ 36.724644] hid-generic 0005:046D:B016.0001: unknown > > > > > > main > > > > > > item tag > > > > > > 0x0 > > > > > > [ 36.725860] input: Bluetooth Mouse M336/M337/M535 Mouse > > > > > > as > > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > 14 > > > > > > [ 36.728036] input: Bluetooth Mouse M336/M337/M535 > > > > > > Consumer > > > > > > Control > > > > > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > 15 > > > > > > [ 36.728823] input: Bluetooth Mouse M336/M337/M535 > > > > > > Keyboard > > > > > > as > > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > 18 > > > > > > [ 36.731550] hid-generic 0005:046D:B016.0001: > > > > > > input,hidraw0: > > > > > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] > > > > > > on > > > > > > 9c:b6:d0:96:8e:c8 > > > > > > [ 36.833039] logitech-hidpp-device 0005:046D:B016.0001: > > > > > > unknown > > > > > > main item tag 0x0 > > > > > > [ 36.999064] logitech-hidpp-device 0005:046D:B016.0001: > > > > > > Device not > > > > > > connected > > > > > > > > > > > > and here's what I get with it: > > > > > > > > > > > > [ 43.642546] Bluetooth: HIDP (Human Interface Emulation) > > > > > > ver > > > > > > 1.2 > > > > > > [ 43.642559] Bluetooth: HIDP socket layer initialized > > > > > > [ 43.652898] hid-generic 0005:046D:B016.0001: unknown > > > > > > main > > > > > > item tag > > > > > > 0x0 > > > > > > [ 43.653833] input: Bluetooth Mouse M336/M337/M535 Mouse > > > > > > as > > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > 14 > > > > > > [ 43.655025] input: Bluetooth Mouse M336/M337/M535 > > > > > > Consumer > > > > > > Control > > > > > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > 15 > > > > > > [ 43.655400] input: Bluetooth Mouse M336/M337/M535 > > > > > > Keyboard > > > > > > as > > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > 18 > > > > > > [ 43.657521] hid-generic 0005:046D:B016.0001: > > > > > > input,hidraw0: > > > > > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] > > > > > > on > > > > > > 9c:b6:d0:96:8e:c8 > > > > > > > > > > > > The only difference seems to be that in the former case the > > > > > > logitech- > > > > > > hidpp > > > > > > driver tries to bind to the device, but I guess that is > > > > > > expected. > > > > > > > > > > There really shouldn't be that much difference between the 2 > > > > > paths, > > > > > except that hid-logitech-hidpp.c will check that the device > > > > > supports > > > > > HID++ in its report descriptors, and then start talking to it > > > > > to > > > > > check > > > > > whether it's connected. > > > > > > > > > > Maybe the device doesn't support HID++? > > > > > > > > Quite possibly. > > > > > > > > > Can you try running src/tools/hidpp-list-features from > > > > > https://github.com/cvuchener/hidpp on the hidraw device for > > > > > the > > > > > mouse? > > > > > > > > OK, I'll do that. > > > > > > Well, I would if I had a binary. > > > > > > Otherwise, I have cmake 3.17 which apparently is too old, sorry. > > > > Revert 308f240585380dd0af4d9f5bbec5eb01e103deca and it will just > > require 3.12. > > OK > > It says: > > /dev/hidraw0 (device 0): Bluetooth Mouse M336/M337/M535 (046d:b016) > HID++ 4.5 This is hidpp-list-devices, not hidpp-list-features. Which of the 3 models above is it? For comparison, this is what happens on my (newer Bluetooth LE/Bolt mouse): $ sudo ./_build/src/tools/hidpp-list-features /dev/hidraw5 Logitech Signature M650 Mouse (046d:b02a) is a HID++ 4.5 device Feature 0x01: [0x0001] Feature set Feature 0x02: [0x0003] Device FW version Feature 0x03: [0x0005] Device name Feature 0x04: [0x1d4b] Wireless device status Feature 0x05: [0x0020] Reset Feature 0x06: [0x0007] Device Friendly Name Feature 0x07: [0x1004] ? Feature 0x08: [0x1b04] Reprog controls v4 Feature 0x09: [0x1815] Hosts info Feature 0x0a: [0x2250] ? Feature 0x0b: [0x2130] Low-res wheel Feature 0x0c: [0x2201] Adjustable dpi Feature 0x0d: [0x00c3] ? Feature 0x0e: [0x1802] Device reset (hidden, internal) Feature 0x0f: [0x1803] ? (hidden, internal) Feature 0x10: [0x1806] Configurable device properties (hidden, internal) Feature 0x11: [0x1816] ? (hidden, internal) Feature 0x12: [0x1805] OOBState (hidden, internal) Feature 0x13: [0x1830] ? (hidden, internal) Feature 0x14: [0x1891] ? (hidden, internal) Feature 0x15: [0x18a1] ? (hidden, internal) Feature 0x16: [0x1e00] Enable hidden features (hidden) Feature 0x17: [0x1e02] ? (hidden, internal) Feature 0x18: [0x1e22] ? (hidden, internal) Feature 0x19: [0x1602] ? Feature 0x1a: [0x1eb0] ? (hidden, internal) Feature 0x1b: [0x1861] ? (hidden, internal) Feature 0x1c: [0x18b1] ? (hidden, internal) Feature 0x1d: [0x920a] ? (hidden, internal)
On Wed, Dec 7, 2022 at 11:51 AM Bastien Nocera <hadess@hadess.net> wrote: > > On Wed, 2022-12-07 at 11:07 +0100, Rafael J. Wysocki wrote: > > On Wed, Dec 7, 2022 at 10:59 AM Bastien Nocera <hadess@hadess.net> > > wrote: > > > > > > On Wed, 2022-12-07 at 10:36 +0100, Rafael J. Wysocki wrote: > > > > On Wed, Dec 7, 2022 at 10:16 AM Rafael J. Wysocki > > > > <rjw@rjwysocki.net> > > > > wrote: > > > > > > > > > > On Wednesday, December 7, 2022 10:04:43 AM CET Bastien Nocera > > > > > wrote: > > > > > > On Tue, 2022-12-06 at 15:58 +0100, Rafael J. Wysocki wrote: > > > > > > > Bastien, Jiri, > > > > > > > > > > > > > > Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for > > > > > > > all > > > > > > > the > > > > > > > Logitech > > > > > > > Bluetooth devices") caused my Logitech Bluetooth mouse to > > > > > > > become > > > > > > > unusable. > > > > > > > > > > > > > > Appended is the change I need to make it work again (note > > > > > > > that > > > > > > > adding > > > > > > > the > > > > > > > device ID to unhandled_hidpp_devices[] doesn't help, so > > > > > > > there > > > > > > > must be > > > > > > > some > > > > > > > significant enough difference in how the two cases are > > > > > > > handled > > > > > > > in the > > > > > > > stack). > > > > > > > > > > > > > > Here's what I get in the log without the patch below: > > > > > > > > > > > > > > [ 36.710574] Bluetooth: HIDP (Human Interface Emulation) > > > > > > > ver > > > > > > > 1.2 > > > > > > > [ 36.710592] Bluetooth: HIDP socket layer initialized > > > > > > > [ 36.724644] hid-generic 0005:046D:B016.0001: unknown > > > > > > > main > > > > > > > item tag > > > > > > > 0x0 > > > > > > > [ 36.725860] input: Bluetooth Mouse M336/M337/M535 Mouse > > > > > > > as > > > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > > 14 > > > > > > > [ 36.728036] input: Bluetooth Mouse M336/M337/M535 > > > > > > > Consumer > > > > > > > Control > > > > > > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > > 15 > > > > > > > [ 36.728823] input: Bluetooth Mouse M336/M337/M535 > > > > > > > Keyboard > > > > > > > as > > > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > > 18 > > > > > > > [ 36.731550] hid-generic 0005:046D:B016.0001: > > > > > > > input,hidraw0: > > > > > > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] > > > > > > > on > > > > > > > 9c:b6:d0:96:8e:c8 > > > > > > > [ 36.833039] logitech-hidpp-device 0005:046D:B016.0001: > > > > > > > unknown > > > > > > > main item tag 0x0 > > > > > > > [ 36.999064] logitech-hidpp-device 0005:046D:B016.0001: > > > > > > > Device not > > > > > > > connected > > > > > > > > > > > > > > and here's what I get with it: > > > > > > > > > > > > > > [ 43.642546] Bluetooth: HIDP (Human Interface Emulation) > > > > > > > ver > > > > > > > 1.2 > > > > > > > [ 43.642559] Bluetooth: HIDP socket layer initialized > > > > > > > [ 43.652898] hid-generic 0005:046D:B016.0001: unknown > > > > > > > main > > > > > > > item tag > > > > > > > 0x0 > > > > > > > [ 43.653833] input: Bluetooth Mouse M336/M337/M535 Mouse > > > > > > > as > > > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > > 14 > > > > > > > [ 43.655025] input: Bluetooth Mouse M336/M337/M535 > > > > > > > Consumer > > > > > > > Control > > > > > > > as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > > 15 > > > > > > > [ 43.655400] input: Bluetooth Mouse M336/M337/M535 > > > > > > > Keyboard > > > > > > > as > > > > > > > /devices/pci0000:00/0000:00:14.0/usb1/1-7/1- > > > > > > > 7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input > > > > > > > 18 > > > > > > > [ 43.657521] hid-generic 0005:046D:B016.0001: > > > > > > > input,hidraw0: > > > > > > > BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] > > > > > > > on > > > > > > > 9c:b6:d0:96:8e:c8 > > > > > > > > > > > > > > The only difference seems to be that in the former case the > > > > > > > logitech- > > > > > > > hidpp > > > > > > > driver tries to bind to the device, but I guess that is > > > > > > > expected. > > > > > > > > > > > > There really shouldn't be that much difference between the 2 > > > > > > paths, > > > > > > except that hid-logitech-hidpp.c will check that the device > > > > > > supports > > > > > > HID++ in its report descriptors, and then start talking to it > > > > > > to > > > > > > check > > > > > > whether it's connected. > > > > > > > > > > > > Maybe the device doesn't support HID++? > > > > > > > > > > Quite possibly. > > > > > > > > > > > Can you try running src/tools/hidpp-list-features from > > > > > > https://github.com/cvuchener/hidpp on the hidraw device for > > > > > > the > > > > > > mouse? > > > > > > > > > > OK, I'll do that. > > > > > > > > Well, I would if I had a binary. > > > > > > > > Otherwise, I have cmake 3.17 which apparently is too old, sorry. > > > > > > Revert 308f240585380dd0af4d9f5bbec5eb01e103deca and it will just > > > require 3.12. > > > > OK > > > > It says: > > > > /dev/hidraw0 (device 0): Bluetooth Mouse M336/M337/M535 (046d:b016) > > HID++ 4.5 > > This is hidpp-list-devices, not hidpp-list-features. Ah, sorry. > Which of the 3 models above is it? I have no idea. > For comparison, this is what happens on my (newer Bluetooth LE/Bolt > mouse): > $ sudo ./_build/src/tools/hidpp-list-features /dev/hidraw5 > Logitech Signature M650 Mouse (046d:b02a) is a HID++ 4.5 device > Feature 0x01: [0x0001] Feature set > Feature 0x02: [0x0003] Device FW version > Feature 0x03: [0x0005] Device name > Feature 0x04: [0x1d4b] Wireless device status > Feature 0x05: [0x0020] Reset > Feature 0x06: [0x0007] Device Friendly Name > Feature 0x07: [0x1004] ? > Feature 0x08: [0x1b04] Reprog controls v4 > Feature 0x09: [0x1815] Hosts info > Feature 0x0a: [0x2250] ? > Feature 0x0b: [0x2130] Low-res wheel > Feature 0x0c: [0x2201] Adjustable dpi > Feature 0x0d: [0x00c3] ? > Feature 0x0e: [0x1802] Device reset (hidden, internal) > Feature 0x0f: [0x1803] ? (hidden, internal) > Feature 0x10: [0x1806] Configurable device properties (hidden, > internal) > Feature 0x11: [0x1816] ? (hidden, internal) > Feature 0x12: [0x1805] OOBState (hidden, internal) > Feature 0x13: [0x1830] ? (hidden, internal) > Feature 0x14: [0x1891] ? (hidden, internal) > Feature 0x15: [0x18a1] ? (hidden, internal) > Feature 0x16: [0x1e00] Enable hidden features (hidden) > Feature 0x17: [0x1e02] ? (hidden, internal) > Feature 0x18: [0x1e22] ? (hidden, internal) > Feature 0x19: [0x1602] ? > Feature 0x1a: [0x1eb0] ? (hidden, internal) > Feature 0x1b: [0x1861] ? (hidden, internal) > Feature 0x1c: [0x18b1] ? (hidden, internal) > Feature 0x1d: [0x920a] ? (hidden, internal) # hidpp-list-features /dev/hidraw1 Bluetooth Mouse M336/M337/M535 (046d:b016) is a HID++ 4.5 device Feature 0x01: [0x0001] Feature set Feature 0x02: [0x0003] Device FW version Feature 0x03: [0x0005] Device name Feature 0x04: [0x0020] Reset Feature 0x05: [0x1e00] Enable hidden features (hidden) Feature 0x06: [0x1800] Generic Test (hidden, internal) Feature 0x07: [0x1000] Battery status Feature 0x08: [0x1b04] Reprog controls v4 Feature 0x09: [0x2100] Vertical scrolling Feature 0x0a: [0x2200] Mouse pointer Feature 0x0b: [0x2205] Pointer speed Feature 0x0c: [0x18b1] ? (hidden, internal) Feature 0x0d: [0x2121] Hi-res wheel Feature 0x0e: [0x1f03] ? (hidden, internal)
On Wed, 2022-12-07 at 12:07 +0100, Rafael J. Wysocki wrote: > # hidpp-list-features /dev/hidraw1 > Bluetooth Mouse M336/M337/M535 (046d:b016) is a HID++ 4.5 device > Feature 0x01: [0x0001] Feature set > Feature 0x02: [0x0003] Device FW version > Feature 0x03: [0x0005] Device name > Feature 0x04: [0x0020] Reset > Feature 0x05: [0x1e00] Enable hidden features (hidden) > Feature 0x06: [0x1800] Generic Test (hidden, internal) > Feature 0x07: [0x1000] Battery status > Feature 0x08: [0x1b04] Reprog controls v4 > Feature 0x09: [0x2100] Vertical scrolling > Feature 0x0a: [0x2200] Mouse pointer > Feature 0x0b: [0x2205] Pointer speed > Feature 0x0c: [0x18b1] ? (hidden, internal) > Feature 0x0d: [0x2121] Hi-res wheel > Feature 0x0e: [0x1f03] ? (hidden, internal) Would you be able to enable debugging for the hid subsystem to get some debug data when getting the version from the device fails? I can't see any problems in there that wouldn't also have impacted all the other Logitech Bluetooth devices listed in the support devices list. If the problem is a timeout, maybe we should lower the timeouts we currently have (5*HZ = 5 seconds, right?), so we can retry 5 times one second instead. Still, as I mentioned earlier, I can't reproduce the problem on another Bluetooth Classic device...
On Wed, Dec 7, 2022 at 6:19 PM Bastien Nocera <hadess@hadess.net> wrote: > > On Wed, 2022-12-07 at 12:07 +0100, Rafael J. Wysocki wrote: > > # hidpp-list-features /dev/hidraw1 > > Bluetooth Mouse M336/M337/M535 (046d:b016) is a HID++ 4.5 device > > Feature 0x01: [0x0001] Feature set > > Feature 0x02: [0x0003] Device FW version > > Feature 0x03: [0x0005] Device name > > Feature 0x04: [0x0020] Reset > > Feature 0x05: [0x1e00] Enable hidden features (hidden) > > Feature 0x06: [0x1800] Generic Test (hidden, internal) > > Feature 0x07: [0x1000] Battery status > > Feature 0x08: [0x1b04] Reprog controls v4 > > Feature 0x09: [0x2100] Vertical scrolling > > Feature 0x0a: [0x2200] Mouse pointer > > Feature 0x0b: [0x2205] Pointer speed > > Feature 0x0c: [0x18b1] ? (hidden, internal) > > Feature 0x0d: [0x2121] Hi-res wheel > > Feature 0x0e: [0x1f03] ? (hidden, internal) > > Would you be able to enable debugging for the hid subsystem to get some > debug data when getting the version from the device fails? I guess I could, but I think that the device is just quirky. At least the BT layer appears to think that it is connected. Anyway, what exactly do you need? > I can't see any problems in there that wouldn't also have impacted all > the other Logitech Bluetooth devices listed in the support devices > list. > > If the problem is a timeout, maybe we should lower the timeouts we > currently have (5*HZ = 5 seconds, right?), so we can retry 5 times one > second instead. No, it doesn't take 5 sec to get a response from it. It rather looks like __hidpp_send_report() returns an error. > > Still, as I mentioned earlier, I can't reproduce the problem on another > Bluetooth Classic device...
[Note: this mail contains only information for Linux kernel regression tracking. Mails like these contain '#forregzbot' in the subject to make then easy to spot and filter out. The author also tried to remove most or all individuals from the list of recipients to spare them the hassle.] On 06.12.22 15:58, Rafael J. Wysocki wrote: > > Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all the Logitech > Bluetooth devices") caused my Logitech Bluetooth mouse to become unusable. > [...] Thanks for the report. To be sure below issue doesn't fall through the cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking bot: #regzbot ^introduced 532223c8ac57 #regzbot title hid: Logitech BT mouse unusable #regzbot monitor: https://lore.kernel.org/all/20221207142433.1158329-1-benjamin.tissoires@redhat.com/ #regzbot ignore-activity Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.
On Wed, 2022-12-07 at 18:44 +0100, Rafael J. Wysocki wrote: > On Wed, Dec 7, 2022 at 6:19 PM Bastien Nocera <hadess@hadess.net> > wrote: > > > > On Wed, 2022-12-07 at 12:07 +0100, Rafael J. Wysocki wrote: > > > # hidpp-list-features /dev/hidraw1 > > > Bluetooth Mouse M336/M337/M535 (046d:b016) is a HID++ 4.5 device > > > Feature 0x01: [0x0001] Feature set > > > Feature 0x02: [0x0003] Device FW version > > > Feature 0x03: [0x0005] Device name > > > Feature 0x04: [0x0020] Reset > > > Feature 0x05: [0x1e00] Enable hidden features (hidden) > > > Feature 0x06: [0x1800] Generic Test (hidden, internal) > > > Feature 0x07: [0x1000] Battery status > > > Feature 0x08: [0x1b04] Reprog controls v4 > > > Feature 0x09: [0x2100] Vertical scrolling > > > Feature 0x0a: [0x2200] Mouse pointer > > > Feature 0x0b: [0x2205] Pointer speed > > > Feature 0x0c: [0x18b1] ? (hidden, internal) > > > Feature 0x0d: [0x2121] Hi-res wheel > > > Feature 0x0e: [0x1f03] ? (hidden, internal) > > > > Would you be able to enable debugging for the hid subsystem to get > > some > > debug data when getting the version from the device fails? > > I guess I could, but I think that the device is just quirky. > > At least the BT layer appears to think that it is connected. > > Anyway, what exactly do you need? > > > I can't see any problems in there that wouldn't also have impacted > > all > > the other Logitech Bluetooth devices listed in the support devices > > list. > > > > If the problem is a timeout, maybe we should lower the timeouts we > > currently have (5*HZ = 5 seconds, right?), so we can retry 5 times > > one > > second instead. > > No, it doesn't take 5 sec to get a response from it. It rather looks > like __hidpp_send_report() returns an error. Adding "debug" on the kernel command-line should be enough to get debug out of hidpp_send_message_sync(): https://stackoverflow.com/a/63682160 Either that or turn all the dbg_hid() into hid_err() if you're going to be compiling the kernel. We're mainly interested in the error code from the device, as that's what I'm guessing is caused the error to propagate. > > Still, as I mentioned earlier, I can't reproduce the problem on > > another > > Bluetooth Classic device...
On 08.12.22 08:03, Thorsten Leemhuis wrote: > [Note: this mail contains only information for Linux kernel regression > tracking. Mails like these contain '#forregzbot' in the subject to make > then easy to spot and filter out. The author also tried to remove most > or all individuals from the list of recipients to spare them the hassle.] > > On 06.12.22 15:58, Rafael J. Wysocki wrote: >> >> Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all the Logitech >> Bluetooth devices") caused my Logitech Bluetooth mouse to become unusable. >> [...] > > Thanks for the report. To be sure below issue doesn't fall through the > cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression > tracking bot: > > #regzbot ^introduced 532223c8ac57 > #regzbot title hid: Logitech BT mouse unusable > #regzbot monitor: > https://lore.kernel.org/all/20221207142433.1158329-1-benjamin.tissoires@redhat.com/ > #regzbot ignore-activity #regzbot fix: a9d9e46c755a1
On Thu, 2022-12-08 at 16:20 +0100, Bastien Nocera wrote: > On Wed, 2022-12-07 at 18:44 +0100, Rafael J. Wysocki wrote: > > On Wed, Dec 7, 2022 at 6:19 PM Bastien Nocera <hadess@hadess.net> > > wrote: > > > > > > On Wed, 2022-12-07 at 12:07 +0100, Rafael J. Wysocki wrote: > > > > # hidpp-list-features /dev/hidraw1 > > > > Bluetooth Mouse M336/M337/M535 (046d:b016) is a HID++ 4.5 > > > > device > > > > Feature 0x01: [0x0001] Feature set > > > > Feature 0x02: [0x0003] Device FW version > > > > Feature 0x03: [0x0005] Device name > > > > Feature 0x04: [0x0020] Reset > > > > Feature 0x05: [0x1e00] Enable hidden features (hidden) > > > > Feature 0x06: [0x1800] Generic Test (hidden, internal) > > > > Feature 0x07: [0x1000] Battery status > > > > Feature 0x08: [0x1b04] Reprog controls v4 > > > > Feature 0x09: [0x2100] Vertical scrolling > > > > Feature 0x0a: [0x2200] Mouse pointer > > > > Feature 0x0b: [0x2205] Pointer speed > > > > Feature 0x0c: [0x18b1] ? (hidden, internal) > > > > Feature 0x0d: [0x2121] Hi-res wheel > > > > Feature 0x0e: [0x1f03] ? (hidden, internal) > > > > > > Would you be able to enable debugging for the hid subsystem to > > > get > > > some > > > debug data when getting the version from the device fails? > > > > I guess I could, but I think that the device is just quirky. > > > > At least the BT layer appears to think that it is connected. > > > > Anyway, what exactly do you need? > > > > > I can't see any problems in there that wouldn't also have > > > impacted > > > all > > > the other Logitech Bluetooth devices listed in the support > > > devices > > > list. > > > > > > If the problem is a timeout, maybe we should lower the timeouts > > > we > > > currently have (5*HZ = 5 seconds, right?), so we can retry 5 > > > times > > > one > > > second instead. > > > > No, it doesn't take 5 sec to get a response from it. It rather > > looks > > like __hidpp_send_report() returns an error. > > Adding "debug" on the kernel command-line should be enough to get > debug > out of hidpp_send_message_sync(): > https://stackoverflow.com/a/63682160 > > Either that or turn all the dbg_hid() into hid_err() if you're going > to > be compiling the kernel. > > We're mainly interested in the error code from the device, as that's > what I'm guessing is caused the error to propagate. Can you also check whether you had: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?id=8b7e58409b1813c58eea542d9f3b8db35b4ac1f7 in your git tree? Would be great to know whether that commit helps at all. Cheers > > > Still, as I mentioned earlier, I can't reproduce the problem on > > > another > > > Bluetooth Classic device... >
On Tue, Dec 13, 2022 at 5:14 PM Bastien Nocera <hadess@hadess.net> wrote: > > On Thu, 2022-12-08 at 16:20 +0100, Bastien Nocera wrote: > > On Wed, 2022-12-07 at 18:44 +0100, Rafael J. Wysocki wrote: > > > On Wed, Dec 7, 2022 at 6:19 PM Bastien Nocera <hadess@hadess.net> > > > wrote: > > > > > > > > On Wed, 2022-12-07 at 12:07 +0100, Rafael J. Wysocki wrote: > > > > > # hidpp-list-features /dev/hidraw1 > > > > > Bluetooth Mouse M336/M337/M535 (046d:b016) is a HID++ 4.5 > > > > > device > > > > > Feature 0x01: [0x0001] Feature set > > > > > Feature 0x02: [0x0003] Device FW version > > > > > Feature 0x03: [0x0005] Device name > > > > > Feature 0x04: [0x0020] Reset > > > > > Feature 0x05: [0x1e00] Enable hidden features (hidden) > > > > > Feature 0x06: [0x1800] Generic Test (hidden, internal) > > > > > Feature 0x07: [0x1000] Battery status > > > > > Feature 0x08: [0x1b04] Reprog controls v4 > > > > > Feature 0x09: [0x2100] Vertical scrolling > > > > > Feature 0x0a: [0x2200] Mouse pointer > > > > > Feature 0x0b: [0x2205] Pointer speed > > > > > Feature 0x0c: [0x18b1] ? (hidden, internal) > > > > > Feature 0x0d: [0x2121] Hi-res wheel > > > > > Feature 0x0e: [0x1f03] ? (hidden, internal) > > > > > > > > Would you be able to enable debugging for the hid subsystem to > > > > get > > > > some > > > > debug data when getting the version from the device fails? > > > > > > I guess I could, but I think that the device is just quirky. > > > > > > At least the BT layer appears to think that it is connected. > > > > > > Anyway, what exactly do you need? > > > > > > > I can't see any problems in there that wouldn't also have > > > > impacted > > > > all > > > > the other Logitech Bluetooth devices listed in the support > > > > devices > > > > list. > > > > > > > > If the problem is a timeout, maybe we should lower the timeouts > > > > we > > > > currently have (5*HZ = 5 seconds, right?), so we can retry 5 > > > > times > > > > one > > > > second instead. > > > > > > No, it doesn't take 5 sec to get a response from it. It rather > > > looks > > > like __hidpp_send_report() returns an error. > > > > Adding "debug" on the kernel command-line should be enough to get > > debug > > out of hidpp_send_message_sync(): > > https://stackoverflow.com/a/63682160 > > > > Either that or turn all the dbg_hid() into hid_err() if you're going > > to > > be compiling the kernel. > > > > We're mainly interested in the error code from the device, as that's > > what I'm guessing is caused the error to propagate. > > Can you also check whether you had: > https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?id=8b7e58409b1813c58eea542d9f3b8db35b4ac1f7 > in your git tree? > > Would be great to know whether that commit helps at all. No, it's not present in the kernels I've tested so far.
Index: linux-pm/drivers/hid/hid-logitech-hidpp.c =================================================================== --- linux-pm.orig/drivers/hid/hid-logitech-hidpp.c +++ linux-pm/drivers/hid/hid-logitech-hidpp.c @@ -4367,9 +4367,6 @@ static const struct hid_device_id hidpp_ { /* MX5500 keyboard over Bluetooth */ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb30b), .driver_data = HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS }, - - { /* And try to enable HID++ for all the Logitech Bluetooth devices */ - HID_DEVICE(BUS_BLUETOOTH, HID_GROUP_ANY, USB_VENDOR_ID_LOGITECH, HID_ANY_ID) }, {} };
Bastien, Jiri, Commit 532223c8ac57 ("HID: logitech-hidpp: Enable HID++ for all the Logitech Bluetooth devices") caused my Logitech Bluetooth mouse to become unusable. Appended is the change I need to make it work again (note that adding the device ID to unhandled_hidpp_devices[] doesn't help, so there must be some significant enough difference in how the two cases are handled in the stack). Here's what I get in the log without the patch below: [ 36.710574] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 [ 36.710592] Bluetooth: HIDP socket layer initialized [ 36.724644] hid-generic 0005:046D:B016.0001: unknown main item tag 0x0 [ 36.725860] input: Bluetooth Mouse M336/M337/M535 Mouse as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 [ 36.728036] input: Bluetooth Mouse M336/M337/M535 Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 [ 36.728823] input: Bluetooth Mouse M336/M337/M535 Keyboard as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 [ 36.731550] hid-generic 0005:046D:B016.0001: input,hidraw0: BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on 9c:b6:d0:96:8e:c8 [ 36.833039] logitech-hidpp-device 0005:046D:B016.0001: unknown main item tag 0x0 [ 36.999064] logitech-hidpp-device 0005:046D:B016.0001: Device not connected and here's what I get with it: [ 43.642546] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 [ 43.642559] Bluetooth: HIDP socket layer initialized [ 43.652898] hid-generic 0005:046D:B016.0001: unknown main item tag 0x0 [ 43.653833] input: Bluetooth Mouse M336/M337/M535 Mouse as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input14 [ 43.655025] input: Bluetooth Mouse M336/M337/M535 Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input15 [ 43.655400] input: Bluetooth Mouse M336/M337/M535 Keyboard as /devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/bluetooth/hci0/hci0:1/0005:046D:B016.0001/input/input18 [ 43.657521] hid-generic 0005:046D:B016.0001: input,hidraw0: BLUETOOTH HID v12.03 Mouse [Bluetooth Mouse M336/M337/M535] on 9c:b6:d0:96:8e:c8 The only difference seems to be that in the former case the logitech-hidpp driver tries to bind to the device, but I guess that is expected. However, when the device ID is added to unhandled_hidpp_devices[], the messages look exactly like in the "good" case, but the mouse still doesn't work. Thanks, Rafael --- drivers/hid/hid-logitech-hidpp.c | 3 --- 1 file changed, 3 deletions(-)