| Message ID | 20221129012923.111691-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] staging: media: Remove surplus dev_err() when using platform_get_irq() | expand |
Dne torek, 29. november 2022 ob 02:29:23 CET je Yang Li napisal(a): > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:390:2-9: line 390 is > redundant because platform_get_irq() already prints an error > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3274 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej
Hi, On Tue 29 Nov 22, 09:29, Yang Li wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:390:2-9: line 390 is redundant because platform_get_irq() already prints an error > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3274 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Thanks for the fix! Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Paul > --- > drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c > index 7b7947509b69..a6e813ff413a 100644 > --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c > +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c > @@ -387,7 +387,6 @@ static int sun6i_isp_resources_setup(struct sun6i_isp_device *isp_dev, > > irq = platform_get_irq(platform_dev, 0); > if (irq < 0) { > - dev_err(dev, "failed to get interrupt\n"); > ret = -ENXIO; > goto error_clock_rate_exclusive; > } > -- > 2.20.1.7.g153144c >
diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c index 7b7947509b69..a6e813ff413a 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c @@ -387,7 +387,6 @@ static int sun6i_isp_resources_setup(struct sun6i_isp_device *isp_dev, irq = platform_get_irq(platform_dev, 0); if (irq < 0) { - dev_err(dev, "failed to get interrupt\n"); ret = -ENXIO; goto error_clock_rate_exclusive; }
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. ./drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:390:2-9: line 390 is redundant because platform_get_irq() already prints an error Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3274 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c | 1 - 1 file changed, 1 deletion(-)