| Message ID | 20221209010314.707606-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f8670f9aa0a0c60f0d6f246a0eaaa932747140ed |
| Headers | show |
| Series | [BlueZ,1/5] shared/att: Fix not requeueing in the same channel | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=703146
---Test result---
Test Summary:
CheckPatch FAIL 2.52 seconds
GitLint PASS 1.41 seconds
BuildEll PASS 27.40 seconds
BluezMake PASS 1009.44 seconds
MakeCheck PASS 11.49 seconds
MakeDistcheck PASS 149.64 seconds
CheckValgrind PASS 248.26 seconds
bluezmakeextell PASS 97.45 seconds
IncrementalBuild PASS 4456.90 seconds
ScanBuild PASS 1048.52 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,3/5] shared/bap: Read PAC Sink/Source if respective location is found
WARNING:TYPO_SPELLING: 'occured' may be misspelled - perhaps 'occurred'?
#86:
means an error must have occured so this attempt to read the records
^^^^^^^
/github/workspace/src/src/13069110.patch total: 0 errors, 1 warnings, 158 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13069110.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 8 Dec 2022 17:03:10 -0800 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > If request needs to be resend due to change in the security use the > chan->queue otherwise it may end up using a different channel. > --- > src/shared/att.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [BlueZ,1/5] shared/att: Fix not requeueing in the same channel https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f8670f9aa0a0 - [BlueZ,2/5] shared/bap: Log error message if request cannot be sent https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6b5b51392312 - [BlueZ,3/5] shared/bap: Read PAC Sink/Source if respective location is found (no matching commit) - [BlueZ,4/5] shared/gatt-db: Allow passing NULL to gatt_db_attribute_write https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=be9fc9222c03 - [BlueZ,5/5] shared/bap: Make bt_bap_pac_register to be per session (no matching commit) You are awesome, thank you!
diff --git a/src/shared/att.c b/src/shared/att.c index f7bef08bc169..b90af93ccbf8 100644 --- a/src/shared/att.c +++ b/src/shared/att.c @@ -799,8 +799,8 @@ static bool handle_error_rsp(struct bt_att_chan *chan, uint8_t *pdu, chan->pending_req = NULL; - /* Push operation back to request queue */ - return queue_push_head(att->req_queue, op); + /* Push operation back to channel queue */ + return queue_push_head(chan->queue, op); } static void handle_rsp(struct bt_att_chan *chan, uint8_t opcode, uint8_t *pdu,
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> If request needs to be resend due to change in the security use the chan->queue otherwise it may end up using a different channel. --- src/shared/att.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)