| Message ID | 20221209152343.180139-1-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: bridge: Add Samsung MIPI DSIM bridge | expand |
On 12/9/22 16:23, Jagan Teki wrote: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. I wonder if it would rather make sense to split the series up and submit all the various partial fixes and additions separately, instead of piling them up in this series and ever growing the series. It seems to me 3..5 and 7..14 can just go in before the rest.
On Sun, Dec 11, 2022 at 7:58 AM Marek Vasut <marex@denx.de> wrote: > > On 12/9/22 16:23, Jagan Teki wrote: > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > > > > The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. > > I wonder if it would rather make sense to split the series up and submit > all the various partial fixes and additions separately, instead of > piling them up in this series and ever growing the series. > > It seems to me 3..5 and 7..14 can just go in before the rest. Only 4 and 5 come under fixes and the rest of them seem dependent on the series. However, 4, and 5 are reproduced in i.MX8M platform hence I have added it as part of this series. Jagan,
On 12/11/22 06:48, Jagan Teki wrote: > On Sun, Dec 11, 2022 at 7:58 AM Marek Vasut <marex@denx.de> wrote: >> >> On 12/9/22 16:23, Jagan Teki wrote: >>> This series supports common bridge support for Samsung MIPI DSIM >>> which is used in Exynos and i.MX8MM SoC's. >>> >>> The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. >> >> I wonder if it would rather make sense to split the series up and submit >> all the various partial fixes and additions separately, instead of >> piling them up in this series and ever growing the series. >> >> It seems to me 3..5 and 7..14 can just go in before the rest. > > Only 4 and 5 come under fixes and the rest of them seem dependent on > the series. However, 4, and 5 are reproduced in i.MX8M platform hence > I have added it as part of this series. You could try and reorder the series such that 7..14 can go in before 6 . And send it in smaller chunks too.
On Fri, Dec 9, 2022 at 8:54 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. > > Changes for v9: > - rebase on drm-misc-next > - drop drm bridge attach fix for Exynos > - added prepare_prev_first flag > - added pre_enable_prev_first flag > - fix bridge chain order for exynos > - added fix for Exynos host init for first DSI transfer > - added MEDIA_BUS_FMT_FIXED > - return MEDIA_BUS_FMT_RGB888_1X24 output_fmt if supported output_fmt > list is unsupported. > - added MEDIA_BUS_FMT_YUYV10_1X20 > - added MEDIA_BUS_FMT_YUYV12_1X24 > > Changes for v8: > * fixed comment lines > * fixed commit messages > * fixed video mode bits > * collect Marek Ack > * fixed video mode bit names > * update input formats logic > * added imx8mplus support > > Changes for v7: > * fix the drm bridge attach chain for exynos drm dsi driver > * fix the hw_type checking logic > > Changes for v6: > * handle previous bridge for exynos dsi while attaching bridge > > Changes for v5: > * bridge changes to support multi-arch > * updated and clear commit messages > * add hw_type via plat data > * removed unneeded quirk > * rebased on linux-next > t > Changes for v4: > * include Inki Dae in MAINTAINERS > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > * update init handling to ensure host init done on first cmd transfer > > Changes for v3: > * fix the mult-arch build > * fix dsi host init > * updated commit messages > > Changes for v2: > * fix bridge handling > * fix dsi host init > * correct the commit messages > > Tested in Engicam i.Core MX8M Mini SoM. > > Repo: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v9 > > v8: > https://lore.kernel.org/all/20221110183853.3678209-1-jagan@amarulasolutions.com/ > > Any inputs? > Jagan. > > Jagan Teki (16): > drm: panel: Enable prepare_prev_first flag for samsung-s6e panels > drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags > drm: exynos: dsi: Properly name HSA/HBP/HFP/HSE bits > drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge > drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices > drm: bridge: samsung-dsim: Mark PHY as optional > drm: bridge: samsung-dsim: Add host init in pre_enable > drm: bridge: samsung-dsim: Init exynos host for first DSI transfer > drm: bridge: samsung-dsim: Add atomic_check > drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset > drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts > drm: bridge: samsung-dsim: Add input_bus_flags > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support > drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support > drm: bridge: samsung-dsim: Add i.MX8M Plus support > > Marek Szyprowski (2): > drm/bridge: tc358764: Enable pre_enable_prev_first flag > drm: exynos: dsi: Restore proper bridge chain order Can someone apply 1 to 5 patches, so I can send the following version with DSIM conversion? Jagan.
Hi Jagan, On 09.12.2022 16:23, Jagan Teki wrote: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. Well, I think I've managed to fix the remaining bits to keep it working on Exynos and have all the features added in meantime between v1..v9. I've posted my comments in the individual patches, but to make think easier to test, I've also pushed my changes to the github: https://github.com/mszyprow/linux/tree/v6.1-next-20221208-dsi-v9-fixed With that fixes, feel free to add: Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> to all common/Exynos related patches. > Changes for v9: > - rebase on drm-misc-next > - drop drm bridge attach fix for Exynos > - added prepare_prev_first flag > - added pre_enable_prev_first flag > - fix bridge chain order for exynos > - added fix for Exynos host init for first DSI transfer > - added MEDIA_BUS_FMT_FIXED > - return MEDIA_BUS_FMT_RGB888_1X24 output_fmt if supported output_fmt > list is unsupported. > - added MEDIA_BUS_FMT_YUYV10_1X20 > - added MEDIA_BUS_FMT_YUYV12_1X24 > > Changes for v8: > * fixed comment lines > * fixed commit messages > * fixed video mode bits > * collect Marek Ack > * fixed video mode bit names > * update input formats logic > * added imx8mplus support > > Changes for v7: > * fix the drm bridge attach chain for exynos drm dsi driver > * fix the hw_type checking logic > > Changes for v6: > * handle previous bridge for exynos dsi while attaching bridge > > Changes for v5: > * bridge changes to support multi-arch > * updated and clear commit messages > * add hw_type via plat data > * removed unneeded quirk > * rebased on linux-next > t > Changes for v4: > * include Inki Dae in MAINTAINERS > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > * update init handling to ensure host init done on first cmd transfer > > Changes for v3: > * fix the mult-arch build > * fix dsi host init > * updated commit messages > > Changes for v2: > * fix bridge handling > * fix dsi host init > * correct the commit messages > > Tested in Engicam i.Core MX8M Mini SoM. > > Repo: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v9 > > v8: > https://lore.kernel.org/all/20221110183853.3678209-1-jagan@amarulasolutions.com/ > > Any inputs? > Jagan. > > Jagan Teki (16): > drm: panel: Enable prepare_prev_first flag for samsung-s6e panels > drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags > drm: exynos: dsi: Properly name HSA/HBP/HFP/HSE bits > drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge > drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices > drm: bridge: samsung-dsim: Mark PHY as optional > drm: bridge: samsung-dsim: Add host init in pre_enable > drm: bridge: samsung-dsim: Init exynos host for first DSI transfer > drm: bridge: samsung-dsim: Add atomic_check > drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset > drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts > drm: bridge: samsung-dsim: Add input_bus_flags > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support > drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support > drm: bridge: samsung-dsim: Add i.MX8M Plus support > > Marek Szyprowski (2): > drm/bridge: tc358764: Enable pre_enable_prev_first flag > drm: exynos: dsi: Restore proper bridge chain order > > .../bindings/display/exynos/exynos_dsim.txt | 2 + > MAINTAINERS | 9 + > drivers/gpu/drm/bridge/Kconfig | 12 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/samsung-dsim.c | 1934 +++++++++++++++++ > drivers/gpu/drm/bridge/tc358764.c | 1 + > drivers/gpu/drm/exynos/Kconfig | 1 + > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1769 +-------------- > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 1 + > .../gpu/drm/panel/panel-samsung-s6e63j0x03.c | 1 + > drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c | 1 + > include/drm/bridge/samsung-dsim.h | 116 + > 12 files changed, 2195 insertions(+), 1653 deletions(-) > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > create mode 100644 include/drm/bridge/samsung-dsim.h > Best regards