| Message ID | 20221212100232.138519-5-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d0b014a74823cc52dde447d0af61ff14fce5a785 |
| Headers | show |
| Series | [v2,1/6] arm64: dts: qcom: sc7180: order top-level nodes alphabetically | expand |
On 12 December 2022 13:02:31 GMT+03:00, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: >The sound node is not property of the soc, but rather board as it >describes the sound configuration. It also does not have unit address: > > sdm845-shift-axolotl.dtb: soc@0: sound: {} should not be valid under {'type': 'object'} > >Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Reviewed-by: Dmitry Baryshkov<dmitry.baryshkov@linaro.org> > >--- > >Changes since v1: >1. Add Rb tag. >--- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi >index 8eeb3aa261d5..5f1f7cb52c90 100644 >--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi >+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi >@@ -3964,9 +3964,6 @@ lmh_cluster0: lmh@17d78800 { > #interrupt-cells = <1>; > }; > >- sound: sound { >- }; >- > usb_1_hsphy: phy@88e2000 { > compatible = "qcom,sdm845-qusb2-phy", "qcom,qusb2-v2-phy"; > reg = <0 0x088e2000 0 0x400>; >@@ -5341,6 +5338,9 @@ wifi: wifi@18800000 { > }; > }; > >+ sound: sound { >+ }; >+ > thermal-zones { > cpu0-thermal { > polling-delay-passive = <250>;
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 8eeb3aa261d5..5f1f7cb52c90 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -3964,9 +3964,6 @@ lmh_cluster0: lmh@17d78800 { #interrupt-cells = <1>; }; - sound: sound { - }; - usb_1_hsphy: phy@88e2000 { compatible = "qcom,sdm845-qusb2-phy", "qcom,qusb2-v2-phy"; reg = <0 0x088e2000 0 0x400>; @@ -5341,6 +5338,9 @@ wifi: wifi@18800000 { }; }; + sound: sound { + }; + thermal-zones { cpu0-thermal { polling-delay-passive = <250>;
The sound node is not property of the soc, but rather board as it describes the sound configuration. It also does not have unit address: sdm845-shift-axolotl.dtb: soc@0: sound: {} should not be valid under {'type': 'object'} Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Changes since v1: 1. Add Rb tag. --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)