| Message ID | 20221212205406.3771071-5-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | edf2ceb9a2a279d350fdb57c1930554c8675b2b1 |
| Headers | show |
| Series | ASoC: Drop empty platform remove functions | expand |
On 12.12.2022 22:53, Uwe Kleine-König wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > A remove callback just returning 0 is equivalent to no remove callback > at all. So drop the useless function. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > sound/soc/atmel/atmel-pdmic.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/sound/soc/atmel/atmel-pdmic.c b/sound/soc/atmel/atmel-pdmic.c > index 77ff12baead5..12cd40b15644 100644 > --- a/sound/soc/atmel/atmel-pdmic.c > +++ b/sound/soc/atmel/atmel-pdmic.c > @@ -692,11 +692,6 @@ static int atmel_pdmic_probe(struct platform_device *pdev) > return ret; > } > > -static int atmel_pdmic_remove(struct platform_device *pdev) > -{ > - return 0; > -} > - > static struct platform_driver atmel_pdmic_driver = { > .driver = { > .name = "atmel-pdmic", > @@ -704,7 +699,6 @@ static struct platform_driver atmel_pdmic_driver = { > .pm = &snd_soc_pm_ops, > }, > .probe = atmel_pdmic_probe, > - .remove = atmel_pdmic_remove, > }; > module_platform_driver(atmel_pdmic_driver); > > -- > 2.38.1 >
diff --git a/sound/soc/atmel/atmel-pdmic.c b/sound/soc/atmel/atmel-pdmic.c index 77ff12baead5..12cd40b15644 100644 --- a/sound/soc/atmel/atmel-pdmic.c +++ b/sound/soc/atmel/atmel-pdmic.c @@ -692,11 +692,6 @@ static int atmel_pdmic_probe(struct platform_device *pdev) return ret; } -static int atmel_pdmic_remove(struct platform_device *pdev) -{ - return 0; -} - static struct platform_driver atmel_pdmic_driver = { .driver = { .name = "atmel-pdmic", @@ -704,7 +699,6 @@ static struct platform_driver atmel_pdmic_driver = { .pm = &snd_soc_pm_ops, }, .probe = atmel_pdmic_probe, - .remove = atmel_pdmic_remove, }; module_platform_driver(atmel_pdmic_driver);
A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- sound/soc/atmel/atmel-pdmic.c | 6 ------ 1 file changed, 6 deletions(-)