| Message ID | 20221215201100.2897501-2-l.stach@pengutronix.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/2] dt-bindings: phy: add binding for the i.MX8MP HDMI PHY | expand |
Hi Lucas, thanks for this series, one comment please see below. On 22-12-15, Lucas Stach wrote: > This adds the driver for the Samsung HDMI PHY found on the > i.MX8MP SoC. Based on downstream implementation from > Sandor Yu <Sandor.yu@nxp.com>. > > Co-developed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > v2: use DEFINE_RUNTIME_DEV_PM_OPS > --- > drivers/phy/freescale/Kconfig | 6 + > drivers/phy/freescale/Makefile | 1 + > drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 694 +++++++++++++++++++ > 3 files changed, 701 insertions(+) > create mode 100644 drivers/phy/freescale/phy-fsl-samsung-hdmi.c ... > +static int fsl_samsung_hdmi_phy_suspend(struct device *dev) > +{ > + struct fsl_samsung_hdmi_phy *phy = dev_get_drvdata(dev); > + > + clk_disable_unprepare(phy->apbclk); > + > + return 0; > +} > + > +static int fsl_samsung_hdmi_phy_resume(struct device *dev) > +{ > + struct fsl_samsung_hdmi_phy *phy = dev_get_drvdata(dev); > + int ret = 0; > + > + ret = clk_prepare_enable(phy->apbclk); > + if (ret) { > + dev_err(phy->dev, "failed to enable apbclk\n"); > + return ret; > + } > + > + if (phy->cur_cfg) > + ret = fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg); > + > + return ret; > + > +} > + > +DEFINE_RUNTIME_DEV_PM_OPS(fsl_samsung_hdmi_phy_pm_ops, > + fsl_samsung_hdmi_phy_suspend, > + fsl_samsung_hdmi_phy_resume, NULL); This must be 'static DEFINE_RUNTIME_DEV_PM_OPS()' since the define don't add this for you. Regards, Marco
On 15-12-22, 21:11, Lucas Stach wrote: > This adds the driver for the Samsung HDMI PHY found on the > i.MX8MP SoC. Based on downstream implementation from > Sandor Yu <Sandor.yu@nxp.com>. > > Co-developed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > v2: use DEFINE_RUNTIME_DEV_PM_OPS > --- > drivers/phy/freescale/Kconfig | 6 + > drivers/phy/freescale/Makefile | 1 + > drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 694 +++++++++++++++++++ > 3 files changed, 701 insertions(+) > create mode 100644 drivers/phy/freescale/phy-fsl-samsung-hdmi.c > > diff --git a/drivers/phy/freescale/Kconfig b/drivers/phy/freescale/Kconfig > index 853958fb2c06..5c2b73042dfc 100644 > --- a/drivers/phy/freescale/Kconfig > +++ b/drivers/phy/freescale/Kconfig > @@ -35,6 +35,12 @@ config PHY_FSL_IMX8M_PCIE > Enable this to add support for the PCIE PHY as found on > i.MX8M family of SOCs. > > +config PHY_FSL_SAMSUNG_HDMI_PHY > + tristate "Samsung HDMI PHY support" > + depends on OF && HAS_IOMEM > + help > + Enable this to add support for the Samsung HDMI PHY in i.MX8MP. > + > endif > > config PHY_FSL_LYNX_28G this new should come after this one... > diff --git a/drivers/phy/freescale/Makefile b/drivers/phy/freescale/Makefile > index cedb328bc4d2..c4386bfdb853 100644 > --- a/drivers/phy/freescale/Makefile > +++ b/drivers/phy/freescale/Makefile > @@ -4,3 +4,4 @@ obj-$(CONFIG_PHY_MIXEL_LVDS_PHY) += phy-fsl-imx8qm-lvds-phy.o > obj-$(CONFIG_PHY_MIXEL_MIPI_DPHY) += phy-fsl-imx8-mipi-dphy.o > obj-$(CONFIG_PHY_FSL_IMX8M_PCIE) += phy-fsl-imx8m-pcie.o > obj-$(CONFIG_PHY_FSL_LYNX_28G) += phy-fsl-lynx-28g.o > +obj-$(CONFIG_PHY_FSL_SAMSUNG_HDMI_PHY) += phy-fsl-samsung-hdmi.o > diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > new file mode 100644 > index 000000000000..185244dcb810 > --- /dev/null > +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > @@ -0,0 +1,694 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright 2020 NXP > + * Copyright 2022 Pengutronix, Lucas Stach <kernel@pengutronix.de> > + */ > + > +#include <linux/clk-provider.h> > +#include <linux/clk.h> > +#include <linux/delay.h> > +#include <linux/io.h> > +#include <linux/iopoll.h> > +#include <linux/module.h> > +#include <linux/of_device.h> > +#include <linux/of.h> > +#include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > + > +#define PHY_REG_00 0x00 > +#define PHY_REG_01 0x04 > +#define PHY_REG_02 0x08 > +#define PHY_REG_08 0x20 > +#define PHY_REG_09 0x24 > +#define PHY_REG_10 0x28 > +#define PHY_REG_11 0x2c No names for regs? > + > +#define PHY_REG_12 0x30 > +#define REG12_FLD_CK_DIV(x) (((x) & 0x3) << 4) GENMASK() pls > +#define REG12_TMDS_CLK 0x0 > +#define REG12_TMDS_CLK_DIV2 0x1 > +#define REG12_TMDS_CLK_DIV4 0x2 > +#define REG12_TMDS_CLK_DIV8 0x3 > + > +#define PHY_REG_13 0x34 > +#define REG13_FLD_TG_CODE_LOW(x) (x & 0xff) > + > +#define PHY_REG_14 0x38 > +#define REG14_FLD_TOL(x) ((x & 0xf) << 4) > +#define REG14_FLD_RP_CODE(x) ((x & 0x3) << 1) > +#define REG14_FLD_TG_CODE_HIGH(x) ((x >> 8) & 0x1) FIELD_GET|PREP please > + > +#define PHY_REG_15 0x3c > +#define PHY_REG_16 0x40 > +#define PHY_REG_17 0x44 > +#define PHY_REG_18 0x48 > +#define PHY_REG_19 0x4c > +#define PHY_REG_20 0x50 > + > +#define PHY_REG_21 0x54 > +#define REG21_SEL_TX_CK_INV BIT(7) > +#define REG21_PMS_S(x) (x & 0xf) > + > +#define PHY_REG_22 0x58 > +#define PHY_REG_23 0x5c > +#define PHY_REG_24 0x60 > +#define PHY_REG_25 0x64 > +#define PHY_REG_26 0x68 > +#define PHY_REG_27 0x6c > +#define PHY_REG_28 0x70 > +#define PHY_REG_29 0x74 > +#define PHY_REG_30 0x78 > +#define PHY_REG_31 0x7c > +#define PHY_REG_32 0x80 > + > +#define PHY_REG_33 0x84 > +#define REG33_MODE_SET_DONE BIT(7) > +#define REG33_FIX_DA BIT(1) > + > +#define PHY_REG_34 0x88 > +#define REG34_PHY_READY BIT(7) > +#define REG34_PLL_LOCK BIT(6) > +#define REG34_PHY_CLK_READY BIT(5) > + > +#define PHY_REG_35 0x8c > +#define PHY_REG_36 0x90 > +#define PHY_REG_37 0x94 > +#define PHY_REG_38 0x98 > +#define PHY_REG_39 0x9c > +#define PHY_REG_40 0xa0 > +#define PHY_REG_41 0xa4 > +#define PHY_REG_42 0xa8 > +#define PHY_REG_43 0xac > +#define PHY_REG_44 0xb0 > +#define PHY_REG_45 0xb4 > +#define PHY_REG_46 0xb8 > +#define PHY_REG_47 0xbc > + > +#define PHY_PLL_DIV_REGS_NUM 6 > + > +struct phy_config { > + u32 pixclk; > + u8 pll_div_regs[PHY_PLL_DIV_REGS_NUM]; > +}; > + > +const struct phy_config phy_pll_cfg[] = { > + { > + .pixclk = 22250000, > + .pll_div_regs = { 0x4B, 0xF1, 0x89, 0x88, 0x80, 0x40 }, small case for hex numbers pls > + }, { > + .pixclk = 23750000, > + .pll_div_regs = { 0x50, 0xF1, 0x86, 0x85, 0x80, 0x40 }, > + },{ > + .pixclk = 24000000, > + .pll_div_regs = { 0x50, 0xF0, 0x00, 0x00, 0x80, 0x00 }, > + },{ > + .pixclk = 24024000, > + .pll_div_regs = { 0x50, 0xF1, 0x99, 0x02, 0x80, 0x40 }, > + }, { > + .pixclk = 25175000, > + .pll_div_regs = { 0x54, 0xFC, 0xCC, 0x91, 0x80, 0x40 }, > + }, { > + .pixclk = 25200000, > + .pll_div_regs = { 0x54, 0xF0, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 26750000, > + .pll_div_regs = { 0x5A, 0xF2, 0x89, 0x88, 0x80, 0x40 }, > + }, { > + .pixclk = 27000000, > + .pll_div_regs = { 0x5A, 0xF0, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 27027000, > + .pll_div_regs = { 0x5A, 0xF2, 0xFD, 0x0C, 0x80, 0x40 }, > + }, { > + .pixclk = 29500000, > + .pll_div_regs = { 0x62, 0xF4, 0x95, 0x08, 0x80, 0x40 }, > + }, { > + .pixclk = 30750000, > + .pll_div_regs = { 0x66, 0xF4, 0x82, 0x01, 0x88, 0x45 }, > + }, { > + .pixclk = 30888000, > + .pll_div_regs = { 0x66, 0xF4, 0x99, 0x18, 0x88, 0x45 }, > + }, { > + .pixclk = 33750000, > + .pll_div_regs = { 0x70, 0xF4, 0x82, 0x01, 0x80, 0x40 }, > + }, { > + .pixclk = 35000000, > + .pll_div_regs = { 0x58, 0xB8, 0x8B, 0x88, 0x80, 0x40 }, > + }, { > + .pixclk = 36000000, > + .pll_div_regs = { 0x5A, 0xB0, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 36036000, > + .pll_div_regs = { 0x5A, 0xB2, 0xFD, 0x0C, 0x80, 0x40 }, > + }, { > + .pixclk = 40000000, > + .pll_div_regs = { 0x64, 0xB0, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 43200000, > + .pll_div_regs = { 0x5A, 0x90, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 43243200, > + .pll_div_regs = { 0x5A, 0x92, 0xFD, 0x0C, 0x80, 0x40 }, > + }, { > + .pixclk = 44500000, > + .pll_div_regs = { 0x5C, 0x92, 0x98, 0x11, 0x84, 0x41 }, > + }, { > + .pixclk = 47000000, > + .pll_div_regs = { 0x62, 0x94, 0x95, 0x82, 0x80, 0x40 }, > + }, { > + .pixclk = 47500000, > + .pll_div_regs = { 0x63, 0x96, 0xA1, 0x82, 0x80, 0x40 }, > + }, { > + .pixclk = 50349650, > + .pll_div_regs = { 0x54, 0x7C, 0xC3, 0x8F, 0x80, 0x40 }, > + }, { > + .pixclk = 50400000, > + .pll_div_regs = { 0x54, 0x70, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 53250000, > + .pll_div_regs = { 0x58, 0x72, 0x84, 0x03, 0x82, 0x41 }, > + }, { > + .pixclk = 53500000, > + .pll_div_regs = { 0x5A, 0x72, 0x89, 0x88, 0x80, 0x40 }, > + }, { > + .pixclk = 54000000, > + .pll_div_regs = { 0x5A, 0x70, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 54054000, > + .pll_div_regs = { 0x5A, 0x72, 0xFD, 0x0C, 0x80, 0x40 }, > + }, { > + .pixclk = 59000000, > + .pll_div_regs = { 0x62, 0x74, 0x95, 0x08, 0x80, 0x40 }, > + }, { > + .pixclk = 59340659, > + .pll_div_regs = { 0x62, 0x74, 0xDB, 0x52, 0x88, 0x47 }, > + }, { > + .pixclk = 59400000, > + .pll_div_regs = { 0x63, 0x70, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 61500000, > + .pll_div_regs = { 0x66, 0x74, 0x82, 0x01, 0x88, 0x45 }, > + }, { > + .pixclk = 63500000, > + .pll_div_regs = { 0x69, 0x74, 0x89, 0x08, 0x80, 0x40 }, > + }, { > + .pixclk = 67500000, > + .pll_div_regs = { 0x54, 0x52, 0x87, 0x03, 0x80, 0x40 }, > + }, { > + .pixclk = 70000000, > + .pll_div_regs = { 0x58, 0x58, 0x8B, 0x88, 0x80, 0x40 }, > + }, { > + .pixclk = 72000000, > + .pll_div_regs = { 0x5A, 0x50, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 72072000, > + .pll_div_regs = { 0x5A, 0x52, 0xFD, 0x0C, 0x80, 0x40 }, > + }, { > + .pixclk = 74176000, > + .pll_div_regs = { 0x5D, 0x58, 0xDB, 0xA2, 0x88, 0x41 }, > + }, { > + .pixclk = 74250000, > + .pll_div_regs = { 0x5C, 0x52, 0x90, 0x0D, 0x84, 0x41 }, > + }, { > + .pixclk = 78500000, > + .pll_div_regs = { 0x62, 0x54, 0x87, 0x01, 0x80, 0x40 }, > + }, { > + .pixclk = 80000000, > + .pll_div_regs = { 0x64, 0x50, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 82000000, > + .pll_div_regs = { 0x66, 0x54, 0x82, 0x01, 0x88, 0x45 }, > + }, { > + .pixclk = 82500000, > + .pll_div_regs = { 0x67, 0x54, 0x88, 0x01, 0x90, 0x49 }, > + }, { > + .pixclk = 89000000, > + .pll_div_regs = { 0x70, 0x54, 0x84, 0x83, 0x80, 0x40 }, > + }, { > + .pixclk = 90000000, > + .pll_div_regs = { 0x70, 0x54, 0x82, 0x01, 0x80, 0x40 }, > + }, { > + .pixclk = 94000000, > + .pll_div_regs = { 0x4E, 0x32, 0xA7, 0x10, 0x80, 0x40 }, > + }, { > + .pixclk = 95000000, > + .pll_div_regs = { 0x50, 0x31, 0x86, 0x85, 0x80, 0x40 }, > + }, { > + .pixclk = 98901099, > + .pll_div_regs = { 0x52, 0x3A, 0xDB, 0x4C, 0x88, 0x47 }, > + }, { > + .pixclk = 99000000, > + .pll_div_regs = { 0x52, 0x32, 0x82, 0x01, 0x88, 0x47 }, > + }, { > + .pixclk = 100699300, > + .pll_div_regs = { 0x54, 0x3C, 0xC3, 0x8F, 0x80, 0x40 }, > + }, { > + .pixclk = 100800000, > + .pll_div_regs = { 0x54, 0x30, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 102500000, > + .pll_div_regs = { 0x55, 0x32, 0x8C, 0x05, 0x90, 0x4B }, > + }, { > + .pixclk = 104750000, > + .pll_div_regs = { 0x57, 0x32, 0x98, 0x07, 0x90, 0x49 }, > + }, { > + .pixclk = 106500000, > + .pll_div_regs = { 0x58, 0x32, 0x84, 0x03, 0x82, 0x41 }, > + }, { > + .pixclk = 107000000, > + .pll_div_regs = { 0x5A, 0x32, 0x89, 0x88, 0x80, 0x40 }, > + }, { > + .pixclk = 108000000, > + .pll_div_regs = { 0x5A, 0x30, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 108108000, > + .pll_div_regs = { 0x5A, 0x32, 0xFD, 0x0C, 0x80, 0x40 }, > + }, { > + .pixclk = 118000000, > + .pll_div_regs = { 0x62, 0x34, 0x95, 0x08, 0x80, 0x40 }, > + }, { > + .pixclk = 118800000, > + .pll_div_regs = { 0x63, 0x30, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 123000000, > + .pll_div_regs = { 0x66, 0x34, 0x82, 0x01, 0x88, 0x45 }, > + }, { > + .pixclk = 127000000, > + .pll_div_regs = { 0x69, 0x34, 0x89, 0x08, 0x80, 0x40 }, > + }, { > + .pixclk = 135000000, > + .pll_div_regs = { 0x70, 0x34, 0x82, 0x01, 0x80, 0x40 }, > + }, { > + .pixclk = 135580000, > + .pll_div_regs = { 0x71, 0x39, 0xE9, 0x82, 0x9C, 0x5B }, > + }, { > + .pixclk = 137520000, > + .pll_div_regs = { 0x72, 0x38, 0x99, 0x10, 0x85, 0x41 }, > + }, { > + .pixclk = 138750000, > + .pll_div_regs = { 0x73, 0x35, 0x88, 0x05, 0x90, 0x4D }, > + }, { > + .pixclk = 140000000, > + .pll_div_regs = { 0x75, 0x36, 0xA7, 0x90, 0x80, 0x40 }, > + }, { > + .pixclk = 144000000, > + .pll_div_regs = { 0x78, 0x30, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 148352000, > + .pll_div_regs = { 0x7B, 0x35, 0xDB, 0x39, 0x90, 0x45 }, > + }, { > + .pixclk = 148500000, > + .pll_div_regs = { 0x7B, 0x35, 0x84, 0x03, 0x90, 0x45 }, > + }, { > + .pixclk = 154000000, > + .pll_div_regs = { 0x40, 0x18, 0x83, 0x01, 0x00, 0x40 }, > + }, { > + .pixclk = 157000000, > + .pll_div_regs = { 0x41, 0x11, 0xA7, 0x14, 0x80, 0x40 }, > + }, { > + .pixclk = 160000000, > + .pll_div_regs = { 0x42, 0x12, 0xA1, 0x20, 0x80, 0x40 }, > + }, { > + .pixclk = 162000000, > + .pll_div_regs = { 0x43, 0x18, 0x8B, 0x08, 0x96, 0x55 }, > + }, { > + .pixclk = 164000000, > + .pll_div_regs = { 0x45, 0x11, 0x83, 0x82, 0x90, 0x4B }, > + }, { > + .pixclk = 165000000, > + .pll_div_regs = { 0x45, 0x11, 0x84, 0x81, 0x90, 0x4B }, > + }, { > + .pixclk = 180000000, > + .pll_div_regs = { 0x4B, 0x10, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 185625000, > + .pll_div_regs = { 0x4E, 0x12, 0x9A, 0x95, 0x80, 0x40 }, > + }, { > + .pixclk = 188000000, > + .pll_div_regs = { 0x4E, 0x12, 0xA7, 0x10, 0x80, 0x40 }, > + }, { > + .pixclk = 198000000, > + .pll_div_regs = { 0x52, 0x12, 0x82, 0x01, 0x88, 0x47 }, > + }, { > + .pixclk = 205000000, > + .pll_div_regs = { 0x55, 0x12, 0x8C, 0x05, 0x90, 0x4B }, > + }, { > + .pixclk = 209500000, > + .pll_div_regs = { 0x57, 0x12, 0x98, 0x07, 0x90, 0x49 }, > + }, { > + .pixclk = 213000000, > + .pll_div_regs = { 0x58, 0x12, 0x84, 0x03, 0x82, 0x41 }, > + }, { > + .pixclk = 216000000, > + .pll_div_regs = { 0x5A, 0x10, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 216216000, > + .pll_div_regs = { 0x5A, 0x12, 0xFD, 0x0C, 0x80, 0x40 }, > + }, { > + .pixclk = 237600000, > + .pll_div_regs = { 0x63, 0x10, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 254000000, > + .pll_div_regs = { 0x69, 0x14, 0x89, 0x08, 0x80, 0x40 }, > + }, { > + .pixclk = 277500000, > + .pll_div_regs = { 0x73, 0x15, 0x88, 0x05, 0x90, 0x4D }, > + }, { > + .pixclk = 288000000, > + .pll_div_regs = { 0x78, 0x10, 0x00, 0x00, 0x80, 0x00 }, > + }, { > + .pixclk = 297000000, > + .pll_div_regs = { 0x7B, 0x15, 0x84, 0x03, 0x90, 0x45 }, > + }, lots of magic numbers! > +}; > + > +struct reg_settings { > + u8 reg; > + u8 val; > +}; > + > +const struct reg_settings common_phy_cfg[] = { > + { PHY_REG_00, 0x00 }, { PHY_REG_01, 0xD1 }, > + { PHY_REG_08, 0x4f }, { PHY_REG_09, 0x30 }, > + { PHY_REG_10, 0x33 }, { PHY_REG_11, 0x65 }, > + /* REG12 pixclk specific */ > + /* REG13 pixclk specific */ > + /* REG14 pixclk specific */ > + { PHY_REG_15, 0x80 }, { PHY_REG_16, 0x6C }, > + { PHY_REG_17, 0xF2 }, { PHY_REG_18, 0x67 }, > + { PHY_REG_19, 0x00 }, { PHY_REG_20, 0x10 }, > + /* REG21 pixclk specific */ > + { PHY_REG_22, 0x30 }, { PHY_REG_23, 0x32 }, > + { PHY_REG_24, 0x60 }, { PHY_REG_25, 0x8F }, > + { PHY_REG_26, 0x00 }, { PHY_REG_27, 0x00 }, > + { PHY_REG_28, 0x08 }, { PHY_REG_29, 0x00 }, > + { PHY_REG_30, 0x00 }, { PHY_REG_31, 0x00 }, > + { PHY_REG_32, 0x00 }, { PHY_REG_33, 0x80 }, > + { PHY_REG_34, 0x00 }, { PHY_REG_35, 0x00 }, > + { PHY_REG_36, 0x00 }, { PHY_REG_37, 0x00 }, > + { PHY_REG_38, 0x00 }, { PHY_REG_39, 0x00 }, > + { PHY_REG_40, 0x00 }, { PHY_REG_41, 0xE0 }, > + { PHY_REG_42, 0x83 }, { PHY_REG_43, 0x0F }, > + { PHY_REG_44, 0x3E }, { PHY_REG_45, 0xF8 }, > + { PHY_REG_46, 0x00 }, { PHY_REG_47, 0x00 } > +}; > + > +struct fsl_samsung_hdmi_phy { > + struct device *dev; > + void __iomem *regs; > + struct clk *apbclk; > + struct clk *refclk; > + > + /* clk provider */ > + struct clk_hw hw; > + const struct phy_config *cur_cfg; > +}; > + > +static inline struct fsl_samsung_hdmi_phy * > +to_fsl_samsung_hdmi_phy(struct clk_hw *hw) > +{ > + return container_of(hw, struct fsl_samsung_hdmi_phy, hw); > +} > + > +static void > +fsl_samsung_hdmi_phy_configure_pixclk(struct fsl_samsung_hdmi_phy *phy, > + const struct phy_config *cfg) > +{ > + u8 div; > + > + switch (cfg->pixclk) { > + case 22250000 ... 33750000: div = 0xf; break; > + case 35000000 ... 40000000: div = 0xb; break; > + case 43200000 ... 47500000: div = 0x9; break; > + case 50349650 ... 63500000: div = 0x7; break; > + case 67500000 ... 90000000: div = 0x5; break; > + case 94000000 ... 148500000: div = 0x3; break; > + case 154000000 ... 297000000: div = 0x1; break; lets do proper linux style please > + } > + > + writeb(REG21_SEL_TX_CK_INV | REG21_PMS_S(div), phy->regs + PHY_REG_21); > +} > + > +static void > +fsl_samsung_hdmi_phy_configure_pll_lock_det(struct fsl_samsung_hdmi_phy *phy, > + const struct phy_config *cfg) > +{ > + u32 pclk = cfg->pixclk; > + u32 fld_tg_code; > + u32 pclk_khz; > + u8 div; > + > + switch (cfg->pixclk) { > + case 22250000 ... 47500000: div = 1; break; > + case 50349650 ... 99000000: div = 2; break; > + case 100699300 ... 198000000: div = 4; break; > + case 205000000 ... 297000000: div = 8; break; > + } > + > + writeb(REG12_FLD_CK_DIV(fls(div) - 1), phy->regs + PHY_REG_12); > + > + /* > + * Calculation for the frequency lock detector target code (fld_tg_code) > + * is based on reference manual register description of PHY_REG13 > + * (13.10.3.1.14.2): > + * 1st) Calculate int_pllclk which is determinded by FLD_CK_DIV > + * 2nd) Increase resolution to avoid rounding issues > + * 3th) Do the div (256 / Freq. of int_pllclk) * 24 > + * 4th) Reduce the resolution and always round up since the NXP > + * settings rounding up always too. TODO: Check if that is > + * correct. > + */ > + pclk /= div; > + pclk_khz = pclk / 1000; > + fld_tg_code = 256 * 1000 * 1000 / pclk_khz * 24; > + fld_tg_code = DIV_ROUND_UP(fld_tg_code, 1000); > + > + /* FLD_TOL and FLD_RP_CODE taken from downstream driver */ > + writeb(REG14_FLD_TOL(2) | REG14_FLD_RP_CODE(2) | > + REG14_FLD_TG_CODE_HIGH(fld_tg_code), phy->regs + PHY_REG_14); > + writeb(REG13_FLD_TG_CODE_LOW(fld_tg_code), phy->regs + PHY_REG_13); > +} > + > +static int fsl_samsung_hdmi_phy_configure(struct fsl_samsung_hdmi_phy *phy, > + const struct phy_config *cfg) > +{ > + int i, ret; > + u8 val; > + > + /* HDMI PHY init */ > + writeb(REG33_FIX_DA, phy->regs + PHY_REG_33); > + > + /* Common PHY registers registers */ > + for (i = 0; i < ARRAY_SIZE(common_phy_cfg); i++) > + writeb(common_phy_cfg[i].val, phy->regs + common_phy_cfg[i].reg); > + > + /* Set individual PLL registers PHY_REG2 ... PHY_REG7 */ > + for (i = 0; i < PHY_PLL_DIV_REGS_NUM; i++) > + writeb(cfg->pll_div_regs[i], phy->regs + PHY_REG_02 + i * 4); > + > + fsl_samsung_hdmi_phy_configure_pixclk(phy, cfg); > + fsl_samsung_hdmi_phy_configure_pll_lock_det(phy, cfg); > + > + writeb(REG33_FIX_DA | REG33_MODE_SET_DONE , phy->regs + PHY_REG_33); > + > + ret = readb_poll_timeout(phy->regs + PHY_REG_34, val, > + val & REG34_PLL_LOCK, > + 50, 20000); > + if (ret) > + dev_err(phy->dev, "PLL failed to lock\n"); > + > + return ret; > +} > + > +static unsigned long phy_clk_recalc_rate(struct clk_hw *hw, > + unsigned long parent_rate) > +{ > + struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw); > + > + if (!phy->cur_cfg) > + return 74250000; > + > + return phy->cur_cfg->pixclk; > +} > + > +static long phy_clk_round_rate(struct clk_hw *hw, > + unsigned long rate, unsigned long *parent_rate) > +{ > + int i; > + > + for (i = ARRAY_SIZE(phy_pll_cfg) - 1; i >= 0; i--) > + if (phy_pll_cfg[i].pixclk <= rate) > + return phy_pll_cfg[i].pixclk; > + > + return -EINVAL; > +} > + > +static int phy_clk_set_rate(struct clk_hw *hw, > + unsigned long rate, unsigned long parent_rate) > +{ > + struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw); > + int i; > + > + for (i = ARRAY_SIZE(phy_pll_cfg) - 1; i >= 0; i--) > + if (phy_pll_cfg[i].pixclk <= rate) > + break; > + > + if (i < 0) > + return -EINVAL; > + > + phy->cur_cfg = &phy_pll_cfg[i]; > + > + return fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg); > +} > + > +static const struct clk_ops phy_clk_ops = { > + .recalc_rate = phy_clk_recalc_rate, > + .round_rate = phy_clk_round_rate, > + .set_rate = phy_clk_set_rate, > +}; > + > +static int phy_clk_register(struct fsl_samsung_hdmi_phy *phy) > +{ > + struct device *dev = phy->dev; > + struct device_node *np = dev->of_node; > + struct clk_init_data init; > + const char *parent_name; > + struct clk *phyclk; > + int ret; > + > + parent_name = __clk_get_name(phy->refclk); > + > + init.parent_names = &parent_name; > + init.num_parents = 1; > + init.flags = 0; > + init.name = "hdmi_pclk"; > + init.ops = &phy_clk_ops; > + > + phy->hw.init = &init; > + > + phyclk = devm_clk_register(dev, &phy->hw); > + if (IS_ERR(phyclk)) > + return dev_err_probe(dev, PTR_ERR(phyclk), > + "failed to register clock\n"); > + > + ret = of_clk_add_provider(np, of_clk_src_simple_get, phyclk); > + if (ret) > + return dev_err_probe(dev, ret, > + "failed to register clock provider\n"); > + > + return 0; > +} > + > +static int fsl_samsung_hdmi_phy_probe(struct platform_device *pdev) > +{ > + struct fsl_samsung_hdmi_phy *phy; > + int ret; > + > + phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); > + if (!phy) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, phy); > + phy->dev = &pdev->dev; > + > + phy->regs = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(phy->regs)) > + return PTR_ERR(phy->regs); > + > + phy->apbclk = devm_clk_get(phy->dev, "apb"); > + if (IS_ERR(phy->apbclk)) > + return dev_err_probe(phy->dev, PTR_ERR(phy->apbclk), > + "failed to get apb clk\n"); > + > + phy->refclk = devm_clk_get(phy->dev, "ref"); > + if (IS_ERR(phy->refclk)) > + return dev_err_probe(phy->dev, PTR_ERR(phy->refclk), > + "failed to get ref clk\n"); > + > + ret = clk_prepare_enable(phy->apbclk); > + if (ret) { > + dev_err(phy->dev, "failed to enable apbclk\n"); > + return ret; > + } > + > + pm_runtime_get_noresume(phy->dev); > + pm_runtime_set_active(phy->dev); > + pm_runtime_enable(phy->dev); > + > + ret = phy_clk_register(phy); > + if (ret) { > + dev_err(&pdev->dev, "register clk failed\n"); > + goto register_clk_failed; > + } > + > + pm_runtime_put(phy->dev); > + > + return 0; > + > +register_clk_failed: > + clk_disable_unprepare(phy->apbclk); > + > + return ret; > +} > + > +static int fsl_samsung_hdmi_phy_remove(struct platform_device *pdev) > +{ > + of_clk_del_provider(pdev->dev.of_node); > + > + return 0; > +} > + > +static int fsl_samsung_hdmi_phy_suspend(struct device *dev) > +{ > + struct fsl_samsung_hdmi_phy *phy = dev_get_drvdata(dev); > + > + clk_disable_unprepare(phy->apbclk); > + > + return 0; > +} > + > +static int fsl_samsung_hdmi_phy_resume(struct device *dev) > +{ > + struct fsl_samsung_hdmi_phy *phy = dev_get_drvdata(dev); > + int ret = 0; > + > + ret = clk_prepare_enable(phy->apbclk); > + if (ret) { > + dev_err(phy->dev, "failed to enable apbclk\n"); > + return ret; > + } > + > + if (phy->cur_cfg) > + ret = fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg); > + > + return ret; > + > +} > + > +DEFINE_RUNTIME_DEV_PM_OPS(fsl_samsung_hdmi_phy_pm_ops, > + fsl_samsung_hdmi_phy_suspend, > + fsl_samsung_hdmi_phy_resume, NULL); > + > +static const struct of_device_id fsl_samsung_hdmi_phy_of_match[] = { > + { > + .compatible = "fsl,imx8mp-hdmi-phy", > + }, { > + /* sentinel */ > + } > +}; > +MODULE_DEVICE_TABLE(of, fsl_samsung_hdmi_phy_of_match); > + > +static struct platform_driver fsl_samsung_hdmi_phy_driver = { > + .probe = fsl_samsung_hdmi_phy_probe, > + .remove = fsl_samsung_hdmi_phy_remove, > + .driver = { > + .name = "fsl-samsung-hdmi-phy", > + .of_match_table = fsl_samsung_hdmi_phy_of_match, > + .pm = pm_ptr(&fsl_samsung_hdmi_phy_pm_ops), > + }, > +}; > +module_platform_driver(fsl_samsung_hdmi_phy_driver); > + > +MODULE_AUTHOR("Sandor Yu <Sandor.yu@nxp.com>"); > +MODULE_DESCRIPTION("SAMSUNG HDMI 2.0 Transmitter PHY Driver"); > +MODULE_LICENSE("GPL v2"); > -- > 2.30.2
On Thu, 15 Dec 2022 21:11:00 +0100 Lucas Stach <l.stach@pengutronix.de> wrote: > This adds the driver for the Samsung HDMI PHY found on the > i.MX8MP SoC. Based on downstream implementation from > Sandor Yu <Sandor.yu@nxp.com>. > > Co-developed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Hi Lucas, On Thu, Dec 15, 2022 at 09:11:00PM +0100, Lucas Stach wrote: > This adds the driver for the Samsung HDMI PHY found on the > i.MX8MP SoC. Based on downstream implementation from > Sandor Yu <Sandor.yu@nxp.com>. > > Co-developed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> I've successfully tested this patch on our custom i.MX8MP board. The test case was basically "cat /dev/urandom > /dev/fb1" with a 800x480 HDMI display. Therefore please feel free to add: Tested-by: Richard Leitner <richard.leitner@skidata.com> > --- > v2: use DEFINE_RUNTIME_DEV_PM_OPS > --- > drivers/phy/freescale/Kconfig | 6 + > drivers/phy/freescale/Makefile | 1 + > drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 694 +++++++++++++++++++ > 3 files changed, 701 insertions(+) > create mode 100644 drivers/phy/freescale/phy-fsl-samsung-hdmi.c
On 15.12.22 21:11, Lucas Stach wrote: > This adds the driver for the Samsung HDMI PHY found on the > i.MX8MP SoC. Based on downstream implementation from > Sandor Yu <Sandor.yu@nxp.com>. > > Co-developed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > Tested-by: Richard Leitner <richard.leitner@skidata.com> I tested this on our Kontron BL i.MX8MP board. Feel free to add: Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> Lucas, any chance that you can revive this series and bring it over the finish line?
Hi Vinod, Am Freitag, dem 13.01.2023 um 23:24 +0530 schrieb Vinod Koul: > On 15-12-22, 21:11, Lucas Stach wrote: > > This adds the driver for the Samsung HDMI PHY found on the > > i.MX8MP SoC. Based on downstream implementation from > > Sandor Yu <Sandor.yu@nxp.com>. > > > > Co-developed-by: Marco Felsch <m.felsch@pengutronix.de> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > --- > > v2: use DEFINE_RUNTIME_DEV_PM_OPS > > --- > > drivers/phy/freescale/Kconfig | 6 + > > drivers/phy/freescale/Makefile | 1 + > > drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 694 +++++++++++++++++++ > > 3 files changed, 701 insertions(+) > > create mode 100644 drivers/phy/freescale/phy-fsl-samsung-hdmi.c > > > > diff --git a/drivers/phy/freescale/Kconfig b/drivers/phy/freescale/Kconfig > > index 853958fb2c06..5c2b73042dfc 100644 > > --- a/drivers/phy/freescale/Kconfig > > +++ b/drivers/phy/freescale/Kconfig > > @@ -35,6 +35,12 @@ config PHY_FSL_IMX8M_PCIE > > Enable this to add support for the PCIE PHY as found on > > i.MX8M family of SOCs. > > > > +config PHY_FSL_SAMSUNG_HDMI_PHY > > + tristate "Samsung HDMI PHY support" > > + depends on OF && HAS_IOMEM > > + help > > + Enable this to add support for the Samsung HDMI PHY in i.MX8MP. > > + > > endif > > > > config PHY_FSL_LYNX_28G > > this new should come after this one... > > > diff --git a/drivers/phy/freescale/Makefile b/drivers/phy/freescale/Makefile > > index cedb328bc4d2..c4386bfdb853 100644 > > --- a/drivers/phy/freescale/Makefile > > +++ b/drivers/phy/freescale/Makefile > > @@ -4,3 +4,4 @@ obj-$(CONFIG_PHY_MIXEL_LVDS_PHY) += phy-fsl-imx8qm-lvds-phy.o > > obj-$(CONFIG_PHY_MIXEL_MIPI_DPHY) += phy-fsl-imx8-mipi-dphy.o > > obj-$(CONFIG_PHY_FSL_IMX8M_PCIE) += phy-fsl-imx8m-pcie.o > > obj-$(CONFIG_PHY_FSL_LYNX_28G) += phy-fsl-lynx-28g.o > > +obj-$(CONFIG_PHY_FSL_SAMSUNG_HDMI_PHY) += phy-fsl-samsung-hdmi.o > > diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > > new file mode 100644 > > index 000000000000..185244dcb810 > > --- /dev/null > > +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > > @@ -0,0 +1,694 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyright 2020 NXP > > + * Copyright 2022 Pengutronix, Lucas Stach <kernel@pengutronix.de> > > + */ > > + > > +#include <linux/clk-provider.h> > > +#include <linux/clk.h> > > +#include <linux/delay.h> > > +#include <linux/io.h> > > +#include <linux/iopoll.h> > > +#include <linux/module.h> > > +#include <linux/of_device.h> > > +#include <linux/of.h> > > +#include <linux/platform_device.h> > > +#include <linux/pm_runtime.h> > > + > > +#define PHY_REG_00 0x00 > > +#define PHY_REG_01 0x04 > > +#define PHY_REG_02 0x08 > > +#define PHY_REG_08 0x20 > > +#define PHY_REG_09 0x24 > > +#define PHY_REG_10 0x28 > > +#define PHY_REG_11 0x2c > > No names for regs? Unfortunately yes. While the reference manual documents the bitfields in the regs, it doesn't give them any descriptive names, but just those consecutive numbers. I don't think it would be a good idea to deviate from the reference manual here. > > > + > > +#define PHY_REG_12 0x30 > > +#define REG12_FLD_CK_DIV(x) (((x) & 0x3) << 4) > > GENMASK() pls Okay. > > > +#define REG12_TMDS_CLK 0x0 > > +#define REG12_TMDS_CLK_DIV2 0x1 > > +#define REG12_TMDS_CLK_DIV4 0x2 > > +#define REG12_TMDS_CLK_DIV8 0x3 > > + > > +#define PHY_REG_13 0x34 > > +#define REG13_FLD_TG_CODE_LOW(x) (x & 0xff) > > + > > +#define PHY_REG_14 0x38 > > +#define REG14_FLD_TOL(x) ((x & 0xf) << 4) > > +#define REG14_FLD_RP_CODE(x) ((x & 0x3) << 1) > > +#define REG14_FLD_TG_CODE_HIGH(x) ((x >> 8) & 0x1) > > FIELD_GET|PREP please Okay. > > > + > > +#define PHY_REG_15 0x3c > > +#define PHY_REG_16 0x40 > > +#define PHY_REG_17 0x44 > > +#define PHY_REG_18 0x48 > > +#define PHY_REG_19 0x4c > > +#define PHY_REG_20 0x50 > > + > > +#define PHY_REG_21 0x54 > > +#define REG21_SEL_TX_CK_INV BIT(7) > > +#define REG21_PMS_S(x) (x & 0xf) > > + > > +#define PHY_REG_22 0x58 > > +#define PHY_REG_23 0x5c > > +#define PHY_REG_24 0x60 > > +#define PHY_REG_25 0x64 > > +#define PHY_REG_26 0x68 > > +#define PHY_REG_27 0x6c > > +#define PHY_REG_28 0x70 > > +#define PHY_REG_29 0x74 > > +#define PHY_REG_30 0x78 > > +#define PHY_REG_31 0x7c > > +#define PHY_REG_32 0x80 > > + > > +#define PHY_REG_33 0x84 > > +#define REG33_MODE_SET_DONE BIT(7) > > +#define REG33_FIX_DA BIT(1) > > + > > +#define PHY_REG_34 0x88 > > +#define REG34_PHY_READY BIT(7) > > +#define REG34_PLL_LOCK BIT(6) > > +#define REG34_PHY_CLK_READY BIT(5) > > + > > +#define PHY_REG_35 0x8c > > +#define PHY_REG_36 0x90 > > +#define PHY_REG_37 0x94 > > +#define PHY_REG_38 0x98 > > +#define PHY_REG_39 0x9c > > +#define PHY_REG_40 0xa0 > > +#define PHY_REG_41 0xa4 > > +#define PHY_REG_42 0xa8 > > +#define PHY_REG_43 0xac > > +#define PHY_REG_44 0xb0 > > +#define PHY_REG_45 0xb4 > > +#define PHY_REG_46 0xb8 > > +#define PHY_REG_47 0xbc > > + > > +#define PHY_PLL_DIV_REGS_NUM 6 > > + > > +struct phy_config { > > + u32 pixclk; > > + u8 pll_div_regs[PHY_PLL_DIV_REGS_NUM]; > > +}; > > + > > +const struct phy_config phy_pll_cfg[] = { > > + { > > + .pixclk = 22250000, > > + .pll_div_regs = { 0x4B, 0xF1, 0x89, 0x88, 0x80, 0x40 }, > > small case for hex numbers pls Ack. > > > + }, { > > + .pixclk = 23750000, > > + .pll_div_regs = { 0x50, 0xF1, 0x86, 0x85, 0x80, 0x40 }, > > + },{ > > [...] > > + .pixclk = 288000000, > > + .pll_div_regs = { 0x78, 0x10, 0x00, 0x00, 0x80, 0x00 }, > > + }, { > > + .pixclk = 297000000, > > + .pll_div_regs = { 0x7B, 0x15, 0x84, 0x03, 0x90, 0x45 }, > > + }, > > lots of magic numbers! Yes. Those are mostly tuning values for the PLL and I don't know if there is any computational way to come up with those numbers, so we're just using the values validated in downstream. > > > +}; > > + > > +struct reg_settings { > > + u8 reg; > > + u8 val; > > +}; > > + > > +const struct reg_settings common_phy_cfg[] = { > > + { PHY_REG_00, 0x00 }, { PHY_REG_01, 0xD1 }, > > + { PHY_REG_08, 0x4f }, { PHY_REG_09, 0x30 }, > > + { PHY_REG_10, 0x33 }, { PHY_REG_11, 0x65 }, > > + /* REG12 pixclk specific */ > > + /* REG13 pixclk specific */ > > + /* REG14 pixclk specific */ > > + { PHY_REG_15, 0x80 }, { PHY_REG_16, 0x6C }, > > + { PHY_REG_17, 0xF2 }, { PHY_REG_18, 0x67 }, > > + { PHY_REG_19, 0x00 }, { PHY_REG_20, 0x10 }, > > + /* REG21 pixclk specific */ > > + { PHY_REG_22, 0x30 }, { PHY_REG_23, 0x32 }, > > + { PHY_REG_24, 0x60 }, { PHY_REG_25, 0x8F }, > > + { PHY_REG_26, 0x00 }, { PHY_REG_27, 0x00 }, > > + { PHY_REG_28, 0x08 }, { PHY_REG_29, 0x00 }, > > + { PHY_REG_30, 0x00 }, { PHY_REG_31, 0x00 }, > > + { PHY_REG_32, 0x00 }, { PHY_REG_33, 0x80 }, > > + { PHY_REG_34, 0x00 }, { PHY_REG_35, 0x00 }, > > + { PHY_REG_36, 0x00 }, { PHY_REG_37, 0x00 }, > > + { PHY_REG_38, 0x00 }, { PHY_REG_39, 0x00 }, > > + { PHY_REG_40, 0x00 }, { PHY_REG_41, 0xE0 }, > > + { PHY_REG_42, 0x83 }, { PHY_REG_43, 0x0F }, > > + { PHY_REG_44, 0x3E }, { PHY_REG_45, 0xF8 }, > > + { PHY_REG_46, 0x00 }, { PHY_REG_47, 0x00 } > > +}; > > + > > +struct fsl_samsung_hdmi_phy { > > + struct device *dev; > > + void __iomem *regs; > > + struct clk *apbclk; > > + struct clk *refclk; > > + > > + /* clk provider */ > > + struct clk_hw hw; > > + const struct phy_config *cur_cfg; > > +}; > > + > > +static inline struct fsl_samsung_hdmi_phy * > > +to_fsl_samsung_hdmi_phy(struct clk_hw *hw) > > +{ > > + return container_of(hw, struct fsl_samsung_hdmi_phy, hw); > > +} > > + > > +static void > > +fsl_samsung_hdmi_phy_configure_pixclk(struct fsl_samsung_hdmi_phy *phy, > > + const struct phy_config *cfg) > > +{ > > + u8 div; > > + > > + switch (cfg->pixclk) { > > + case 22250000 ... 33750000: div = 0xf; break; > > + case 35000000 ... 40000000: div = 0xb; break; > > + case 43200000 ... 47500000: div = 0x9; break; > > + case 50349650 ... 63500000: div = 0x7; break; > > + case 67500000 ... 90000000: div = 0x5; break; > > + case 94000000 ... 148500000: div = 0x3; break; > > + case 154000000 ... 297000000: div = 0x1; break; > > lets do proper linux style please Do you mean moving the statements to separate lines? Regards, Lucas
On 05-09-23, 12:23, Lucas Stach wrote: > > lots of magic numbers! > > Yes. Those are mostly tuning values for the PLL and I don't know if > there is any computational way to come up with those numbers, so we're > just using the values validated in downstream. ok > > > > > > +}; > > > + > > > +struct reg_settings { > > > + u8 reg; > > > + u8 val; > > > +}; > > > + > > > +const struct reg_settings common_phy_cfg[] = { > > > + { PHY_REG_00, 0x00 }, { PHY_REG_01, 0xD1 }, > > > + { PHY_REG_08, 0x4f }, { PHY_REG_09, 0x30 }, > > > + { PHY_REG_10, 0x33 }, { PHY_REG_11, 0x65 }, > > > + /* REG12 pixclk specific */ > > > + /* REG13 pixclk specific */ > > > + /* REG14 pixclk specific */ > > > + { PHY_REG_15, 0x80 }, { PHY_REG_16, 0x6C }, > > > + { PHY_REG_17, 0xF2 }, { PHY_REG_18, 0x67 }, > > > + { PHY_REG_19, 0x00 }, { PHY_REG_20, 0x10 }, > > > + /* REG21 pixclk specific */ > > > + { PHY_REG_22, 0x30 }, { PHY_REG_23, 0x32 }, > > > + { PHY_REG_24, 0x60 }, { PHY_REG_25, 0x8F }, > > > + { PHY_REG_26, 0x00 }, { PHY_REG_27, 0x00 }, > > > + { PHY_REG_28, 0x08 }, { PHY_REG_29, 0x00 }, > > > + { PHY_REG_30, 0x00 }, { PHY_REG_31, 0x00 }, > > > + { PHY_REG_32, 0x00 }, { PHY_REG_33, 0x80 }, > > > + { PHY_REG_34, 0x00 }, { PHY_REG_35, 0x00 }, > > > + { PHY_REG_36, 0x00 }, { PHY_REG_37, 0x00 }, > > > + { PHY_REG_38, 0x00 }, { PHY_REG_39, 0x00 }, > > > + { PHY_REG_40, 0x00 }, { PHY_REG_41, 0xE0 }, > > > + { PHY_REG_42, 0x83 }, { PHY_REG_43, 0x0F }, > > > + { PHY_REG_44, 0x3E }, { PHY_REG_45, 0xF8 }, > > > + { PHY_REG_46, 0x00 }, { PHY_REG_47, 0x00 } > > > +}; > > > + > > > +struct fsl_samsung_hdmi_phy { > > > + struct device *dev; > > > + void __iomem *regs; > > > + struct clk *apbclk; > > > + struct clk *refclk; > > > + > > > + /* clk provider */ > > > + struct clk_hw hw; > > > + const struct phy_config *cur_cfg; > > > +}; > > > + > > > +static inline struct fsl_samsung_hdmi_phy * > > > +to_fsl_samsung_hdmi_phy(struct clk_hw *hw) > > > +{ > > > + return container_of(hw, struct fsl_samsung_hdmi_phy, hw); > > > +} > > > + > > > +static void > > > +fsl_samsung_hdmi_phy_configure_pixclk(struct fsl_samsung_hdmi_phy *phy, > > > + const struct phy_config *cfg) > > > +{ > > > + u8 div; > > > + > > > + switch (cfg->pixclk) { > > > + case 22250000 ... 33750000: div = 0xf; break; > > > + case 35000000 ... 40000000: div = 0xb; break; > > > + case 43200000 ... 47500000: div = 0x9; break; > > > + case 50349650 ... 63500000: div = 0x7; break; > > > + case 67500000 ... 90000000: div = 0x5; break; > > > + case 94000000 ... 148500000: div = 0x3; break; > > > + case 154000000 ... 297000000: div = 0x1; break; > > > > lets do proper linux style please > > Do you mean moving the statements to separate lines? Yes pls. Also check with scripts/checkpatch.pl --strict
diff --git a/drivers/phy/freescale/Kconfig b/drivers/phy/freescale/Kconfig index 853958fb2c06..5c2b73042dfc 100644 --- a/drivers/phy/freescale/Kconfig +++ b/drivers/phy/freescale/Kconfig @@ -35,6 +35,12 @@ config PHY_FSL_IMX8M_PCIE Enable this to add support for the PCIE PHY as found on i.MX8M family of SOCs. +config PHY_FSL_SAMSUNG_HDMI_PHY + tristate "Samsung HDMI PHY support" + depends on OF && HAS_IOMEM + help + Enable this to add support for the Samsung HDMI PHY in i.MX8MP. + endif config PHY_FSL_LYNX_28G diff --git a/drivers/phy/freescale/Makefile b/drivers/phy/freescale/Makefile index cedb328bc4d2..c4386bfdb853 100644 --- a/drivers/phy/freescale/Makefile +++ b/drivers/phy/freescale/Makefile @@ -4,3 +4,4 @@ obj-$(CONFIG_PHY_MIXEL_LVDS_PHY) += phy-fsl-imx8qm-lvds-phy.o obj-$(CONFIG_PHY_MIXEL_MIPI_DPHY) += phy-fsl-imx8-mipi-dphy.o obj-$(CONFIG_PHY_FSL_IMX8M_PCIE) += phy-fsl-imx8m-pcie.o obj-$(CONFIG_PHY_FSL_LYNX_28G) += phy-fsl-lynx-28g.o +obj-$(CONFIG_PHY_FSL_SAMSUNG_HDMI_PHY) += phy-fsl-samsung-hdmi.o diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c new file mode 100644 index 000000000000..185244dcb810 --- /dev/null +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c @@ -0,0 +1,694 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2020 NXP + * Copyright 2022 Pengutronix, Lucas Stach <kernel@pengutronix.de> + */ + +#include <linux/clk-provider.h> +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/io.h> +#include <linux/iopoll.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/pm_runtime.h> + +#define PHY_REG_00 0x00 +#define PHY_REG_01 0x04 +#define PHY_REG_02 0x08 +#define PHY_REG_08 0x20 +#define PHY_REG_09 0x24 +#define PHY_REG_10 0x28 +#define PHY_REG_11 0x2c + +#define PHY_REG_12 0x30 +#define REG12_FLD_CK_DIV(x) (((x) & 0x3) << 4) +#define REG12_TMDS_CLK 0x0 +#define REG12_TMDS_CLK_DIV2 0x1 +#define REG12_TMDS_CLK_DIV4 0x2 +#define REG12_TMDS_CLK_DIV8 0x3 + +#define PHY_REG_13 0x34 +#define REG13_FLD_TG_CODE_LOW(x) (x & 0xff) + +#define PHY_REG_14 0x38 +#define REG14_FLD_TOL(x) ((x & 0xf) << 4) +#define REG14_FLD_RP_CODE(x) ((x & 0x3) << 1) +#define REG14_FLD_TG_CODE_HIGH(x) ((x >> 8) & 0x1) + +#define PHY_REG_15 0x3c +#define PHY_REG_16 0x40 +#define PHY_REG_17 0x44 +#define PHY_REG_18 0x48 +#define PHY_REG_19 0x4c +#define PHY_REG_20 0x50 + +#define PHY_REG_21 0x54 +#define REG21_SEL_TX_CK_INV BIT(7) +#define REG21_PMS_S(x) (x & 0xf) + +#define PHY_REG_22 0x58 +#define PHY_REG_23 0x5c +#define PHY_REG_24 0x60 +#define PHY_REG_25 0x64 +#define PHY_REG_26 0x68 +#define PHY_REG_27 0x6c +#define PHY_REG_28 0x70 +#define PHY_REG_29 0x74 +#define PHY_REG_30 0x78 +#define PHY_REG_31 0x7c +#define PHY_REG_32 0x80 + +#define PHY_REG_33 0x84 +#define REG33_MODE_SET_DONE BIT(7) +#define REG33_FIX_DA BIT(1) + +#define PHY_REG_34 0x88 +#define REG34_PHY_READY BIT(7) +#define REG34_PLL_LOCK BIT(6) +#define REG34_PHY_CLK_READY BIT(5) + +#define PHY_REG_35 0x8c +#define PHY_REG_36 0x90 +#define PHY_REG_37 0x94 +#define PHY_REG_38 0x98 +#define PHY_REG_39 0x9c +#define PHY_REG_40 0xa0 +#define PHY_REG_41 0xa4 +#define PHY_REG_42 0xa8 +#define PHY_REG_43 0xac +#define PHY_REG_44 0xb0 +#define PHY_REG_45 0xb4 +#define PHY_REG_46 0xb8 +#define PHY_REG_47 0xbc + +#define PHY_PLL_DIV_REGS_NUM 6 + +struct phy_config { + u32 pixclk; + u8 pll_div_regs[PHY_PLL_DIV_REGS_NUM]; +}; + +const struct phy_config phy_pll_cfg[] = { + { + .pixclk = 22250000, + .pll_div_regs = { 0x4B, 0xF1, 0x89, 0x88, 0x80, 0x40 }, + }, { + .pixclk = 23750000, + .pll_div_regs = { 0x50, 0xF1, 0x86, 0x85, 0x80, 0x40 }, + },{ + .pixclk = 24000000, + .pll_div_regs = { 0x50, 0xF0, 0x00, 0x00, 0x80, 0x00 }, + },{ + .pixclk = 24024000, + .pll_div_regs = { 0x50, 0xF1, 0x99, 0x02, 0x80, 0x40 }, + }, { + .pixclk = 25175000, + .pll_div_regs = { 0x54, 0xFC, 0xCC, 0x91, 0x80, 0x40 }, + }, { + .pixclk = 25200000, + .pll_div_regs = { 0x54, 0xF0, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 26750000, + .pll_div_regs = { 0x5A, 0xF2, 0x89, 0x88, 0x80, 0x40 }, + }, { + .pixclk = 27000000, + .pll_div_regs = { 0x5A, 0xF0, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 27027000, + .pll_div_regs = { 0x5A, 0xF2, 0xFD, 0x0C, 0x80, 0x40 }, + }, { + .pixclk = 29500000, + .pll_div_regs = { 0x62, 0xF4, 0x95, 0x08, 0x80, 0x40 }, + }, { + .pixclk = 30750000, + .pll_div_regs = { 0x66, 0xF4, 0x82, 0x01, 0x88, 0x45 }, + }, { + .pixclk = 30888000, + .pll_div_regs = { 0x66, 0xF4, 0x99, 0x18, 0x88, 0x45 }, + }, { + .pixclk = 33750000, + .pll_div_regs = { 0x70, 0xF4, 0x82, 0x01, 0x80, 0x40 }, + }, { + .pixclk = 35000000, + .pll_div_regs = { 0x58, 0xB8, 0x8B, 0x88, 0x80, 0x40 }, + }, { + .pixclk = 36000000, + .pll_div_regs = { 0x5A, 0xB0, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 36036000, + .pll_div_regs = { 0x5A, 0xB2, 0xFD, 0x0C, 0x80, 0x40 }, + }, { + .pixclk = 40000000, + .pll_div_regs = { 0x64, 0xB0, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 43200000, + .pll_div_regs = { 0x5A, 0x90, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 43243200, + .pll_div_regs = { 0x5A, 0x92, 0xFD, 0x0C, 0x80, 0x40 }, + }, { + .pixclk = 44500000, + .pll_div_regs = { 0x5C, 0x92, 0x98, 0x11, 0x84, 0x41 }, + }, { + .pixclk = 47000000, + .pll_div_regs = { 0x62, 0x94, 0x95, 0x82, 0x80, 0x40 }, + }, { + .pixclk = 47500000, + .pll_div_regs = { 0x63, 0x96, 0xA1, 0x82, 0x80, 0x40 }, + }, { + .pixclk = 50349650, + .pll_div_regs = { 0x54, 0x7C, 0xC3, 0x8F, 0x80, 0x40 }, + }, { + .pixclk = 50400000, + .pll_div_regs = { 0x54, 0x70, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 53250000, + .pll_div_regs = { 0x58, 0x72, 0x84, 0x03, 0x82, 0x41 }, + }, { + .pixclk = 53500000, + .pll_div_regs = { 0x5A, 0x72, 0x89, 0x88, 0x80, 0x40 }, + }, { + .pixclk = 54000000, + .pll_div_regs = { 0x5A, 0x70, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 54054000, + .pll_div_regs = { 0x5A, 0x72, 0xFD, 0x0C, 0x80, 0x40 }, + }, { + .pixclk = 59000000, + .pll_div_regs = { 0x62, 0x74, 0x95, 0x08, 0x80, 0x40 }, + }, { + .pixclk = 59340659, + .pll_div_regs = { 0x62, 0x74, 0xDB, 0x52, 0x88, 0x47 }, + }, { + .pixclk = 59400000, + .pll_div_regs = { 0x63, 0x70, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 61500000, + .pll_div_regs = { 0x66, 0x74, 0x82, 0x01, 0x88, 0x45 }, + }, { + .pixclk = 63500000, + .pll_div_regs = { 0x69, 0x74, 0x89, 0x08, 0x80, 0x40 }, + }, { + .pixclk = 67500000, + .pll_div_regs = { 0x54, 0x52, 0x87, 0x03, 0x80, 0x40 }, + }, { + .pixclk = 70000000, + .pll_div_regs = { 0x58, 0x58, 0x8B, 0x88, 0x80, 0x40 }, + }, { + .pixclk = 72000000, + .pll_div_regs = { 0x5A, 0x50, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 72072000, + .pll_div_regs = { 0x5A, 0x52, 0xFD, 0x0C, 0x80, 0x40 }, + }, { + .pixclk = 74176000, + .pll_div_regs = { 0x5D, 0x58, 0xDB, 0xA2, 0x88, 0x41 }, + }, { + .pixclk = 74250000, + .pll_div_regs = { 0x5C, 0x52, 0x90, 0x0D, 0x84, 0x41 }, + }, { + .pixclk = 78500000, + .pll_div_regs = { 0x62, 0x54, 0x87, 0x01, 0x80, 0x40 }, + }, { + .pixclk = 80000000, + .pll_div_regs = { 0x64, 0x50, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 82000000, + .pll_div_regs = { 0x66, 0x54, 0x82, 0x01, 0x88, 0x45 }, + }, { + .pixclk = 82500000, + .pll_div_regs = { 0x67, 0x54, 0x88, 0x01, 0x90, 0x49 }, + }, { + .pixclk = 89000000, + .pll_div_regs = { 0x70, 0x54, 0x84, 0x83, 0x80, 0x40 }, + }, { + .pixclk = 90000000, + .pll_div_regs = { 0x70, 0x54, 0x82, 0x01, 0x80, 0x40 }, + }, { + .pixclk = 94000000, + .pll_div_regs = { 0x4E, 0x32, 0xA7, 0x10, 0x80, 0x40 }, + }, { + .pixclk = 95000000, + .pll_div_regs = { 0x50, 0x31, 0x86, 0x85, 0x80, 0x40 }, + }, { + .pixclk = 98901099, + .pll_div_regs = { 0x52, 0x3A, 0xDB, 0x4C, 0x88, 0x47 }, + }, { + .pixclk = 99000000, + .pll_div_regs = { 0x52, 0x32, 0x82, 0x01, 0x88, 0x47 }, + }, { + .pixclk = 100699300, + .pll_div_regs = { 0x54, 0x3C, 0xC3, 0x8F, 0x80, 0x40 }, + }, { + .pixclk = 100800000, + .pll_div_regs = { 0x54, 0x30, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 102500000, + .pll_div_regs = { 0x55, 0x32, 0x8C, 0x05, 0x90, 0x4B }, + }, { + .pixclk = 104750000, + .pll_div_regs = { 0x57, 0x32, 0x98, 0x07, 0x90, 0x49 }, + }, { + .pixclk = 106500000, + .pll_div_regs = { 0x58, 0x32, 0x84, 0x03, 0x82, 0x41 }, + }, { + .pixclk = 107000000, + .pll_div_regs = { 0x5A, 0x32, 0x89, 0x88, 0x80, 0x40 }, + }, { + .pixclk = 108000000, + .pll_div_regs = { 0x5A, 0x30, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 108108000, + .pll_div_regs = { 0x5A, 0x32, 0xFD, 0x0C, 0x80, 0x40 }, + }, { + .pixclk = 118000000, + .pll_div_regs = { 0x62, 0x34, 0x95, 0x08, 0x80, 0x40 }, + }, { + .pixclk = 118800000, + .pll_div_regs = { 0x63, 0x30, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 123000000, + .pll_div_regs = { 0x66, 0x34, 0x82, 0x01, 0x88, 0x45 }, + }, { + .pixclk = 127000000, + .pll_div_regs = { 0x69, 0x34, 0x89, 0x08, 0x80, 0x40 }, + }, { + .pixclk = 135000000, + .pll_div_regs = { 0x70, 0x34, 0x82, 0x01, 0x80, 0x40 }, + }, { + .pixclk = 135580000, + .pll_div_regs = { 0x71, 0x39, 0xE9, 0x82, 0x9C, 0x5B }, + }, { + .pixclk = 137520000, + .pll_div_regs = { 0x72, 0x38, 0x99, 0x10, 0x85, 0x41 }, + }, { + .pixclk = 138750000, + .pll_div_regs = { 0x73, 0x35, 0x88, 0x05, 0x90, 0x4D }, + }, { + .pixclk = 140000000, + .pll_div_regs = { 0x75, 0x36, 0xA7, 0x90, 0x80, 0x40 }, + }, { + .pixclk = 144000000, + .pll_div_regs = { 0x78, 0x30, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 148352000, + .pll_div_regs = { 0x7B, 0x35, 0xDB, 0x39, 0x90, 0x45 }, + }, { + .pixclk = 148500000, + .pll_div_regs = { 0x7B, 0x35, 0x84, 0x03, 0x90, 0x45 }, + }, { + .pixclk = 154000000, + .pll_div_regs = { 0x40, 0x18, 0x83, 0x01, 0x00, 0x40 }, + }, { + .pixclk = 157000000, + .pll_div_regs = { 0x41, 0x11, 0xA7, 0x14, 0x80, 0x40 }, + }, { + .pixclk = 160000000, + .pll_div_regs = { 0x42, 0x12, 0xA1, 0x20, 0x80, 0x40 }, + }, { + .pixclk = 162000000, + .pll_div_regs = { 0x43, 0x18, 0x8B, 0x08, 0x96, 0x55 }, + }, { + .pixclk = 164000000, + .pll_div_regs = { 0x45, 0x11, 0x83, 0x82, 0x90, 0x4B }, + }, { + .pixclk = 165000000, + .pll_div_regs = { 0x45, 0x11, 0x84, 0x81, 0x90, 0x4B }, + }, { + .pixclk = 180000000, + .pll_div_regs = { 0x4B, 0x10, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 185625000, + .pll_div_regs = { 0x4E, 0x12, 0x9A, 0x95, 0x80, 0x40 }, + }, { + .pixclk = 188000000, + .pll_div_regs = { 0x4E, 0x12, 0xA7, 0x10, 0x80, 0x40 }, + }, { + .pixclk = 198000000, + .pll_div_regs = { 0x52, 0x12, 0x82, 0x01, 0x88, 0x47 }, + }, { + .pixclk = 205000000, + .pll_div_regs = { 0x55, 0x12, 0x8C, 0x05, 0x90, 0x4B }, + }, { + .pixclk = 209500000, + .pll_div_regs = { 0x57, 0x12, 0x98, 0x07, 0x90, 0x49 }, + }, { + .pixclk = 213000000, + .pll_div_regs = { 0x58, 0x12, 0x84, 0x03, 0x82, 0x41 }, + }, { + .pixclk = 216000000, + .pll_div_regs = { 0x5A, 0x10, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 216216000, + .pll_div_regs = { 0x5A, 0x12, 0xFD, 0x0C, 0x80, 0x40 }, + }, { + .pixclk = 237600000, + .pll_div_regs = { 0x63, 0x10, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 254000000, + .pll_div_regs = { 0x69, 0x14, 0x89, 0x08, 0x80, 0x40 }, + }, { + .pixclk = 277500000, + .pll_div_regs = { 0x73, 0x15, 0x88, 0x05, 0x90, 0x4D }, + }, { + .pixclk = 288000000, + .pll_div_regs = { 0x78, 0x10, 0x00, 0x00, 0x80, 0x00 }, + }, { + .pixclk = 297000000, + .pll_div_regs = { 0x7B, 0x15, 0x84, 0x03, 0x90, 0x45 }, + }, +}; + +struct reg_settings { + u8 reg; + u8 val; +}; + +const struct reg_settings common_phy_cfg[] = { + { PHY_REG_00, 0x00 }, { PHY_REG_01, 0xD1 }, + { PHY_REG_08, 0x4f }, { PHY_REG_09, 0x30 }, + { PHY_REG_10, 0x33 }, { PHY_REG_11, 0x65 }, + /* REG12 pixclk specific */ + /* REG13 pixclk specific */ + /* REG14 pixclk specific */ + { PHY_REG_15, 0x80 }, { PHY_REG_16, 0x6C }, + { PHY_REG_17, 0xF2 }, { PHY_REG_18, 0x67 }, + { PHY_REG_19, 0x00 }, { PHY_REG_20, 0x10 }, + /* REG21 pixclk specific */ + { PHY_REG_22, 0x30 }, { PHY_REG_23, 0x32 }, + { PHY_REG_24, 0x60 }, { PHY_REG_25, 0x8F }, + { PHY_REG_26, 0x00 }, { PHY_REG_27, 0x00 }, + { PHY_REG_28, 0x08 }, { PHY_REG_29, 0x00 }, + { PHY_REG_30, 0x00 }, { PHY_REG_31, 0x00 }, + { PHY_REG_32, 0x00 }, { PHY_REG_33, 0x80 }, + { PHY_REG_34, 0x00 }, { PHY_REG_35, 0x00 }, + { PHY_REG_36, 0x00 }, { PHY_REG_37, 0x00 }, + { PHY_REG_38, 0x00 }, { PHY_REG_39, 0x00 }, + { PHY_REG_40, 0x00 }, { PHY_REG_41, 0xE0 }, + { PHY_REG_42, 0x83 }, { PHY_REG_43, 0x0F }, + { PHY_REG_44, 0x3E }, { PHY_REG_45, 0xF8 }, + { PHY_REG_46, 0x00 }, { PHY_REG_47, 0x00 } +}; + +struct fsl_samsung_hdmi_phy { + struct device *dev; + void __iomem *regs; + struct clk *apbclk; + struct clk *refclk; + + /* clk provider */ + struct clk_hw hw; + const struct phy_config *cur_cfg; +}; + +static inline struct fsl_samsung_hdmi_phy * +to_fsl_samsung_hdmi_phy(struct clk_hw *hw) +{ + return container_of(hw, struct fsl_samsung_hdmi_phy, hw); +} + +static void +fsl_samsung_hdmi_phy_configure_pixclk(struct fsl_samsung_hdmi_phy *phy, + const struct phy_config *cfg) +{ + u8 div; + + switch (cfg->pixclk) { + case 22250000 ... 33750000: div = 0xf; break; + case 35000000 ... 40000000: div = 0xb; break; + case 43200000 ... 47500000: div = 0x9; break; + case 50349650 ... 63500000: div = 0x7; break; + case 67500000 ... 90000000: div = 0x5; break; + case 94000000 ... 148500000: div = 0x3; break; + case 154000000 ... 297000000: div = 0x1; break; + } + + writeb(REG21_SEL_TX_CK_INV | REG21_PMS_S(div), phy->regs + PHY_REG_21); +} + +static void +fsl_samsung_hdmi_phy_configure_pll_lock_det(struct fsl_samsung_hdmi_phy *phy, + const struct phy_config *cfg) +{ + u32 pclk = cfg->pixclk; + u32 fld_tg_code; + u32 pclk_khz; + u8 div; + + switch (cfg->pixclk) { + case 22250000 ... 47500000: div = 1; break; + case 50349650 ... 99000000: div = 2; break; + case 100699300 ... 198000000: div = 4; break; + case 205000000 ... 297000000: div = 8; break; + } + + writeb(REG12_FLD_CK_DIV(fls(div) - 1), phy->regs + PHY_REG_12); + + /* + * Calculation for the frequency lock detector target code (fld_tg_code) + * is based on reference manual register description of PHY_REG13 + * (13.10.3.1.14.2): + * 1st) Calculate int_pllclk which is determinded by FLD_CK_DIV + * 2nd) Increase resolution to avoid rounding issues + * 3th) Do the div (256 / Freq. of int_pllclk) * 24 + * 4th) Reduce the resolution and always round up since the NXP + * settings rounding up always too. TODO: Check if that is + * correct. + */ + pclk /= div; + pclk_khz = pclk / 1000; + fld_tg_code = 256 * 1000 * 1000 / pclk_khz * 24; + fld_tg_code = DIV_ROUND_UP(fld_tg_code, 1000); + + /* FLD_TOL and FLD_RP_CODE taken from downstream driver */ + writeb(REG14_FLD_TOL(2) | REG14_FLD_RP_CODE(2) | + REG14_FLD_TG_CODE_HIGH(fld_tg_code), phy->regs + PHY_REG_14); + writeb(REG13_FLD_TG_CODE_LOW(fld_tg_code), phy->regs + PHY_REG_13); +} + +static int fsl_samsung_hdmi_phy_configure(struct fsl_samsung_hdmi_phy *phy, + const struct phy_config *cfg) +{ + int i, ret; + u8 val; + + /* HDMI PHY init */ + writeb(REG33_FIX_DA, phy->regs + PHY_REG_33); + + /* Common PHY registers registers */ + for (i = 0; i < ARRAY_SIZE(common_phy_cfg); i++) + writeb(common_phy_cfg[i].val, phy->regs + common_phy_cfg[i].reg); + + /* Set individual PLL registers PHY_REG2 ... PHY_REG7 */ + for (i = 0; i < PHY_PLL_DIV_REGS_NUM; i++) + writeb(cfg->pll_div_regs[i], phy->regs + PHY_REG_02 + i * 4); + + fsl_samsung_hdmi_phy_configure_pixclk(phy, cfg); + fsl_samsung_hdmi_phy_configure_pll_lock_det(phy, cfg); + + writeb(REG33_FIX_DA | REG33_MODE_SET_DONE , phy->regs + PHY_REG_33); + + ret = readb_poll_timeout(phy->regs + PHY_REG_34, val, + val & REG34_PLL_LOCK, + 50, 20000); + if (ret) + dev_err(phy->dev, "PLL failed to lock\n"); + + return ret; +} + +static unsigned long phy_clk_recalc_rate(struct clk_hw *hw, + unsigned long parent_rate) +{ + struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw); + + if (!phy->cur_cfg) + return 74250000; + + return phy->cur_cfg->pixclk; +} + +static long phy_clk_round_rate(struct clk_hw *hw, + unsigned long rate, unsigned long *parent_rate) +{ + int i; + + for (i = ARRAY_SIZE(phy_pll_cfg) - 1; i >= 0; i--) + if (phy_pll_cfg[i].pixclk <= rate) + return phy_pll_cfg[i].pixclk; + + return -EINVAL; +} + +static int phy_clk_set_rate(struct clk_hw *hw, + unsigned long rate, unsigned long parent_rate) +{ + struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw); + int i; + + for (i = ARRAY_SIZE(phy_pll_cfg) - 1; i >= 0; i--) + if (phy_pll_cfg[i].pixclk <= rate) + break; + + if (i < 0) + return -EINVAL; + + phy->cur_cfg = &phy_pll_cfg[i]; + + return fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg); +} + +static const struct clk_ops phy_clk_ops = { + .recalc_rate = phy_clk_recalc_rate, + .round_rate = phy_clk_round_rate, + .set_rate = phy_clk_set_rate, +}; + +static int phy_clk_register(struct fsl_samsung_hdmi_phy *phy) +{ + struct device *dev = phy->dev; + struct device_node *np = dev->of_node; + struct clk_init_data init; + const char *parent_name; + struct clk *phyclk; + int ret; + + parent_name = __clk_get_name(phy->refclk); + + init.parent_names = &parent_name; + init.num_parents = 1; + init.flags = 0; + init.name = "hdmi_pclk"; + init.ops = &phy_clk_ops; + + phy->hw.init = &init; + + phyclk = devm_clk_register(dev, &phy->hw); + if (IS_ERR(phyclk)) + return dev_err_probe(dev, PTR_ERR(phyclk), + "failed to register clock\n"); + + ret = of_clk_add_provider(np, of_clk_src_simple_get, phyclk); + if (ret) + return dev_err_probe(dev, ret, + "failed to register clock provider\n"); + + return 0; +} + +static int fsl_samsung_hdmi_phy_probe(struct platform_device *pdev) +{ + struct fsl_samsung_hdmi_phy *phy; + int ret; + + phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); + if (!phy) + return -ENOMEM; + + platform_set_drvdata(pdev, phy); + phy->dev = &pdev->dev; + + phy->regs = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(phy->regs)) + return PTR_ERR(phy->regs); + + phy->apbclk = devm_clk_get(phy->dev, "apb"); + if (IS_ERR(phy->apbclk)) + return dev_err_probe(phy->dev, PTR_ERR(phy->apbclk), + "failed to get apb clk\n"); + + phy->refclk = devm_clk_get(phy->dev, "ref"); + if (IS_ERR(phy->refclk)) + return dev_err_probe(phy->dev, PTR_ERR(phy->refclk), + "failed to get ref clk\n"); + + ret = clk_prepare_enable(phy->apbclk); + if (ret) { + dev_err(phy->dev, "failed to enable apbclk\n"); + return ret; + } + + pm_runtime_get_noresume(phy->dev); + pm_runtime_set_active(phy->dev); + pm_runtime_enable(phy->dev); + + ret = phy_clk_register(phy); + if (ret) { + dev_err(&pdev->dev, "register clk failed\n"); + goto register_clk_failed; + } + + pm_runtime_put(phy->dev); + + return 0; + +register_clk_failed: + clk_disable_unprepare(phy->apbclk); + + return ret; +} + +static int fsl_samsung_hdmi_phy_remove(struct platform_device *pdev) +{ + of_clk_del_provider(pdev->dev.of_node); + + return 0; +} + +static int fsl_samsung_hdmi_phy_suspend(struct device *dev) +{ + struct fsl_samsung_hdmi_phy *phy = dev_get_drvdata(dev); + + clk_disable_unprepare(phy->apbclk); + + return 0; +} + +static int fsl_samsung_hdmi_phy_resume(struct device *dev) +{ + struct fsl_samsung_hdmi_phy *phy = dev_get_drvdata(dev); + int ret = 0; + + ret = clk_prepare_enable(phy->apbclk); + if (ret) { + dev_err(phy->dev, "failed to enable apbclk\n"); + return ret; + } + + if (phy->cur_cfg) + ret = fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg); + + return ret; + +} + +DEFINE_RUNTIME_DEV_PM_OPS(fsl_samsung_hdmi_phy_pm_ops, + fsl_samsung_hdmi_phy_suspend, + fsl_samsung_hdmi_phy_resume, NULL); + +static const struct of_device_id fsl_samsung_hdmi_phy_of_match[] = { + { + .compatible = "fsl,imx8mp-hdmi-phy", + }, { + /* sentinel */ + } +}; +MODULE_DEVICE_TABLE(of, fsl_samsung_hdmi_phy_of_match); + +static struct platform_driver fsl_samsung_hdmi_phy_driver = { + .probe = fsl_samsung_hdmi_phy_probe, + .remove = fsl_samsung_hdmi_phy_remove, + .driver = { + .name = "fsl-samsung-hdmi-phy", + .of_match_table = fsl_samsung_hdmi_phy_of_match, + .pm = pm_ptr(&fsl_samsung_hdmi_phy_pm_ops), + }, +}; +module_platform_driver(fsl_samsung_hdmi_phy_driver); + +MODULE_AUTHOR("Sandor Yu <Sandor.yu@nxp.com>"); +MODULE_DESCRIPTION("SAMSUNG HDMI 2.0 Transmitter PHY Driver"); +MODULE_LICENSE("GPL v2");