| Message ID | 20221215193245.48314-7-ayan.kumar.halder@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for 32 bit physical address | expand |
Hi, Title: Please be more specific about the component you are modifying. I.e: xen/arm: domain_build: Replace use of paddr_t in find_domU_holes() So it is clear this is no a tree-wide change. On 15/12/2022 19:32, Ayan Kumar Halder wrote: > bankbase, banksize and bankend are used to hold values of type > 'unsigned long long'. Thus, one should use 'u64' instead of 'paddr_t' To me it sounds like the code should use 'unsigned long long' rather than 'paddr_t' or 'u64'. Also, please replace any reference of u64 to uint64_t. (The same remark apply for u32 below). > (which may be either u64 or u32 depending on the architecture). That's not yet correct. So please add something like 'in the future'... > > Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@amd.com> > --- > xen/arch/arm/domain_build.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index c537514a52..e968b9812d 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1741,9 +1741,9 @@ static int __init find_domU_holes(const struct kernel_info *kinfo, > struct meminfo *ext_regions) > { > unsigned int i; > - paddr_t bankend; > - const paddr_t bankbase[] = GUEST_RAM_BANK_BASES; > - const paddr_t banksize[] = GUEST_RAM_BANK_SIZES; > + uint64_t bankend; > + const uint64_t bankbase[] = GUEST_RAM_BANK_BASES; > + const uint64_t banksize[] = GUEST_RAM_BANK_SIZES; > int res = -ENOENT; > > for ( i = 0; i < GUEST_RAM_BANKS; i++ ) Cheers,
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c537514a52..e968b9812d 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1741,9 +1741,9 @@ static int __init find_domU_holes(const struct kernel_info *kinfo, struct meminfo *ext_regions) { unsigned int i; - paddr_t bankend; - const paddr_t bankbase[] = GUEST_RAM_BANK_BASES; - const paddr_t banksize[] = GUEST_RAM_BANK_SIZES; + uint64_t bankend; + const uint64_t bankbase[] = GUEST_RAM_BANK_BASES; + const uint64_t banksize[] = GUEST_RAM_BANK_SIZES; int res = -ENOENT; for ( i = 0; i < GUEST_RAM_BANKS; i++ )
bankbase, banksize and bankend are used to hold values of type 'unsigned long long'. Thus, one should use 'u64' instead of 'paddr_t' (which may be either u64 or u32 depending on the architecture). Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@amd.com> --- xen/arch/arm/domain_build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)