mbox series

[net,v2,0/2] iavf: fix temporary deadlock and failure to set MAC address

Message ID 20221215225049.508812-1-mschmidt@redhat.com (mailing list archive)
Headers show
Series iavf: fix temporary deadlock and failure to set MAC address | expand

Message

Michal Schmidt Dec. 15, 2022, 10:50 p.m. UTC 
This fixes an issue where setting the MAC address on iavf runs into a
timeout and fails with EAGAIN.

Changes in v2:
 - Removed unused 'ret' variable in patch 1.
 - Added patch 2 to fix another cause of the same timeout.

Michal Schmidt (2):
  iavf: fix temporary deadlock and failure to set MAC address
  iavf: avoid taking rtnl_lock in adminq_task

 drivers/net/ethernet/intel/iavf/iavf.h        |   4 +-
 .../net/ethernet/intel/iavf/iavf_ethtool.c    |  10 +-
 drivers/net/ethernet/intel/iavf/iavf_main.c   | 135 ++++++++++--------
 .../net/ethernet/intel/iavf/iavf_virtchnl.c   |   8 +-
 4 files changed, 86 insertions(+), 71 deletions(-)

Comments

Alexander Duyck Dec. 16, 2022, 4:29 p.m. UTC | #1 
On Thu, 2022-12-15 at 23:50 +0100, Michal Schmidt wrote:
> This fixes an issue where setting the MAC address on iavf runs into a
> timeout and fails with EAGAIN.
> 
> Changes in v2:
>  - Removed unused 'ret' variable in patch 1.
>  - Added patch 2 to fix another cause of the same timeout.
> 
> Michal Schmidt (2):
>   iavf: fix temporary deadlock and failure to set MAC address
>   iavf: avoid taking rtnl_lock in adminq_task
> 
>  drivers/net/ethernet/intel/iavf/iavf.h        |   4 +-
>  .../net/ethernet/intel/iavf/iavf_ethtool.c    |  10 +-
>  drivers/net/ethernet/intel/iavf/iavf_main.c   | 135 ++++++++++--------
>  .../net/ethernet/intel/iavf/iavf_virtchnl.c   |   8 +-
>  4 files changed, 86 insertions(+), 71 deletions(-)
> 

The series looks good to me.

Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>