diff mbox series

[v2,4/7] hw/acpi/Kconfig: Add missing dependencies to ACPI_PIIX4

Message ID 20221216130355.41667-5-shentey@gmail.com (mailing list archive)
State New, archived
Headers show
Series Clean up dependencies of ACPI controllers | expand

Commit Message

Bernhard Beschow Dec. 16, 2022, 1:03 p.m. UTC
piix4_pm_realize() uses apm_init() and pm_smbus_init(), so both APM and
ACPI_SMBUS are provided by the device model managed by ACPI_PIIX4.

The ACPIREGS are also provided by ACPI_PIIX4, so needs to select ACPI.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/acpi/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Dec. 17, 2022, 11:23 p.m. UTC | #1
On 16/12/22 14:03, Bernhard Beschow wrote:
> piix4_pm_realize() uses apm_init() and pm_smbus_init(), so both APM and
> ACPI_SMBUS are provided by the device model managed by ACPI_PIIX4.
> 
> The ACPIREGS are also provided by ACPI_PIIX4, so needs to select ACPI.
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/acpi/Kconfig | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig
index b7006e18c8..1f7803fdab 100644
--- a/hw/acpi/Kconfig
+++ b/hw/acpi/Kconfig
@@ -31,7 +31,9 @@  config ACPI_NVDIMM
 
 config ACPI_PIIX4
     bool
-    depends on ACPI
+    select ACPI
+    select ACPI_SMBUS
+    select APM
 
 config ACPI_PCIHP
     bool