| Message ID | SI2PR02MB4603295B418781879CE88751DDE59@SI2PR02MB4603.apcprd02.prod.outlook.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [V1] usb: Fix typo in comment | expand |
On Mon, Dec 19, 2022 at 09:38:37AM +0800, Gongwei Li wrote: > From: Gongwei Li <ligongwei@kylinos.cn> > > Spelling mistake in comment. xHCI typos in usb_enable_intel_xhci_ports()? > > Signed-off-by: Gongwei Li <ligongwei@kylinos.cn> Then why did you send this from @hotmail.com (your personal) address? Please talk to your company to fix email system so that you can send to and receive from LKML. Why also not passing your personal address as --reply-to to git-send-email(1)? (Spammers tend to abuse Reply-to: header, though.) Thanks.
On 19.12.2022 3.38, Gongwei Li wrote: > From: Gongwei Li <ligongwei@kylinos.cn> > > Spelling mistake in comment. > > Signed-off-by: Gongwei Li <ligongwei@kylinos.cn> > --- > drivers/usb/host/pci-quirks.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c > index ef08d68b9714..9710425e69aa 100644 > --- a/drivers/usb/host/pci-quirks.c > +++ b/drivers/usb/host/pci-quirks.c > @@ -1103,10 +1103,10 @@ void usb_enable_intel_xhci_ports(struct pci_dev *xhci_pdev) > pci_read_config_dword(xhci_pdev, USB_INTEL_USB2PRM, > &ports_available); > > - dev_dbg(&xhci_pdev->dev, "Configurable USB 2.0 ports to hand over to xCHI: 0x%x\n", > + dev_dbg(&xhci_pdev->dev, "Configurable USB 2.0 ports to hand over to xHCI: 0x%x\n", > ports_available); > > - /* Write XUSB2PR, the xHC USB 2.0 Port Routing Register, to > + /* Write XUSB2PR, the xHCI USB 2.0 Port Routing Register, to xHC isn't a typo in this case, just refers to the actual xHC Extensible Host Controller itself. The port routing register isn't part of the xHCI specification. Thanks -Mathias
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c index ef08d68b9714..9710425e69aa 100644 --- a/drivers/usb/host/pci-quirks.c +++ b/drivers/usb/host/pci-quirks.c @@ -1103,10 +1103,10 @@ void usb_enable_intel_xhci_ports(struct pci_dev *xhci_pdev) pci_read_config_dword(xhci_pdev, USB_INTEL_USB2PRM, &ports_available); - dev_dbg(&xhci_pdev->dev, "Configurable USB 2.0 ports to hand over to xCHI: 0x%x\n", + dev_dbg(&xhci_pdev->dev, "Configurable USB 2.0 ports to hand over to xHCI: 0x%x\n", ports_available); - /* Write XUSB2PR, the xHC USB 2.0 Port Routing Register, to + /* Write XUSB2PR, the xHCI USB 2.0 Port Routing Register, to * switch the USB 2.0 power and data lines over to the xHCI * host. */