| Message ID | 20221207094921.15450-1-moudy.ho@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add support MDP3 on MT8195 platform | expand |
Whole series applied, thanks! On 07/12/2022 10:49, Moudy Ho wrote: > From: mtk18742 <moudy.ho@mediatek.com> > > Changes since v3: > - Rebase on linux-next > > Changes since v2: > - Depend on : > [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097 > - Split dts settings into two patches based on belonging to MMSYS or MUTEX. > > Changes since v1: > - Depend on : > [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097 > - Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding file. > - Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check. > - Rename mtk_mmsys_merge_config() and mtk_mmsys_rsz_dcm_config() to > mtk_mmsys_vpp_rsz_merge_config() and mtk_mmsys_vpp_rsz_dcm_config(). > - Clean up mtk_mmsys_vpp_rsz_dcm_config(). > - Add a comment to mtk_mutex_write_mod() and clean it up for use in more > than 32 mods. > > Hi, > > This series add support for MT8195's two VPPSYS(Video Processor Pipe Subsystem), > under which there will be corresponding MMSYS and MUTEX settings that > need to be configured. > > Moudy Ho (2): > dt-bindings: arm: mediatek: mmsys: Add support for MT8195 VPPSYS > arm64: dts: mediatek: mt8195: add MUTEX configuration for VPPSYS > > Roy-CW.Yeh (6): > dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS > arm64: dts: mediatek: mt8195: add MMSYS configuration for VPPSYS > soc: mediatek: mmsys: add support for MT8195 VPPSYS > soc: mediatek: mmsys: add config api for RSZ switching and DCM > soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1 > soc: mediatek: mutex: support MT8195 VPPSYS > > .../bindings/arm/mediatek/mediatek,mmsys.yaml | 5 +- > .../bindings/soc/mediatek/mediatek,mutex.yaml | 1 + > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 28 +++- > drivers/soc/mediatek/mt8195-mmsys.h | 13 ++ > drivers/soc/mediatek/mtk-mmsys.c | 64 +++++++++ > drivers/soc/mediatek/mtk-mmsys.h | 1 + > drivers/soc/mediatek/mtk-mutex.c | 135 +++++++++++++++++- > include/linux/soc/mediatek/mtk-mmsys.h | 4 + > include/linux/soc/mediatek/mtk-mutex.h | 35 +++++ > 9 files changed, 274 insertions(+), 12 deletions(-) >
On 16/12/2022 13:33, Matthias Brugger wrote: > > Whole series applied, thanks! > And now, whole series reverted, please see comment in 1/8. Regards, Matthias > On 07/12/2022 10:49, Moudy Ho wrote: >> From: mtk18742 <moudy.ho@mediatek.com> >> >> Changes since v3: >> - Rebase on linux-next >> >> Changes since v2: >> - Depend on : >> [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097 >> - Split dts settings into two patches based on belonging to MMSYS or MUTEX. >> >> Changes since v1: >> - Depend on : >> [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097 >> - Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding file. >> - Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check. >> - Rename mtk_mmsys_merge_config() and mtk_mmsys_rsz_dcm_config() to >> mtk_mmsys_vpp_rsz_merge_config() and mtk_mmsys_vpp_rsz_dcm_config(). >> - Clean up mtk_mmsys_vpp_rsz_dcm_config(). >> - Add a comment to mtk_mutex_write_mod() and clean it up for use in more >> than 32 mods. >> >> Hi, >> >> This series add support for MT8195's two VPPSYS(Video Processor Pipe Subsystem), >> under which there will be corresponding MMSYS and MUTEX settings that >> need to be configured. >> >> Moudy Ho (2): >> dt-bindings: arm: mediatek: mmsys: Add support for MT8195 VPPSYS >> arm64: dts: mediatek: mt8195: add MUTEX configuration for VPPSYS >> >> Roy-CW.Yeh (6): >> dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS >> arm64: dts: mediatek: mt8195: add MMSYS configuration for VPPSYS >> soc: mediatek: mmsys: add support for MT8195 VPPSYS >> soc: mediatek: mmsys: add config api for RSZ switching and DCM >> soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1 >> soc: mediatek: mutex: support MT8195 VPPSYS >> >> .../bindings/arm/mediatek/mediatek,mmsys.yaml | 5 +- >> .../bindings/soc/mediatek/mediatek,mutex.yaml | 1 + >> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 28 +++- >> drivers/soc/mediatek/mt8195-mmsys.h | 13 ++ >> drivers/soc/mediatek/mtk-mmsys.c | 64 +++++++++ >> drivers/soc/mediatek/mtk-mmsys.h | 1 + >> drivers/soc/mediatek/mtk-mutex.c | 135 +++++++++++++++++- >> include/linux/soc/mediatek/mtk-mmsys.h | 4 + >> include/linux/soc/mediatek/mtk-mutex.h | 35 +++++ >> 9 files changed, 274 insertions(+), 12 deletions(-) >>
On Mon, 2022-12-19 at 16:17 +0100, Matthias Brugger wrote: > > On 16/12/2022 13:33, Matthias Brugger wrote: > > > > Whole series applied, thanks! > > > > And now, whole series reverted, please see comment in 1/8. > > Regards, > Matthias > Hi Matthias, May I send a new series without a fallback compatible like the mt8188 VDOSYS does? https://patchwork.kernel.org/project/linux-mediatek/patch/20221206020046.11333-3-nathan.lu@mediatek.com/ Regards, Moudy > > On 07/12/2022 10:49, Moudy Ho wrote: > > > From: mtk18742 <moudy.ho@mediatek.com> > > > > > > Changes since v3: > > > - Rebase on linux-next > > > > > > Changes since v2: > > > - Depend on : > > > [1] > > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097__;!!CTRNKA9wMg0ARbw!giZVy8TiFNylgWKOjI75fSmleN6UlckPuiXzFf5jbdVgFbHdIxG3d3Jvkqp7Eka73I2TmataD_d5QjzBnk6-sYY$ > > > > > > - Split dts settings into two patches based on belonging to MMSYS > > > or MUTEX. > > > > > > Changes since v1: > > > - Depend on : > > > [1] > > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097__;!!CTRNKA9wMg0ARbw!giZVy8TiFNylgWKOjI75fSmleN6UlckPuiXzFf5jbdVgFbHdIxG3d3Jvkqp7Eka73I2TmataD_d5QjzBnk6-sYY$ > > > > > > - Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding > > > file. > > > - Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check. > > > - Rename mtk_mmsys_merge_config() and mtk_mmsys_rsz_dcm_config() > > > to > > > mtk_mmsys_vpp_rsz_merge_config() and > > > mtk_mmsys_vpp_rsz_dcm_config(). > > > - Clean up mtk_mmsys_vpp_rsz_dcm_config(). > > > - Add a comment to mtk_mutex_write_mod() and clean it up for use > > > in more > > > than 32 mods. > > > > > > Hi, > > > > > > This series add support for MT8195's two VPPSYS(Video Processor > > > Pipe Subsystem), > > > under which there will be corresponding MMSYS and MUTEX settings > > > that > > > need to be configured. > > > > > > Moudy Ho (2): > > > dt-bindings: arm: mediatek: mmsys: Add support for MT8195 > > > VPPSYS > > > arm64: dts: mediatek: mt8195: add MUTEX configuration for > > > VPPSYS > > > > > > Roy-CW.Yeh (6): > > > dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS > > > arm64: dts: mediatek: mt8195: add MMSYS configuration for > > > VPPSYS > > > soc: mediatek: mmsys: add support for MT8195 VPPSYS > > > soc: mediatek: mmsys: add config api for RSZ switching and DCM > > > soc: mediatek: mutex: Add mtk_mutex_set_mod support to set > > > MOD1 > > > soc: mediatek: mutex: support MT8195 VPPSYS > > > > > > .../bindings/arm/mediatek/mediatek,mmsys.yaml | 5 +- > > > .../bindings/soc/mediatek/mediatek,mutex.yaml | 1 + > > > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 28 +++- > > > drivers/soc/mediatek/mt8195-mmsys.h | 13 ++ > > > drivers/soc/mediatek/mtk-mmsys.c | 64 +++++++++ > > > drivers/soc/mediatek/mtk-mmsys.h | 1 + > > > drivers/soc/mediatek/mtk-mutex.c | 135 > > > +++++++++++++++++- > > > include/linux/soc/mediatek/mtk-mmsys.h | 4 + > > > include/linux/soc/mediatek/mtk-mutex.h | 35 +++++ > > > 9 files changed, 274 insertions(+), 12 deletions(-) > > >
On Tue, 2022-12-20 at 10:14 +0800, moudy ho wrote: > On Mon, 2022-12-19 at 16:17 +0100, Matthias Brugger wrote: > > > > On 16/12/2022 13:33, Matthias Brugger wrote: > > > > > > Whole series applied, thanks! > > > > > > > And now, whole series reverted, please see comment in 1/8. > > > > Regards, > > Matthias > > > > Hi Matthias, > > May I send a new series without a fallback compatible like the mt8188 > VDOSYS does? > > https://patchwork.kernel.org/project/linux-mediatek/patch/20221206020046.11333-3-nathan.lu@mediatek.com/ > > Regards, > Moudy Hi Matthias, Sorry for the inaccurate information, the warning mentioned in [1/8] is because vppsys 0/1 has already been defined in "mediatek,mt8195- clock.yaml" as follows: https://patchwork.kernel.org/project/linux-mediatek/patch/20210914021633.26377-2-chun-jie.chen@mediatek.com/ Is it possible to fix it by just removing [1/8], or should I send a new series? Regards, Moudy > > > On 07/12/2022 10:49, Moudy Ho wrote: > > > > From: mtk18742 <moudy.ho@mediatek.com> > > > > > > > > Changes since v3: > > > > - Rebase on linux-next > > > > > > > > Changes since v2: > > > > - Depend on : > > > > [1] > > > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097__;!!CTRNKA9wMg0ARbw!giZVy8TiFNylgWKOjI75fSmleN6UlckPuiXzFf5jbdVgFbHdIxG3d3Jvkqp7Eka73I2TmataD_d5QjzBnk6-sYY$ > > > > > > > > > > > > - Split dts settings into two patches based on belonging to > > > > MMSYS > > > > or MUTEX. > > > > > > > > Changes since v1: > > > > - Depend on : > > > > [1] > > > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097__;!!CTRNKA9wMg0ARbw!giZVy8TiFNylgWKOjI75fSmleN6UlckPuiXzFf5jbdVgFbHdIxG3d3Jvkqp7Eka73I2TmataD_d5QjzBnk6-sYY$ > > > > > > > > > > > > - Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding > > > > file. > > > > - Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check. > > > > - Rename mtk_mmsys_merge_config() and > > > > mtk_mmsys_rsz_dcm_config() > > > > to > > > > mtk_mmsys_vpp_rsz_merge_config() and > > > > mtk_mmsys_vpp_rsz_dcm_config(). > > > > - Clean up mtk_mmsys_vpp_rsz_dcm_config(). > > > > - Add a comment to mtk_mutex_write_mod() and clean it up for > > > > use > > > > in more > > > > than 32 mods. > > > > > > > > Hi, > > > > > > > > This series add support for MT8195's two VPPSYS(Video Processor > > > > Pipe Subsystem), > > > > under which there will be corresponding MMSYS and MUTEX > > > > settings > > > > that > > > > need to be configured. > > > > > > > > Moudy Ho (2): > > > > dt-bindings: arm: mediatek: mmsys: Add support for MT8195 > > > > VPPSYS > > > > arm64: dts: mediatek: mt8195: add MUTEX configuration for > > > > VPPSYS > > > > > > > > Roy-CW.Yeh (6): > > > > dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS > > > > arm64: dts: mediatek: mt8195: add MMSYS configuration for > > > > VPPSYS > > > > soc: mediatek: mmsys: add support for MT8195 VPPSYS > > > > soc: mediatek: mmsys: add config api for RSZ switching and > > > > DCM > > > > soc: mediatek: mutex: Add mtk_mutex_set_mod support to set > > > > MOD1 > > > > soc: mediatek: mutex: support MT8195 VPPSYS > > > > > > > > .../bindings/arm/mediatek/mediatek,mmsys.yaml | 5 +- > > > > .../bindings/soc/mediatek/mediatek,mutex.yaml | 1 + > > > > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 28 +++- > > > > drivers/soc/mediatek/mt8195-mmsys.h | 13 ++ > > > > drivers/soc/mediatek/mtk-mmsys.c | 64 +++++++++ > > > > drivers/soc/mediatek/mtk-mmsys.h | 1 + > > > > drivers/soc/mediatek/mtk-mutex.c | 135 > > > > +++++++++++++++++- > > > > include/linux/soc/mediatek/mtk-mmsys.h | 4 + > > > > include/linux/soc/mediatek/mtk-mutex.h | 35 +++++ > > > > 9 files changed, 274 insertions(+), 12 deletions(-) > > > >
Hi Moudy, On 20/12/2022 04:40, Moudy Ho (何宗原) wrote: > On Tue, 2022-12-20 at 10:14 +0800, moudy ho wrote: >> On Mon, 2022-12-19 at 16:17 +0100, Matthias Brugger wrote: >>> >>> On 16/12/2022 13:33, Matthias Brugger wrote: >>>> >>>> Whole series applied, thanks! >>>> >>> >>> And now, whole series reverted, please see comment in 1/8. >>> >>> Regards, >>> Matthias >>> >> >> Hi Matthias, >> >> May I send a new series without a fallback compatible like the mt8188 >> VDOSYS does? >> >> > https://patchwork.kernel.org/project/linux-mediatek/patch/20221206020046.11333-3-nathan.lu@mediatek.com/ >> >> Regards, >> Moudy > > Hi Matthias, > > Sorry for the inaccurate information, the warning mentioned in [1/8] is > because vppsys 0/1 has already been defined in "mediatek,mt8195- > clock.yaml" as follows: > > https://patchwork.kernel.org/project/linux-mediatek/patch/20210914021633.26377-2-chun-jie.chen@mediatek.com/ > > Is it possible to fix it by just removing [1/8], or should I send a new > series? > You will need to remove it from the clock binding and of course from the clock drivers. One example is this one: https://patchwork.kernel.org/project/linux-mediatek/patch/20210914021633.26377-21-chun-jie.chen@mediatek.com/ In the end the mmsys will probe by the compatible and will then probe the clock driver as a platform driver. Best regards, Matthias > Regards, > Moudy > >>>> On 07/12/2022 10:49, Moudy Ho wrote: >>>>> From: mtk18742 <moudy.ho@mediatek.com> >>>>> >>>>> Changes since v3: >>>>> - Rebase on linux-next >>>>> >>>>> Changes since v2: >>>>> - Depend on : >>>>> [1] >>>>> > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097__;!!CTRNKA9wMg0ARbw!giZVy8TiFNylgWKOjI75fSmleN6UlckPuiXzFf5jbdVgFbHdIxG3d3Jvkqp7Eka73I2TmataD_d5QjzBnk6-sYY$ >>>>> >>>>> >>>>> - Split dts settings into two patches based on belonging to >>>>> MMSYS >>>>> or MUTEX. >>>>> >>>>> Changes since v1: >>>>> - Depend on : >>>>> [1] >>>>> > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097__;!!CTRNKA9wMg0ARbw!giZVy8TiFNylgWKOjI75fSmleN6UlckPuiXzFf5jbdVgFbHdIxG3d3Jvkqp7Eka73I2TmataD_d5QjzBnk6-sYY$ >>>>> >>>>> >>>>> - Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding >>>>> file. >>>>> - Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check. >>>>> - Rename mtk_mmsys_merge_config() and >>>>> mtk_mmsys_rsz_dcm_config() >>>>> to >>>>> mtk_mmsys_vpp_rsz_merge_config() and >>>>> mtk_mmsys_vpp_rsz_dcm_config(). >>>>> - Clean up mtk_mmsys_vpp_rsz_dcm_config(). >>>>> - Add a comment to mtk_mutex_write_mod() and clean it up for >>>>> use >>>>> in more >>>>> than 32 mods. >>>>> >>>>> Hi, >>>>> >>>>> This series add support for MT8195's two VPPSYS(Video Processor >>>>> Pipe Subsystem), >>>>> under which there will be corresponding MMSYS and MUTEX >>>>> settings >>>>> that >>>>> need to be configured. >>>>> >>>>> Moudy Ho (2): >>>>> dt-bindings: arm: mediatek: mmsys: Add support for MT8195 >>>>> VPPSYS >>>>> arm64: dts: mediatek: mt8195: add MUTEX configuration for >>>>> VPPSYS >>>>> >>>>> Roy-CW.Yeh (6): >>>>> dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS >>>>> arm64: dts: mediatek: mt8195: add MMSYS configuration for >>>>> VPPSYS >>>>> soc: mediatek: mmsys: add support for MT8195 VPPSYS >>>>> soc: mediatek: mmsys: add config api for RSZ switching and >>>>> DCM >>>>> soc: mediatek: mutex: Add mtk_mutex_set_mod support to set >>>>> MOD1 >>>>> soc: mediatek: mutex: support MT8195 VPPSYS >>>>> >>>>> .../bindings/arm/mediatek/mediatek,mmsys.yaml | 5 +- >>>>> .../bindings/soc/mediatek/mediatek,mutex.yaml | 1 + >>>>> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 28 +++- >>>>> drivers/soc/mediatek/mt8195-mmsys.h | 13 ++ >>>>> drivers/soc/mediatek/mtk-mmsys.c | 64 +++++++++ >>>>> drivers/soc/mediatek/mtk-mmsys.h | 1 + >>>>> drivers/soc/mediatek/mtk-mutex.c | 135 >>>>> +++++++++++++++++- >>>>> include/linux/soc/mediatek/mtk-mmsys.h | 4 + >>>>> include/linux/soc/mediatek/mtk-mutex.h | 35 +++++ >>>>> 9 files changed, 274 insertions(+), 12 deletions(-) >>>>>
From: mtk18742 <moudy.ho@mediatek.com> Changes since v3: - Rebase on linux-next Changes since v2: - Depend on : [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097 - Split dts settings into two patches based on belonging to MMSYS or MUTEX. Changes since v1: - Depend on : [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097 - Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding file. - Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check. - Rename mtk_mmsys_merge_config() and mtk_mmsys_rsz_dcm_config() to mtk_mmsys_vpp_rsz_merge_config() and mtk_mmsys_vpp_rsz_dcm_config(). - Clean up mtk_mmsys_vpp_rsz_dcm_config(). - Add a comment to mtk_mutex_write_mod() and clean it up for use in more than 32 mods. Hi, This series add support for MT8195's two VPPSYS(Video Processor Pipe Subsystem), under which there will be corresponding MMSYS and MUTEX settings that need to be configured. Moudy Ho (2): dt-bindings: arm: mediatek: mmsys: Add support for MT8195 VPPSYS arm64: dts: mediatek: mt8195: add MUTEX configuration for VPPSYS Roy-CW.Yeh (6): dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS arm64: dts: mediatek: mt8195: add MMSYS configuration for VPPSYS soc: mediatek: mmsys: add support for MT8195 VPPSYS soc: mediatek: mmsys: add config api for RSZ switching and DCM soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1 soc: mediatek: mutex: support MT8195 VPPSYS .../bindings/arm/mediatek/mediatek,mmsys.yaml | 5 +- .../bindings/soc/mediatek/mediatek,mutex.yaml | 1 + arch/arm64/boot/dts/mediatek/mt8195.dtsi | 28 +++- drivers/soc/mediatek/mt8195-mmsys.h | 13 ++ drivers/soc/mediatek/mtk-mmsys.c | 64 +++++++++ drivers/soc/mediatek/mtk-mmsys.h | 1 + drivers/soc/mediatek/mtk-mutex.c | 135 +++++++++++++++++- include/linux/soc/mediatek/mtk-mmsys.h | 4 + include/linux/soc/mediatek/mtk-mutex.h | 35 +++++ 9 files changed, 274 insertions(+), 12 deletions(-)