| Message ID | 1670924929-26507-2-git-send-email-quic_srivasam@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Update section header name check | expand |
On 13/12/22 10:48, Srinivasa Rao Mandadapu wrote: > Update the way of checking resource table name with prefix > substring search instead of complete string search. > In general Qualcomm DSP binary is prepared by combining different elfs, Maybe 'ELFs'? (twice). > hence section header name (e.g. .resource_table), appended with elf name > to differentiate with same section of different elfs. Please include here the section info parsed by readelf as an example, as suggested by Stephen in your v1: https://lore.kernel.org/linux-remoteproc/CAE-0n52cNite8-4HDoQcsZ+UvZFkJU8c5oUjxPB5ag5WP6E9=g@mail.gmail.com/ > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > --- > Changes since v1: > -- Update the commit message. > -- Use strstarts instead of strstr. > > drivers/remoteproc/remoteproc_elf_loader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c > index 5a412d7..77330d6 100644 > --- a/drivers/remoteproc/remoteproc_elf_loader.c > +++ b/drivers/remoteproc/remoteproc_elf_loader.c > @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct firmware *fw) > u64 offset = elf_shdr_get_sh_offset(class, shdr); > u32 name = elf_shdr_get_sh_name(class, shdr); > > - if (strcmp(name_table + name, ".resource_table")) > + if (!strstarts(name_table + name, ".resource_table")) > continue; > > table = (struct resource_table *)(elf_data + offset);
On 12/15/2022 12:36 PM, Philippe Mathieu-Daudé wrote: Thanks for your time Phil!!! > On 13/12/22 10:48, Srinivasa Rao Mandadapu wrote: >> Update the way of checking resource table name with prefix >> substring search instead of complete string search. >> In general Qualcomm DSP binary is prepared by combining different elfs, > > Maybe 'ELFs'? (twice). Okay. Will update accordingly. > >> hence section header name (e.g. .resource_table), appended with elf name >> to differentiate with same section of different elfs. > > Please include here the section info parsed by readelf as an example, > as suggested by Stephen in your v1: > https://lore.kernel.org/linux-remoteproc/CAE-0n52cNite8-4HDoQcsZ+UvZFkJU8c5oUjxPB5ag5WP6E9=g@mail.gmail.com/ > Okay. Will include example and re-spin the patch set. > >> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> >> --- >> Changes since v1: >> -- Update the commit message. >> -- Use strstarts instead of strstr. >> >> drivers/remoteproc/remoteproc_elf_loader.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c >> b/drivers/remoteproc/remoteproc_elf_loader.c >> index 5a412d7..77330d6 100644 >> --- a/drivers/remoteproc/remoteproc_elf_loader.c >> +++ b/drivers/remoteproc/remoteproc_elf_loader.c >> @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct >> firmware *fw) >> u64 offset = elf_shdr_get_sh_offset(class, shdr); >> u32 name = elf_shdr_get_sh_name(class, shdr); >> - if (strcmp(name_table + name, ".resource_table")) >> + if (!strstarts(name_table + name, ".resource_table")) >> continue; >> table = (struct resource_table *)(elf_data + offset); >
diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c index 5a412d7..77330d6 100644 --- a/drivers/remoteproc/remoteproc_elf_loader.c +++ b/drivers/remoteproc/remoteproc_elf_loader.c @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct firmware *fw) u64 offset = elf_shdr_get_sh_offset(class, shdr); u32 name = elf_shdr_get_sh_name(class, shdr); - if (strcmp(name_table + name, ".resource_table")) + if (!strstarts(name_table + name, ".resource_table")) continue; table = (struct resource_table *)(elf_data + offset);
Update the way of checking resource table name with prefix substring search instead of complete string search. In general Qualcomm DSP binary is prepared by combining different elfs, hence section header name (e.g. .resource_table), appended with elf name to differentiate with same section of different elfs. Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> --- Changes since v1: -- Update the commit message. -- Use strstarts instead of strstr. drivers/remoteproc/remoteproc_elf_loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)