| Message ID | 20221128122952.51680-1-johannes.thumshirn@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fstests: skip btrfs/253 for zoned devices | expand |
On Mon, Nov 28, 2022 at 04:29:52AM -0800, Johannes Thumshirn wrote: > The test-case btrfs/253 tests btrfs' chunk size setting, which is not > available on zoned btrfs, so the test will always fail. > > Skip the test in case of a zoned device. > > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Reviewed-by: Josef Bacik <josef@toxicpanda.com> Thanks, Josef
On 28.11.22 13:30, Johannes Thumshirn wrote: > The test-case btrfs/253 tests btrfs' chunk size setting, which is not > available on zoned btrfs, so the test will always fail. > > Skip the test in case of a zoned device. > > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > --- > tests/btrfs/253 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/btrfs/253 b/tests/btrfs/253 > index fbbb81fae754..99eaee1e7cde 100755 > --- a/tests/btrfs/253 > +++ b/tests/btrfs/253 > @@ -81,6 +81,7 @@ alloc_size() { > _supported_fs btrfs > _require_test > _require_scratch > +_require_non_zoned_device "${SCRATCH_DEV}" > > # Delete log file if it exists. > rm -f "${seqres}.full" Ping?
On Tue, Dec 20, 2022 at 09:19:06AM +0000, Johannes Thumshirn wrote: > On 28.11.22 13:30, Johannes Thumshirn wrote: > > The test-case btrfs/253 tests btrfs' chunk size setting, which is not > > available on zoned btrfs, so the test will always fail. > > > > Skip the test in case of a zoned device. > > > > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > > --- > > tests/btrfs/253 | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/btrfs/253 b/tests/btrfs/253 > > index fbbb81fae754..99eaee1e7cde 100755 > > --- a/tests/btrfs/253 > > +++ b/tests/btrfs/253 > > @@ -81,6 +81,7 @@ alloc_size() { > > _supported_fs btrfs > > _require_test > > _require_scratch > > +_require_non_zoned_device "${SCRATCH_DEV}" > > > > # Delete log file if it exists. > > rm -f "${seqres}.full" > > Ping? Do I misunderstand something? I think this issue has been fixed long time ago, by: commit 2925f3b7f7738f85aabef4e8fe02f257fce0b786 Author: Naohiro Aota <naohiro.aota@wdc.com> Date: Tue Jul 26 16:57:59 2022 +0900 btrfs/253: skip on zoned mode as we cannot change the chunk size Which xfstests version do you use? Do you still hit any problems? Thanks, Zorro
On 20.12.22 11:14, Zorro Lang wrote: > On Tue, Dec 20, 2022 at 09:19:06AM +0000, Johannes Thumshirn wrote: >> On 28.11.22 13:30, Johannes Thumshirn wrote: >>> The test-case btrfs/253 tests btrfs' chunk size setting, which is not >>> available on zoned btrfs, so the test will always fail. >>> >>> Skip the test in case of a zoned device. >>> >>> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> >>> --- >>> tests/btrfs/253 | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/tests/btrfs/253 b/tests/btrfs/253 >>> index fbbb81fae754..99eaee1e7cde 100755 >>> --- a/tests/btrfs/253 >>> +++ b/tests/btrfs/253 >>> @@ -81,6 +81,7 @@ alloc_size() { >>> _supported_fs btrfs >>> _require_test >>> _require_scratch >>> +_require_non_zoned_device "${SCRATCH_DEV}" >>> >>> # Delete log file if it exists. >>> rm -f "${seqres}.full" >> >> Ping? > > Do I misunderstand something? I think this issue has been fixed long time > ago, by: > > commit 2925f3b7f7738f85aabef4e8fe02f257fce0b786 > Author: Naohiro Aota <naohiro.aota@wdc.com> > Date: Tue Jul 26 16:57:59 2022 +0900 > > btrfs/253: skip on zoned mode as we cannot change the chunk size > > Which xfstests version do you use? Do you still hit any problems? Whoopsie, maybe it's time for a rebase. My bad sorry.
diff --git a/tests/btrfs/253 b/tests/btrfs/253 index fbbb81fae754..99eaee1e7cde 100755 --- a/tests/btrfs/253 +++ b/tests/btrfs/253 @@ -81,6 +81,7 @@ alloc_size() { _supported_fs btrfs _require_test _require_scratch +_require_non_zoned_device "${SCRATCH_DEV}" # Delete log file if it exists. rm -f "${seqres}.full"
The test-case btrfs/253 tests btrfs' chunk size setting, which is not available on zoned btrfs, so the test will always fail. Skip the test in case of a zoned device. Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> --- tests/btrfs/253 | 1 + 1 file changed, 1 insertion(+)