[0/8] Clean up and refinement for maple tree

Message

Vernon Yang Dec. 20, 2022, 2:08 p.m. UTC

Hello,

This patchset clean up and refinement some maple tree code, a few small
changes make the code easier to understand and for better readability.

Vernon Yang (8):
  maple_tree: remove extra space and blank line
  maple_tree: remove extra return statement
  maple_tree: use mt_node_max() instead of direct operations mt_max[]
  maple_tree: use macro MA_ROOT_PARENT instead of number
  maple_tree: remove the redundant code
  maple_tree: change return type of mas_commit_b_node()
  maple_tree: refine ma_state init from mas_start()
  maple_tree: refine mab_calc_split function

 include/linux/maple_tree.h |  6 ------
 lib/maple_tree.c           | 41 ++++++++++++++------------------------
 2 files changed, 15 insertions(+), 32 deletions(-)

--
2.34.1

Comments

Liam R. Howlett Dec. 20, 2022, 3:19 p.m. UTC | #1

* Vernon Yang <[e-mail]> [221220 09:09]:
> Hello,
> 
> This patchset clean up and refinement some maple tree code, a few small
> changes make the code easier to understand and for better readability.

Thanks for looking at the maple tree.  It seems somehow this cover
letter is detached from the series found here [1].

All of these look good except 6 and 8, which I have responded to the
actual patch.  I've indicated below which is 6/8 and 8/8.


1. https://lore.kernel.org/linux-mm/[e-mail]/

Please add my reviewed-by to all patches besides 6 & 8.
Reviewed-by: Liam R. Howlett <[e-mail]>

> 
> Vernon Yang (8):
>   maple_tree: remove extra space and blank line
>   maple_tree: remove extra return statement
>   maple_tree: use mt_node_max() instead of direct operations mt_max[]
>   maple_tree: use macro MA_ROOT_PARENT instead of number
>   maple_tree: remove the redundant code
    ^--- 6

>   maple_tree: change return type of mas_commit_b_node()
>   maple_tree: refine ma_state init from mas_start()
>   maple_tree: refine mab_calc_split function
    ^--- 8
> 
>  include/linux/maple_tree.h |  6 ------
>  lib/maple_tree.c           | 41 ++++++++++++++------------------------
>  2 files changed, 15 insertions(+), 32 deletions(-)
> 
> --
> 2.34.1
>

Vernon Yang Dec. 21, 2022, 5:03 a.m. UTC | #2

On Tue, Dec 20, 2022 at 03:19:08PM +0000, Liam Howlett wrote:
> * Vernon Yang <[e-mail]> [221220 09:09]:
> > Hello,
> >
> > This patchset clean up and refinement some maple tree code, a few small
> > changes make the code easier to understand and for better readability.
>
> Thanks for looking at the maple tree.  It seems somehow this cover
> letter is detached from the series found here [1].
When sending the patch, my network disconnected a bit and then
resent it again, maybe, perhaps... becomes like this.

>
> All of these look good except 6 and 8, which I have responded to the
> actual patch.  I've indicated below which is 6/8 and 8/8.
>
>
> 1. https://lore.kernel.org/linux-mm/[e-mail]/
>
> Please add my reviewed-by to all patches besides 6 & 8.
> Reviewed-by: Liam R. Howlett <[e-mail]>
Okay，thank you reviewed this patchset.

>
> >
> > Vernon Yang (8):
> >   maple_tree: remove extra space and blank line
> >   maple_tree: remove extra return statement
> >   maple_tree: use mt_node_max() instead of direct operations mt_max[]
> >   maple_tree: use macro MA_ROOT_PARENT instead of number
> >   maple_tree: remove the redundant code
>     ^--- 6
>
> >   maple_tree: change return type of mas_commit_b_node()
> >   maple_tree: refine ma_state init from mas_start()
> >   maple_tree: refine mab_calc_split function
>     ^--- 8
> >
> >  include/linux/maple_tree.h |  6 ------
> >  lib/maple_tree.c           | 41 ++++++++++++++------------------------
> >  2 files changed, 15 insertions(+), 32 deletions(-)
> >
> > --
> > 2.34.1
> >